-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compilation fixes #4
Conversation
b0ebb2e
to
67569c7
Compare
| "false" -> [] | ||
| _ -> auto | ||
| exception Not_found -> auto in | ||
Format.(printf "(@[%a@])%!" (fun ppf -> List.iter (fprintf ppf "%s@ ")) fs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use Configurator.V1.Flags.write_sexp here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I do not know how to do this. I am unable to find the documentation / API of Configurator.V1.Flags
. this cfg.exe
is used by src/dune
(with a rule (rule (with-stdout-to c_flags.sexp (run ../config/cfg.exe)))
) as well as xen/dune and freestanding/dune.
From https://dune.readthedocs.io/en/stable/quick-start.html#defining-a-library-with-c-stubs I gather that your proposed write_sexp
takes two arguments, a file name and an OCaml value - but it is rather unclear to me where the output is written to, then (in terms of relative path).
This reverts commit a58c653.
Adapted by @hannesm to use the comment /* fall through */ instead of the __attribute__((fallthrough)); to silence clang and gcc<7 warnings "declaration does not declare anything [-Wmissing-declarations]"
…void unused function warnings
this prepares support for xen and freestanding cross-compilation
thanks for your reviews. I force-pushed to add a lower bound of OCaml 4.07.0 -- and then removed the |
hmm, now when I run
but in another question about CI: is it possible that it runs with optional dependencies? (in case the answer is no (what I expect), I guess an appropriate solution is to have separate packages (though I'm not sure how this would work with the |
Yeah, separate packages would be great! If you need to force optional deps to be installed in CI as a quick fix though you could always add a dummy opam package that depends on all the optional stuff. Or you could make the optional dependencies required for tests. |
@talex5 thanks for your quick and valuable response. Since I'm not eager to accumulate hacks in this repository, but will subsequently revise the package layout (not in this PR). |
best viewed commit by commit. this is supposed to achieve the following (by cherry-picking and polishing commits from a multitude of forks):
dune-configurator
andbigarray-compat
-Wno-implicit-fallthrough
, since this is a reasonable warning. instead, mark the case statements explicitly where a fallthrough is expected (use a C comment instead of annotation to make gcc<7 and clang not complain)src/native
directory and copying around)warning -3
is in nocrypto_lwt_entropythe freestanding and xen support
is not yet properly tested (and may need some more work)works fine (a static_website_tls unikernel links, and the freestanding/hvt one also runs smoothly), I'll follow up on that. once this is good to go, the renaming could happen.