Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lwt_sequence is deprecated #349

Closed
djs55 opened this issue Feb 14, 2018 · 7 comments
Closed

Lwt_sequence is deprecated #349

djs55 opened this issue Feb 14, 2018 · 7 comments

Comments

@djs55
Copy link
Member

djs55 commented Feb 14, 2018

A manual build (with --dev) fails with:

File "src/tcp/segment.ml", line 32, characters 8-31:
Error (warning 3): deprecated: module Lwt_sequence
 This module is an implementation detail of Lwt. See
   https://github.com/ocsigen/lwt/issues/361

Related to [ocsigen/lwt#361]

@dinosaure
Copy link
Member

Any plan to fix it? I can take my time to try to fix it (needed to git-mirage).

@yomimono
Copy link
Contributor

yomimono commented Mar 1, 2018

@dinosaure I won't have time to fix this in the next couple of weeks and would welcome a PR addressing it.

@dinosaure
Copy link
Member

Ok. I will make something when @samoht will confirm to me that is the source of bug 👍 .

@bikallem
Copy link

@dinosaure may I know how you are planning to fix this issue. https://github.com/diml/lambda-term also needs to be updated to use a different doubly linked list. Will you be using a separate implementation of doubly linked list perhaps or per use Lwt_sequence with a different name?

@dinosaure
Copy link
Member

According to what I said to @yomimono at the last hackathon, my goal is to provide a proved implementation of a double linked-list. I just discover in a paper than it's not possible to use Why3 in this case. So the plan is to use CFML/Coq instead. So, of course, this library will be outside mirage-tcpip and will be used in lambda-term too.

@yomimono
Copy link
Contributor

See also mirage/mirage#889 , the higher-level tracking issue for lwt 4.0.0 and mirage.

@hannesm
Copy link
Member

hannesm commented Feb 25, 2019

since #388 this no longer uses lwt_sequence.

@hannesm hannesm closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants