Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fd leak in handle_files #978

Closed
mseri opened this issue Apr 4, 2023 · 0 comments · Fixed by #977
Closed

Fd leak in handle_files #978

mseri opened this issue Apr 4, 2023 · 0 comments · Fixed by #977

Comments

@mseri
Copy link
Collaborator

mseri commented Apr 4, 2023

There are scenarios if a client leaves before consuming the full response,
we might have a reference to a stream that doesn't get drained.

Not draining or closing the stream can lead to issues if its holding a resource like
a file handle as those resources will never be closed, leading to a leak.

Reported by Stéphane Glondu
Fix by samhot and anuragsoni in #977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant