Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support URNs #67

Closed
Chris00 opened this issue Apr 9, 2015 · 1 comment
Closed

Support URNs #67

Chris00 opened this issue Apr 9, 2015 · 1 comment
Labels
enhancement
Milestone
1.9

Comments

@Chris00
Copy link
Contributor

Chris00 commented Apr 9, 2015

It would be great if Uri supported URNs. While Uri.of_string works on them, Uri.to_string percent-encode some : when it shouldn't:

# Uri.to_string(Uri.of_string "urn:uuid:6fb03739-4ac3-5a9b-b5de-1d22890bbee6");;
 - : string = "urn:uuid%3A6fb03739-4ac3-5a9b-b5de-1d22890bbee6"

Possibly, the components should also be updated for these.
@Chris00
Copy link
Contributor Author

Chris00 commented Apr 9, 2015

See also https://www.ietf.org/rfc/rfc2141.txt

@Chris00 Chris00 mentioned this issue Apr 16, 2015
Merged
@dsheets dsheets added this to the 1.9 milestone Apr 17, 2015
dsheets added a commit to dsheets/ocaml-uri that referenced this issue Apr 17, 2015
@dsheets
Allow colon (":") in path segments
c13cd6b 
Permits correct parsing/printing of URNs. Fixes mirage#67.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
2 participants
@dsheets @Chris00