Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some stuff #7

Merged
merged 4 commits into from
Jun 4, 2020
Merged

Some stuff #7

merged 4 commits into from
Jun 4, 2020

Conversation

lutz
Copy link
Contributor

@lutz lutz commented Jun 4, 2020

  • includes new localization system
  • some code cleanups
  • (hopefully) completely german support
  • integrate FormBase class to to support some windows forms ui events

lutz added 4 commits June 4, 2020 13:48
- formbase added
- german localization
-  use same form class structure
- new localize logik
@Belim Belim merged commit 28db487 into builtbybel:master Jun 4, 2020
@Belim
Copy link
Member

Belim commented Jun 5, 2020

DriveSelectionHandler is currently broken. BtnOK is without function

@lutz
Copy link
Contributor Author

lutz commented Jun 6, 2020

@Belim. What do you mean? The drive selection form should works correctly. The btnOk button is set as Accept button of the form and the btnExit button as Cancel button. If the user use it so DialogResult Property of Form ahould autoset through Ok or Cancel. So you dont need an click handler and so on.

@Belim
Copy link
Member

Belim commented Jun 6, 2020

@lutz Yes, I mean the Drivehandler and I have received numerous feedback that nothing happens when you press the Ok, Cancel button. I checked it quickly yesterday and I can confirm it. I can take a look at it by the night, if not before.

@lutz
Copy link
Contributor Author

lutz commented Jun 6, 2020

@Belim With the next pull request it should be worked again. I forgot to set the DialogResult Property of the Buttons and Call .ShowDialog for the Forms

@Belim Belim mentioned this pull request Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants