do not advertise RC4 #223
Merged
do not advertise RC4 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable RC4 by default (users who need RC4 can tweak the configuration) fixes #8
| @@ -39,8 +39,6 @@ module Ciphers = struct | |||
| `TLS_RSA_WITH_AES_256_CBC_SHA ; | |||
| `TLS_RSA_WITH_AES_128_CBC_SHA ; | |||
| `TLS_RSA_WITH_3DES_EDE_CBC_SHA ; | |||
| `TLS_RSA_WITH_RC4_128_SHA ; | |||
| `TLS_RSA_WITH_RC4_128_MD5 | |||
| ] | |||
There was a problem hiding this comment.
Well, this is a bit of a lie; removing ciphers we support from the list of supported ciphers is, um... yeah.
Nothing that couldn't be helped by a little rename and little rethink of what this list exactly means, or what potential similar lists defined next to it could mean.
|
Evil, evil RC4. |
|
I agree we need multiple sets here - of what the protocol implementation implements and what we're happy to use by default.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable RC4 by default (users who need RC4 can tweak the configuration)
fixes #8