Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split WSGI app into two, namespace it #100

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Split WSGI app into two, namespace it #100

merged 2 commits into from
Feb 6, 2019

Conversation

patrys
Copy link
Contributor

@patrys patrys commented Jan 29, 2019

Move GraphQLMiddleware from ariadne to ariadne.wsgi (so we can introduce ariadne.asgi with a similar layout).

@patrys patrys added in progress decision needed Sounds like good idea, but will need closer scrutiny for final decision. labels Jan 29, 2019
@patrys patrys requested a review from rafalp January 29, 2019 14:24
@rafalp rafalp mentioned this pull request Feb 2, 2019
Closed
@codecov
Copy link

codecov bot commented Feb 4, 2019 •
edited

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #100   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          38     38           
  Lines        1248   1266   +18     
=====================================
+ Hits         1248   1266   +18
Impacted Files Coverage Δ
tests/wsgi/test_request_data_reading.py 100% <ø> (ø)
tests/wsgi/test_query_execution.py 100% <ø> (ø)
ariadne/__init__.py 100% <ø> (ø) ⬆️
tests/wsgi/snapshots/snap_test_query_execution.py 100% <ø> (ø)
tests/wsgi/test_playground.py 100% <ø> (ø)
...ests/wsgi/snapshots/snap_test_custom_middleware.py 100% <ø> (ø)
tests/wsgi/snapshots/snap_test_playground.py 100% <ø> (ø)
...s/wsgi/snapshots/snap_test_request_data_reading.py 100% <ø> (ø)
tests/wsgi/test_simple_server.py 100% <100%> (ø)
ariadne/wsgi.py 100% <100%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5230f65...b0d92cc. Read the comment docs.

rafalp
rafalp suggested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@rafalp rafalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also rename the wsgi_middleware.rst docs to wsgi.rst or using_with_wsgi.rst?

docs/wsgi-middleware.rst Outdated Show resolved Hide resolved
@patrys patrys force-pushed the namespace-the-wsgi-app branch 2 times, most recently from 26946e2 to f928c4c Compare February 6, 2019 11:27
rafalp
rafalp reviewed Feb 6, 2019
View reviewed changes
docs/wsgi.rst Show resolved Hide resolved
@rafalp @patrys
Update docs/wsgi.rst
b0d92cc 
Co-Authored-By: patrys <81205+patrys@users.noreply.github.com>
@rafalp rafalp merged commit ecb67fa into mirumee:master Feb 6, 2019
@patrys patrys deleted the namespace-the-wsgi-app branch February 6, 2019 16:52
@rafalp rafalp mentioned this pull request Feb 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafalp rafalp rafalp approved these changes

Assignees
No one assigned
Labels
decision needed Sounds like good idea, but will need closer scrutiny for final decision. in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrys @rafalp