Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[BUG] 世界时间固定时,舰船AI报时语音循环播放 #16

Closed
sddsd2332 opened this issue Oct 4, 2022 · 0 comments · Fixed by #17
Closed

🐛[BUG] 世界时间固定时,舰船AI报时语音循环播放 #16

sddsd2332 opened this issue Oct 4, 2022 · 0 comments · Fixed by #17
Labels
bug Something isn't working

Comments

@sddsd2332
Copy link

🐛 描述(Description)

我在测试本地构建的ShinColle过程中发现,使用mek调试指令发现 当世界时间固定且不更新时,舰船的报时语音【默认开启】在开启状态下,会循环播放

📷 复现步骤(Steps to Reproduce)

1.确认舰船的报时语音为开启状态
2.使用指令/gamerule doDaylightCycle false 禁用世界时间更新
3.使用指令/time set 1999 设置一个会播放 报时语音的的时间段
4.舰船开始每tick报时

📄 [异常/日志]信息([Exception/Log] Information)

🚑 基本信息(Basic Information)

  • 程序版本或action构件日期(Program Version or Action component date):
  • 系统(OS):
  • 是否使用了其他mod(Are other mod used):

🖼 截图(Screenshots)

快速修复

if (!this.isMorph && ConfigHandler.timeKeeping && this.getStateFlag(ID.F.TimeKeeper) && this.isEntityAlive()) 添加判断 ,如果 doDaylightCycle 是false 则不工作
修改后的代码如下
if (!this.isMorph && ConfigHandler.timeKeeping && this.getStateFlag(ID.F.TimeKeeper) && this.isEntityAlive() && this.world.getGameRules().getBoolean("doDaylightCycle"))

@sddsd2332 sddsd2332 added the bug Something isn't working label Oct 4, 2022
@misaka10843 misaka10843 linked a pull request Oct 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant