-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when attempting to compile meeseeks_html5ever on M1 Macbook #46
Comments
The test project with only meeseeks as a dependency works on my old macbook, but not on the new one with an m1 processor, so this might be the issue. Again, without Rust/NIF knowledge, I'm not sure how to solve this. |
Thanks for the report. I don't have access to an M1 so testing is going to be a little tricky for me, but let's see what we can figure out. There are a number of issues around that document linker issues when compiling Rust related things for both Mac in general and M1 in particular. The Rustler library has issues/PRs (rusterlium/rustler#151, rusterlium/rustler#174, rusterlium/rustler#191) relating to a similar set of linker errors, but for the Meeseeks_Html5ever has a A different issue (PyO3/pyo3#1330 (comment)) suggests that a problem similar to yours can be resolved by adding an additional target to our
Do you think you would be able to clone MeeseeksHtml5ever locally, attempt to run tests ( |
Thanks @mischov for the detailed explanation and attempt at solving my problem. I'll try the steps you suggested (running the MeeseeksHtml5ever tests locally before and after the fix suggested around the cargo config) and report back! |
@mischov Running Applying the fix suggested in PyO3/pyo3#1330 (comment) and running Changing the
With this config I was able to run I'm happy to do a PR if you think it's ready and I'm also ok with you committing this yourself. |
Yes, please test on x86 as well, but I don't believe there should be any side effects. And yes, please do make a PR. |
Issue is resolved with PR #47 |
Fix is released as of Thank you again, @Sgoettschkes. |
This fixes the compilation on x86_64 and Arm (M1) machines running macOS. Reference: mischov/meeseeks_html5ever#46
I'm trying to get meeseeks to run within my project, but meeseeks_html5ever does not compile. I'm seeing the following output to
deps.compile
(trimmed for readability):I have installed rust using
brew install rust
and rust is available:I'm pretty sure I'm missing something, but I've never worked with Rust or NIFs so I can't really debug the issue.
The text was updated successfully, but these errors were encountered: