Add documentation for compiling binaries on OSX #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KevinCybura, can you add some context around the issue you're having? The previous issues you linked to were to solve issues with running |
|
Sorry let me give you some context. Currently Ive written a NIF and it works fine when running it in elixir. However I would also like to use my workspace for running just rust code as well so I would have to run compile my rust code using I added the same config as in this PR #174 to solve this problem. From my understanding if some wants to compile while using rustler on a mac that config is required to be in their workspace. Unless there is another solution that I couldn't find. If this is the only solution I think it would be good to document it for other mac users |
|
@KevinCybura I see. Ok, this makes sense to me. I wonder if a more user friendly solution would be to just generate the |
|
It would be great if the end user worry about this issue at all. Could you explain what you mean by in there by default? Do you mean as in the rustler/rustler_codgen crates? Ive tried moving the .cargo/config into rustler and rustler_codgen and then set a path to them in my cargo.toml however I still get the linker error I think it would have to be inside the users project root dir. |
|
What I mean is...in the This would allow us to remove the macOS hacks in the When that change happens we’d probably want the text you’ve written to be included in the CHANGELOG instead of the README. Does that make sense? @hansihe, what do you think? |
Merged
|
@KevinCybura thanks for the PR! This really helped us see a deficiency in the current generator and compiler flags! I'm going to close in favor of #192, which will automatically generate the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to Link on OSX ive been getting linker errors similar to this Issue
#151
I've done some investigation and saw that there was an attempt to solve this problem here
#174
However it didn't solve it for me until I add the .cargo/config to my project. So I think add this documentation would be useful