Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Updates into Local Branch #2

Merged
merged 184 commits into from
Sep 20, 2023
Merged

Pull Updates into Local Branch #2

merged 184 commits into from
Sep 20, 2023

Commits on Aug 24, 2023

  1. Build/Test Tools: Implicitly pass secrets to the called workflow.

    This ensures the Hosting Test results API key is present for reporting results.
    
    Follow up to [56439] and [56440].
    
    See #30462.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56443 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    416d1a8 View commit details
    Browse the repository at this point in the history
  2. Build/Tests: Tests_Formatting_MakeClickable should use data providors

    Removes the foreach loops from the tests by moving the in-test data sets into data providers and combines the URL data sets into one data provider to test with one test method. By using a data providor, all the tests run rather than stopping at the first failure in this group.
    
    Fixes #57660.
    Props hellofromTonya.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56444 602fd350-edb4-49c9-b593-d223f7449a82
    aaronjorbin committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c63e32f View commit details
    Browse the repository at this point in the history
  3. Options, Meta APIs: Introduce prime_options() to load multiple opti…

    …ons with a single database request.
    
    WordPress's `get_option()` function generally relies on making individual database requests for each option, however with the majority of options (in most cases) being autoloaded, i.e. fetched once with a single database request and then stored in (memory) cache.
    
    As part of a greater effort to reduce the amount of options that are unnecessarily autoloaded, this changeset introduces an alternative way to retrieve multiple options in a performant manner, with a single database request. This provides a reasonable alternative for e.g. plugins that use several options which only need to be loaded in a few specific screens.
    
    Specifically, this changeset introduces the following functions:
    * `prime_options( $options )` is the foundation to load multiple specific options with a single database request. Only options that aren't already cached (in `alloptions` or an individual cache) are retrieved from the database.
    * `prime_options_by_group( $option_group )` is a convenience wrapper function for the above which allows to prime all options of a specific option group (as configured via `register_setting()`).
    * `get_options( $options )` is another wrapper function which first primes the requested options and then returns them in an associative array, calling `get_option()` for each of them.
    
    Props mukesh27, joemcgill, costdev, olliejones.
    Fixes #58962.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56445 602fd350-edb4-49c9-b593-d223f7449a82
    flixos90 committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    81423c3 View commit details
    Browse the repository at this point in the history
  4. Plugins: Correctly display spaces in new plugins search results.

    Ensures the encoded search term in the input field is correctly decoded again.
    
    Follow-up to [53844] and [54904].
    
    Props adhun, nithi22, huzaifaalmesbah, deepakvijayan, zunaid321, iammehedi1.
    Fixes #59143.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56446 602fd350-edb4-49c9-b593-d223f7449a82
    swissspidy committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    2cdaf29 View commit details
    Browse the repository at this point in the history
  5. Bundled Theme: Twenty Nineteen: Improve social media icon dimension a…

    …ttributes.
    
    Set the default width and height attributes of the SVG social icons to match the dimensions used within the CSS. This increases the attributes to 32px x 32 px.
    
    Props crunnells, mukesh27, laurelfulford, tahmidulkarim, jordanpak.
    Fixes #45950.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56447 602fd350-edb4-49c9-b593-d223f7449a82
    peterwilsoncc committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    40df0ec View commit details
    Browse the repository at this point in the history
  6. Rewrite Rules: Prevent stampedes when flush_rewrite_rules() is called

    This ensures that the `rewrite_rules` option is not emptied until the new value has been recalculated and the option is updated. The logic for refreshing the option value is moved to a new private method named `WP_Rewrite::refresh_rewrite_rules` which is used by both the `flush_rules` and `refresh_rewrite_rules` methods.
    
    Props iCaleb, joemcgill, flixos90, mukesh27.
    Fixes #58998.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56448 602fd350-edb4-49c9-b593-d223f7449a82
    joemcgill committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c10caf9 View commit details
    Browse the repository at this point in the history
  7. Menus: Fix proximity of controls to Save and Delete menus.

    Move the position of the Save and Delete buttons in menu editing so they are immediate neighbors, improving the proximity of related controls. 
    
    Props 90lines, sabernhardt, costdev.
    See #56594.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56449 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b21d72b View commit details
    Browse the repository at this point in the history
  8. Menus: Revert unintentional changes in [56449].

    Accidentally committed two simultaneous patches; reverting unintended list table changes.
    
    Unprops joedolson.
    See #56594.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56450 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1db3113 View commit details
    Browse the repository at this point in the history
  9. Bundled Themes: Ensure that pull quotes are able to use the correct font

    size.
    
    Pull quote bodies weren't inheriting the correct styling from the block 
    editor. This ensure that will happen. 
    
    Props nidhidhandhukiya, poena, varjodesigns, jivygraphics, whyisjake.
    Fixes #57854.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56451 602fd350-edb4-49c9-b593-d223f7449a82
    whyisjake committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    179ac0c View commit details
    Browse the repository at this point in the history
  10. Media: Add a filter to the get_available_post_mime_types() function…

    … to allow overriding its database query.
    
    This introduces the `get_available_post_mime_types` filter so this query can be skipped or cached by plugins.
    
    Props maciejmackowiak, archon810, rcorrales
    
    Fixes #52759
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56452 602fd350-edb4-49c9-b593-d223f7449a82
    johnbillion committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f435b0d View commit details
    Browse the repository at this point in the history
  11. Build/Test: Revert unintentional .env change in [56449].

    Also committed a change to .env. Sigh.
    
    Unprops joedolson.
    See #56594.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56453 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0d04972 View commit details
    Browse the repository at this point in the history
  12. Login and Registration: Improve test coverage for sign on related fun…

    …ctions
    
    Adds new tests to ensure that `wp_authenticate_email_password`, `wp_authenticate_username_password`, and `wp_authenticate_cookie` are better tested. This also unsets cookies properly between tests.
    
    Props JordanPak, johnregan3.
    Fixes #36476.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56454 602fd350-edb4-49c9-b593-d223f7449a82
    aaronjorbin committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1fc1e9c View commit details
    Browse the repository at this point in the history
  13. Performance: Add fallback for $script_uri to prevent firing `plugin…

    …s_url()` unnecessarily.
    
    Previously, in `register_block_script_handle()` the `$script_uri` variable initialized with a `plugins_url()` call that was reported to invoke four times. In this patch the var is initialized as a blank string with a fallback to use the `plugins_url()` if the other intended conditions are not met.
    
    Props mukesh27, daxelrod, adamsilverstein, davidbaumwald.
    Fixes #59181.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56455 602fd350-edb4-49c9-b593-d223f7449a82
    antpb committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    0c82e15 View commit details
    Browse the repository at this point in the history
  14. Administration: Escape post type output as field attribute.

    Props viralsampat.
    Fixes #59190.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56456 602fd350-edb4-49c9-b593-d223f7449a82
    peterwilsoncc committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b1f5563 View commit details
    Browse the repository at this point in the history
  15. Editor: Optimize wp_get_block_css_selector to remove array_merge

    …calls for better performance.
    
    Some block themes like TT3 use `wp_get_block_css_selector` to determine a CSS selector based on block type and other parameters.  However, recent performance profiling indicated a bottleneck in `wp_get_block_css_selector`, particularly sections that utilize `array_merge`.  By slightly refactoring these sections, `array_merge` calls can be avoided which increases performance.
    
    Props mukesh27, joemcgill, daxelrod, tabrisrp.
    Fixes #59178.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56457 602fd350-edb4-49c9-b593-d223f7449a82
    dream-encode committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    095617e View commit details
    Browse the repository at this point in the history
  16. General: Use regular core button styles for page header actions.

    Props emailjoey, melchoyce, afercia, michaelarestad, danieltj, helen.
    Fixes #41986.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56458 602fd350-edb4-49c9-b593-d223f7449a82
    TimothyBJacobs committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1f66a06 View commit details
    Browse the repository at this point in the history
  17. REST API: Remove misleading comment in WP_REST_Blocks_Controller->get…

    …_item_schema.
    
    In r56093 schema caching was added above a comment instructing developers not to cache that controller's schema. However, there is no obvious penalty for re-caching schema that is partially derived from a parent.
    
    Caching schema in the same way in every controller is beneficial consistency, and discussion at WCUS2023 contributor day concluded we could remove this comment.
    
    Props ahardyjpl, davidbinda, johnjamesjacoby, TimothyBlynJacobs.
    
    Fixes #59193. See #58657.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56459 602fd350-edb4-49c9-b593-d223f7449a82
    kadamwhite committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    e82474c View commit details
    Browse the repository at this point in the history
  18. Help/About: Match icon and text in Help for bulk edit button.

    Change the 'x' in the Help message that instructs a user how to remove an item from a group of bulk edit items to use the dashicon and text equivalent that matches the visual and accessible control name.
    
    Props Presskopp, costdev, sabernhardt, matthewfarlymn, bvreeman22.
    Fixes #58785.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56460 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    dfda67a View commit details
    Browse the repository at this point in the history
  19. Build Tools: Avoid doing copy:dynamic when running grunt watch wh…

    …en using `--dev` option.
    
    This prevents erroneously copying a file from source onto itself in source.
    
    Props westonruter, jorbin.
    Fixes #59196.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56461 602fd350-edb4-49c9-b593-d223f7449a82
    westonruter committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f085426 View commit details
    Browse the repository at this point in the history
  20. Customizer: use the correct X-Robots-Tag header.

    Fix an issue where the `X-Robots` header was used instead of the `X-Robots-Tag` header.  Using `X-Robots-Tag` yields the correct behavior that the original code intended to add. `X-Robots` is left in place for backward compatibility.
    
    Props michelleblanchette, dhruvishah2203, rajinsharwar, jorbin, hztyfoon, elrae. 
    
    Fixes #58865.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56462 602fd350-edb4-49c9-b593-d223f7449a82
    adamsilverstein committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a84270a View commit details
    Browse the repository at this point in the history
  21. Block Editor: Update SVN props to ignore new asset files.

    Update svn props to ignore additional CSS files added to WordPress 6.3.
    
    Fixes #59197.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56463 602fd350-edb4-49c9-b593-d223f7449a82
    peterwilsoncc committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    218fbd9 View commit details
    Browse the repository at this point in the history
  22. Build/Test Tools: Ensure database containers are prepared for commands.

    By default, Docker waits for a container to be started before considering it “ready”. But this does not necessarily mean that it’s ready to receive commands.
    
    This adds a check that ensures the database container is ready to receive commands before proceeding with running commands.
    
    Follow up to [56439], [56440], [56443].
    
    Props rmccue, desrosj.
    See #30462, #58867.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56464 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a8a0bf0 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Coding Standards: Use strict comparison in `wp-includes/class-wp-widg…

    …et.php`.
    
    Follow-up to [10764], [10912], [11427].
    
    Props aristath, poena, afercia, SergeyBiryukov.
    See #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56466 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    a5e6100 View commit details
    Browse the repository at this point in the history
  2. Introduce a _deprecated_class() function.

    Similar to other function in the `_deprecated_*` series, `_deprecated_class()` comes with two new hooks: `deprecated_class_run` and `deprecated_class_trigger_error`.
    
    Support has also been added for setting class deprecation expectations in tests.
    
    Props jrf, wvega, ohryan.
    See #41125.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56467 602fd350-edb4-49c9-b593-d223f7449a82
    DrewAPicture committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    4ef1036 View commit details
    Browse the repository at this point in the history
  3. Fix coding standards for translatable _deprecated_class() message s…

    …trings
    
    See #41125
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56468 602fd350-edb4-49c9-b593-d223f7449a82
    DrewAPicture committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    515634f View commit details
    Browse the repository at this point in the history
  4. Properly deprecate both constructors in WP_User_Search.

    - `__construct()` gets the new `_deprecated_class()` function
    - `WP_User_Search` PHP4 style constructor is changed from `_deprecated_function()` to `_deprecated_constructor()`
    
    Adds a test to confirm `WP_User_Search` class is testable as deprecated.
    
    Props jrf, DrewAPicture.
    Fixes #41125.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56469 602fd350-edb4-49c9-b593-d223f7449a82
    DrewAPicture committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8fd9604 View commit details
    Browse the repository at this point in the history
  5. Fix coding standards for Tests_Admin_wpUserSearch

    See #41125.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56470 602fd350-edb4-49c9-b593-d223f7449a82
    DrewAPicture committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    2f76410 View commit details
    Browse the repository at this point in the history
  6. Docs: Docblock improvements in _deprecated_class() function, as per…

    … docblocks standards.
    
    Follow-up to [56467].
    
    See #58833.
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56471 602fd350-edb4-49c9-b593-d223f7449a82
    audrasjb committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    73f7ecc View commit details
    Browse the repository at this point in the history
  7. Docs: Improve PHPCS comments general consistency.

    Props nekojonez.
    See #58833.
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56472 602fd350-edb4-49c9-b593-d223f7449a82
    audrasjb committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e0e36e6 View commit details
    Browse the repository at this point in the history
  8. Upgrade/Install: Add missing escaping function for `get_option( 'home…

    …' )` in `upgrade.php`.
    
    Props dilipbheda.
    Fixes #59199.
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56473 602fd350-edb4-49c9-b593-d223f7449a82
    audrasjb committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7f38f68 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Docs: Fix typo in a translator comment in _deprecated_class().

    Includes a few other formatting adjustments for consistency.
    
    Follow-up to [48327], [56467], [56471].
    
    See #58833.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56474 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    7ed2467 View commit details
    Browse the repository at this point in the history
  2. Database: Remove support for the mysql extension.

    The `mysql` extension is no longer used in PHP 7 or above. There's a good amount of conditional code in `wpdb` and the health checks that can be removed now that only the `mysqli` functions are used.
    
    Fixes #59118
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56475 602fd350-edb4-49c9-b593-d223f7449a82
    johnbillion committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    f711404 View commit details
    Browse the repository at this point in the history
  3. Database: Improve the documentation for various methods in the wpdb

    … class.
    
    See #58833
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56476 602fd350-edb4-49c9-b593-d223f7449a82
    johnbillion committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    49f61a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. Users: Remove unused wpdb global in check_password_reset_key().

    Follow-up to [45716].
    
    Props upadalavipul.
    See #59185.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56477 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    29c2f01 View commit details
    Browse the repository at this point in the history
  2. Users: Call add_user_meta() instead of update_user_meta() when ad…

    …ding metadata to a new user.
    
    This improves the performance of inserting users as it removes one unnecessary `SELECT` query for every row of metadata inserted.
    
    Props swissspidy, spacedmonkey, johnbillion
    
    Fixes #59212
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56478 602fd350-edb4-49c9-b593-d223f7449a82
    johnbillion committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    28cb706 View commit details
    Browse the repository at this point in the history
  3. Editor: Replace some accidental double setting up of tests with prope…

    …r tearing down.
    
    See #55505, #58955
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56479 602fd350-edb4-49c9-b593-d223f7449a82
    johnbillion committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    13becfa View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. XML-RPC: Remove unused wpdb global in `wp_xmlrpc_server::mw_newMedi…

    …aObject()`.
    
    Follow-up to [2676], [4961], [5008], [24716], [34578].
    
    Props upadalavipul.
    See #59185.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56480 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7cf0516 View commit details
    Browse the repository at this point in the history
  2. External Libraries: Update jQuery to version 3.7.1.

    This release fixes a regression from jQuery 3.6.0 that resulted in rounded dimensions for `<tr />` elements in Chrome and Safari. Also, a (mostly) internal Sizzle method, `jQuery.find.tokenize` that was on the jQuery object was accidentally removed when they removed Sizzle in jQuery 3.7.0. That method has been restored.
    
    References:
    - https://blog.jquery.com/2023/08/28/jquery-3-7-1-released-reliable-table-row-dimensions/
    - jquery/jquery@3.7.0...3.7.1
    
    Follow-up to [49101], [50445], [50520], [54202], [55012], [55491], [55860].
    
    Props TobiasBg, jorbin.
    Fixes #59227.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56481 602fd350-edb4-49c9-b593-d223f7449a82
    aaronjorbin committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    03290de View commit details
    Browse the repository at this point in the history
  3. Privacy: Improve docblocks for hooks and functions related to persona…

    …l data export and erasure.
    
    See #58833
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56482 602fd350-edb4-49c9-b593-d223f7449a82
    johnbillion committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7c254c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. External Libraries: Upgrade PHPMailer to version 6.8.1.

    This is a minor maintenance release.
    
    Note: WordPress core does not include PHPMailer's DSN class, as it is not particularly relevant for WP.
    
    References:
    * [https://github.com/PHPMailer/PHPMailer/releases/tag/v6.8.1 PHPMailer 6.8.1 release notes]
    * [PHPMailer/PHPMailer@v6.8.0...v6.8.1 Full list of changes in PHPMailer 6.8.1]
    
    Follow-up to [50628], [50799], [51169], [51634], [51635], [52252], [52749], [52811], [53500], [53535], [53917], [54427], [54937], [55557].
    
    Props jrf, Synchro.
    Fixes #59238.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56484 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    61cd1a5 View commit details
    Browse the repository at this point in the history
  2. Media: Prevent warning if [caption] shortcode is used without attri…

    …butes.
    
    Props maltfield, aslamdoctor.
    Fixes #59206.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56488 602fd350-edb4-49c9-b593-d223f7449a82
    swissspidy committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    ec94944 View commit details
    Browse the repository at this point in the history
  3. Site Health: fix check name used for REST API permission checks.

    Updates the calls to permission validation calls for the `directory-sizes` and `page-cache` routes to actually match the route names.
    
    Follow-up to r54043 and r49154.
    
    Props szepeviktor.
    Fixes #59236
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56489 602fd350-edb4-49c9-b593-d223f7449a82
    swissspidy committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    ab5fd4d View commit details
    Browse the repository at this point in the history
  4. Posts, Post Types: Reinstate missing sort_column options in get_pages().

    This fixes an issue introduced in [55569] that broke sort ordering by `post_modified_gmt` or `modified_gmt`.
    
    Props david.binda, azaozz, spacedmonkey, flixos90, joemcgill.
    Fixes #59226.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56490 602fd350-edb4-49c9-b593-d223f7449a82
    joemcgill committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    3d2f4d5 View commit details
    Browse the repository at this point in the history
  5. Posts, Post Types: Avoid redundant SQL query in get_pages().

    This avoids an additional query by passing the query args directly to the `WP_Query::query()` method, rather than to the constructor and calling get_posts(), following [55569].
    
    Props david.binda, azaozz, spacedmonkey, mukesh27, flixos90, SergeyBiryukov, joemcgill.
    Fixes #59224.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56491 602fd350-edb4-49c9-b593-d223f7449a82
    joemcgill committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e278fe3 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Tests: Correct uses of ReflectionProperty::setValue() for static pr…

    …operties.
    
    The single parameter signature, which was used for setting the value on a static property, is deprecated since PHP 8.3. A cross-version solution is to pass `null` as the first parameter.
    
    This commit updates all the instances that use the deprecated signature in WordPress core.
    
    Reference: [https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#reflectionpropertysetvalue PHP RFC: Deprecate functions with overloaded signatures: ReflectionProperty::setValue()].
    
    Follow-up to [53152], [54493], [54799].
    
    Props jrf, costdev, Tests: Correct uses of `ReflectionProperty::setValue()` for static properties.
    
    The single parameter signature, which was used for setting the value on a static property, is deprecated since PHP 8.3. A cross-version solution is to pass `null` as the first parameter.
    
    This commit updates all the instances that use the deprecated signature in WordPress core.
    
    Reference: [https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#reflectionpropertysetvalue PHP RFC: Deprecate functions with overloaded signatures: ReflectionProperty::setValue()].
    
    Follow-up to [53152], [54493], [54799].
    
    Props jrf, costdev, sc0ttkclark.
    See #59231.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56492 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    c6088bb View commit details
    Browse the repository at this point in the history
  2. HTML API: Stop processing HTML when encountering unsupported markup.

    It was a design goal of the HTML Processor to abort processing its input document when encountering unsupported markup. Unfortunately there was no test for this and so-far, the HTML Processor has paused, but continued processing in these situations.
    
    In this patch a new test ensures that the HTML Processor stops and refuses to move forward after encountering any unsupported markup. It also ensures that it doesn't report any current tag names since unsupported markup could imply that the read tag name is different than the parsed tag name.
    
    Props dmsnell.
    Fixes #59167.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56493 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    973b456 View commit details
    Browse the repository at this point in the history
  3. General: Replace two esc_url_raw() calls in core with `sanitize_url…

    …()`.
    
    This aims to improve performance by calling `sanitize_url()` directly, instead of the `esc_url_raw()` wrapper. As of WordPress 6.1, `sanitize_url()` is the recommended function for sanitizing a URL for database or redirect usage.
    
    This replaces the two remaining instances of `esc_url_raw()` with `sanitize_url()` in WordPress core.
    
    Follow-up to [53455], [53933], [54522].
    
    Props rajinsharwar, SergeyBiryukov.
    Fixes #59247.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56494 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    bc92bb0 View commit details
    Browse the repository at this point in the history
  4. HTTP API: Update WP_Http class to avoid PHP deprecation warnings.

    This changeset prevents a PHP 8.3 deprecation shown when enabling debug and calling `get_class()` without arguments.
    
    For more info about this deprecation, see https://wiki.php.net/rfc/deprecate_functions_with_overloaded_signatures#get_class_and_get_parent_class.
    
    Props ipajen, rajinsharwar, SergeyBiryukov, jrf.
    Fixes #58876.
    
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56495 602fd350-edb4-49c9-b593-d223f7449a82
    audrasjb committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    98284ae View commit details
    Browse the repository at this point in the history
  5. Editor: Add relative time strings for the wp-date inline script out…

    …put.
    
    This changeset updates `wp_default_packages_inline_scripts()` to add relative time strings to the `wp-date` inline script, so the JS version of `human_time_diff` 
    can output translated strings.
    
    Props ramonopoly, oandregal, swissspidy, manzoorwanijk, adrianduffell, Presskopp.
    Fixes #59219, #47373.
    
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56496 602fd350-edb4-49c9-b593-d223f7449a82
    audrasjb committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    39db9a6 View commit details
    Browse the repository at this point in the history
  6. Upload: Add a MIME type exception for .docx generated by Google Docs.

    This changeset adds an exception to prevent permission issues on `.docx` generated by Google Docs. This is a temporary fix for an upstream bug on the `finfo_file()` 
    PHP function which returns a redundant MIME type for these documents.
    
    Props winterstreet, jakariaistauk, mujuonly, mi5t4n, annashopina, audrasjb, azaozz, mikeschroder, oglekler.
    Fixes #57898.
    
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56497 602fd350-edb4-49c9-b593-d223f7449a82
    audrasjb committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a023fbc View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Build/Test Tools: Enable running the tests on PHP 8.3.

    PHP 8.3 is expected to be released at the end of November 2023.
    
    Enabling the tests to run in CI on PHP 8.3 allows WordPress core to start getting ready.
    
    Note: Xdebug-related tests will not be run on PHP 8.3 at this time as the Docker image for PHP 8.3 does not contain Xdebug yet. Once a stable release of Xdebug 3.3.0 is available, it can be added to the Docker image and the test step can then be enabled for PHP 8.3.
    
    Follow-up to [53922], [56492], [56495].
    
    Props jrf, costdev.
    See #59231.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56498 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    9879434 View commit details
    Browse the repository at this point in the history
  2. Coding Standards: Remove unused global variables in various `/wp-admi…

    …n/includes/` files.
    
    Props upadalavipul.
    Fixes #59254.
    
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56499 602fd350-edb4-49c9-b593-d223f7449a82
    audrasjb committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    54a1779 View commit details
    Browse the repository at this point in the history
  3. Introduce font-face styles generator and printer.

    Introducing Font Face, a server-side `@font-face` styles generator and printer. 
    
    tl;dr:
    * Introduces Font Face.
    * Deprecates `_wp_theme_json_webfonts_handler()`.
    
    **Introduce Font Face**
    
    From an array of fonts (i.e. each font-family and its font variations to be processed), it:
    
    1. Validates each `font-face` declaration, i.e. the CSS property and value pairing. If validation fails, processing stops with no font-face styles printed.
    3. Generates the `@font-face` CSS for each font-family.
    4. Prints the CSS within a `<style id="wp-fonts-local">` element.
    
    The entry point into Font Face is through a new global function called `wp_print_font_faces()`, which is automatically called:
    
    * when the `'wp_head'` hook runs (for the front-end).
    * when the `'admin_print_styles'` hook runs (for the back-end).
    * when `_wp_get_iframed_editor_assets()` runs to inject the `@font-face` styles into the iframed editor.
    
    Once called, it gets the fonts from Theme_JSON merged data layer, which includes theme defined fonts and user activated fonts (once the Font Library #59166 is introduced into Core).
    
    For classic sites, themes and plugins can directly call `wp_print_font_faces()` and pass their fonts array to it for processing.
    
    **Deprecates `_wp_theme_json_webfonts_handler()`.**
    
    As Font Face is a direct replacement, the stopgap code in `_wp_theme_json_webfonts_handler()` (introduced in 6.0.0 via [53282]) is deprecated and unused in Core.
    
    **Props note:**
    There's a long multiple year history baked into Font Face, which dates back to the early versions of a web font API (see #46370 and [WordPress/gutenberg#41479 roadmap]. The props list includes those who contributed from those early versions up to this commit.
    
    **References:**
    * #46370 original (Web)Fonts API proposal for registering and enqueuing web fonts.
    * [WordPress/gutenberg#41479 Gutenberg tracking issue] which includes the evolution from Webfonts API to Fonts API to Font Face.
    * [53282] / #55567 Added the stopgap code `_wp_theme_json_webfonts_handler()` in 6.0.
    * [https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face @font-face on mdn web docs]
    * #59166 Font Library: Font manager for WordPress
    
    Follow-up to [53282].
    
    Props aristath, jonoaldersonwp, hellofromTonya, andraganescu, annezazu, antonvlasenko, arena, askdesign, azaozz, bph, bradley2083, colorful-tones, costdev, davidbaumwald, desrosj, dingo_d, djcowan, domainsupport, dryanpress, elmastudio, flixos90, francina, garrett-eclipse, gigitux, grantmkin, grapplerulrich, gziolo, ironprogrammer, jb510, jeffpaul, jeremyyip, jffng, joostdevalk, jorgefilipecosta, juanmaguitar, mamaduka, matveb, mburridge, mitogh, ndiego, ntsekouras, oandregal, ocean90, oglekler, paaljoachim, pagelab, peterwilsoncc, poena, priethor, scruffian, SergeyBiryukov, shiloey, simison, skorasaurus, soean, westonruter, wildworks, zaguiini.
    Fixes #59165.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56500 602fd350-edb4-49c9-b593-d223f7449a82
    hellofromtonya committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    c29b095 View commit details
    Browse the repository at this point in the history
  4. Tests: Remove webfonts tests.

    Removes the test file and `webfonts` directory for the stopgap code that was deprecated by [56500].
    
    Follow-up to [56500], [53282].
    
    Fixes #59165.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56501 602fd350-edb4-49c9-b593-d223f7449a82
    hellofromtonya committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    13531cc View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Editor: Preserve block style variations when securing theme.

    Adds the ability to process block style variations to the `remove_insecure_properties` function of theme json class.
    
    Props dsas, ramonopoly.
    Fixes #59108.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56502 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    3c98d25 View commit details
    Browse the repository at this point in the history
  2. Editor: Don't use fluid layout value in typography.

    Changes fluid typography calculation to use fallback value if layout wide size is a fluid value.
    
    Props ramonopoly, mukesh27, jastos, aurooba.
    See #58754.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56503 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    0b40c80 View commit details
    Browse the repository at this point in the history
  3. Media: Remove unused $is_IE and $is_opera globals in `media_uploa…

    …d_form()`.
    
    Follow-up to [27316].
    
    Props upadalavipul.
    See #59254.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56504 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    9f3b57d View commit details
    Browse the repository at this point in the history
  4. Upgrade/Install: Remove unused globals in core_upgrade_preamble().

    Follow-up to [49638].
    
    Props upadalavipul.
    See #59254.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56505 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    36fe58a View commit details
    Browse the repository at this point in the history
  5. Build/Test Tools: Compare results in performance measurement workflow.

    This extends the performance test workflow added in [55459] to also run tests against the target branch (if running on a pull request) or the previous commit (if running on trunk).
    
    Those results are then compared with the ones from the current commit, and the difference is displayed as a GitHub Actions workflow summary for convenience.
    
    Props mukesh27, flixos90, desrosj, joemcgill, swissspidy.
    Fixes #58358, #58359.
    See #56150.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56506 602fd350-edb4-49c9-b593-d223f7449a82
    swissspidy committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b447190 View commit details
    Browse the repository at this point in the history
  6. Editor: Ensure main query loop is entered for singular content in blo…

    …ck themes.
    
    Block themes currently lack the means to trigger the main query loop for singular content, since they cannot reasonably use the `core/query` and `core/post-template` blocks which are intended only for displaying a list of posts. So far, the missing main query loop on singular block templates has been worked around by enforcing the loop in certain `core/post-*` blocks, which however causes other bugs.
    
    This changeset ensures that the main query loop is still started for singular block theme templates, by wrapping the entire template into the loop, which will by definition only have a single cycle as it only encompasses a single post. This is currently the most reliable solution, since even if there were blocks to properly trigger the main query loop on singular content, it would be unrealistic to expect all existing block themes to update their templates accordingly. It may be revisited in the future.
    
    Props gziolo, youknowriad, joemcgill, costdev, mukesh27, flixos90.
    Fixes #58154.
    See #59225, #58027.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56507 602fd350-edb4-49c9-b593-d223f7449a82
    felixarntz committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5269bf6 View commit details
    Browse the repository at this point in the history
  7. Options, Meta APIs: Introduce wp_set_option_autoload_values().

    This function accepts an associative array of option names and their autoload values to set, and it will update those values in the database in bulk, only for those options where the autoload field is not already set to the given value.
    
    Two wrapper functions for ease of use accompany the new main function:
    * `wp_set_options_autoload( $options, $autoload )` can be used to set multiple options to the same autoload value.
    * `wp_set_option_autoload( $option, $autoload )` can be used to set the autoload value for a single option.
    
    All of these functions allow changing the autoload value of an option, which previously has only been possible in combination with updating the value. This limitation prevented some relevant use-cases: For example, a plugin deactivation hook could set all of its options to not autoload, as a cleanup routine, while not actually deleting any data. The plugin's activation hook could then implement the reverse, resetting those options' autoload values to the originally intended ones for when using the plugin.
    
    Props boonebgorges, joemcgill, costdev, mukesh27, SergeyBiryukov, tabrisrp, flixos90.
    Fixes #58964.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56508 602fd350-edb4-49c9-b593-d223f7449a82
    felixarntz committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    a22fee0 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2023

  1. Site Health: Show correct debug value for file uploads.

    Follow-up to [48535].
    
    Props Michi91, Presskopp.
    Fixes #58737.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56509 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    9a87bc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Upload: Correct duplicate MIME type for .xlsx files generated by Go…

    …ogle Docs.
    
    This expands the code block previously added for `.docx` files to include `.xlsx` files as well, which are known to have the same issue with `finfo_file()`.
    
    Includes a unit test case for `wp_check_filetype_and_ext()`.
    
    Reference: [https://bugs.php.net/bug.php?id=77784 PHP Bug #77784: mime_content_type() result gets doubled for .xlsx].
    
    Follow-up to [56497].
    
    See #57898.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56510 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    d0deb5b View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Coding Standards: Use strict comparison in `wp-includes/class-wp-hook…

    ….php`.
    
    Follow-up to [4955], [38571].
    
    Props aristath, poena, afercia, SergeyBiryukov.
    See #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56511 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    fa9f839 View commit details
    Browse the repository at this point in the history
  2. Widgets: Improve performance of has_content method in WP_Widget_Media…

    …_Gallery class.
    
    In the method `WP_Widget_Media_Gallery::has_content` call `_prime_post_caches` before the foreach loop. This ensures that the post objects are primed in memory before trying to access the post object in `get_post_type`.
    
    Props niravsherasiya7707, spacedmonkey, mukesh27.
    Fixes #58757.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56512 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    6be588c View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Query: Use split queries in WP_Query if persistent object caching is …

    …enabled.
    
    Prior to this commit, the `WP_Query` class split the query for posts into two database queries. First, it initiated an ID-based query to retrieve post IDs, followed by a call to _prime_post_caches to fetch post objects if they weren't already in memory. This splitting of queries was limited to cases where fewer than 500 posts were being requested, to prevent a potentially large database query within the IN statement in _prime_post_caches.
    
    However, this limitation becomes unnecessary when a persistent object cache is enabled, as the post objects can be efficiently retrieved from the fast object cache. This commit transfers the responsibility of fetching posts to the object cache, which not only speeds up the process but also reduces the strain on the database server.
    
    Props peterwilsoncc, spacedmonkey, SergeyBiryukov.
    Fixes #57296.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56513 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    92994bd View commit details
    Browse the repository at this point in the history
  2. Code Modernization: Rename parameters that use reserved keywords in `…

    …wp-includes/functions.php`.
    
    While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.
    
    This commit renames the `$class` parameter to `$class_name` in `_deprecated_class()`.
    
    Follow-up to [54929], [56467].
    
    Props jrf.
    See #59161.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56514 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5f1a92c View commit details
    Browse the repository at this point in the history
  3. Administration: Add improved context for add new links.

    Consistently expand `Add New` links to include the type of content to add. Improve consistency of text casing to use initial caps throughout.
    
    Props afercia, gonzomir, alexstine, swissspidy, joedolson.
    Fixes #47125.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56515 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    305de43 View commit details
    Browse the repository at this point in the history
  4. Administration: Use admin notice functions in nav menu admin.

    Use `wp_get_admin_notice` and `wp_admin_notice` to handle settings notices on the nav menu admin screens.
    
    Props joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56518 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3384a80 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Docs: Add a @since note for add_new labels change in `get_post_ty…

    …pe_labels()`.
    
    Includes removing an obsolete recommendation to use a gettext context matching the post type for disambiguation, which would be redundant with the new labels, as they already include the type of content.
    
    Follow-up [14571], [56515].
    
    See #47125.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56519 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    6aa3721 View commit details
    Browse the repository at this point in the history
  2. Editor: update packages with bug fixes for 6.3.2

    Updates editor npm packages to latest patch versions for the 6.3.x branch.
    
    Props ramonopoly.
    See #59293.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56520 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    77a7772 View commit details
    Browse the repository at this point in the history
  3. Coding Standards: Correct equals sign alignment in various files.

    This resolves a few WPCS warnings:
    {{{
    Equals sign not aligned with surrounding statements
    }}}
    so that the output of `composer format` is clean.
    
    Follow-up to [56276], [56302].
    
    Props jrf.
    See #59161, #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56521 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a8b3461 View commit details
    Browse the repository at this point in the history
  4. Database: Add expiration for dirsize_cache to transient to improve …

    …performance.
    
    The transient `dirsize_cache` stores an array of directory sizes. This transient can grow very large, if the plugin directory has lots of sub directories in it. For example, a site with 30 plugins, the transient was around 2MB. For sites without a persistent object cache, transients without an expiration, are stored in autoloaded options. This means this option would load on every page request. Loading this option on every page request when it is not used it wasteful. Adding a expiration to this transient means it will not autoload. To ensure there is no degradation in performance, the expiration was set to a generous 10-year timeframe, making it highly unlikely to expire before it's refreshed.
    
    Props nicomollet, spacedmonkey, flixos90, wpgurudev.
    Fixes #54221.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56522 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e619082 View commit details
    Browse the repository at this point in the history
  5. Themes: Remove unnecessary check if file exists in the theme functions.

    Previously, several functions and methods in themes api were designed to check for the existence of files in a child theme before falling back to the parent theme. However, these checks did not consider whether the current theme was a child theme or not, resulting in unnecessary file existence checks for non-child themes. Check to see if stylesheet directory matches the template directory before doing the file exists. This optimization helps reduce unnecessary file system access, as file existence checks can be resource-intensive in PHP. 
    
    The following functions and methods have been updated as part of this enhancement: 
    - `WP_Theme::get_file_path`
    - `get_theme_file_path`
    - `get_theme_file_uri`
    
    Props spacedmonkey, flixos90, sabernhardt, 10upsimon, mukesh27.
    Fixes #59279.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56523 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    bd594f7 View commit details
    Browse the repository at this point in the history
  6. Themes: Avoid stale caches for core block styles.

    This fixes an issue introduced in [56044] in which the path to core block styles are cached to avoid expensive file operations on every page load. The original caching strategy is now modified so that only the path relative to the blocks location are stored, rather than the full path, since the path to the `wp-includes` folder can change after the value is generated. The new cached value also includes the current WordPress version value to ensure it is rebuilt when the version changes.
    
    Props lhe2012, coreyw, colorful tones, petitphp, mukesh27, spacedmonkey, joemcgill, flixos90, kimannwall, desmith.
    Fixes #59111.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56524 602fd350-edb4-49c9-b593-d223f7449a82
    joemcgill committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    8d65dc9 View commit details
    Browse the repository at this point in the history
  7. Upgrade/Install: Check plugin compatibility during bulk upgrades.

    Previously, bulk upgrades did not verify that a plugin package was compatible with the site's WordPress version or the server's PHP version. This could lead to incompatible updates being installed, causing various compatibility issues and errors.
    
    This change implements the following checks:
    - If available, the API response's `requires` and `requires_php` values are checked for compatibility. This saves time, diskspace, memory and file operations by failing the upgrade before the package is downloaded and unpacked.
    - If the API check passes, the downloaded and unpacked package is verified using `Plugin_Upgrader::check_package()` to ensure a plugin file is present, and the plugin's "RequiresWP" and "RequiresPHP" headers are compatible, if present. This ensures that a mismatch between the API response and the plugin file's headers does not cause an incompatible plugin to be installed.
    
    Props salcode, afragen, mukesh27, iammehedi1, zunaid321, johnbillion, SergeyBiryukov, costdev.
    Fixes #59198.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56525 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a138c19 View commit details
    Browse the repository at this point in the history
  8. Bundled Theme: Update default themes to use new script function signa…

    …ture.
    
    In WordPress 6.3, the last parameter of `wp_register_script()` and `wp_enqueue_script()` was changed to an array rather than a boolean. While a boolean is still supported for backward compatibility, it makes sense to update the codebase to use the new signature.
    
    The updates are fully backward compatible:
    * In places where `true` was provided, `array( 'in_footer' => true )` will still be interpreted as a boolean true in WordPress versions prior to 6.3.
    * In places where `false` was provided, the parameter is omitted which will work correctly throughout all WordPress versions given that is and has been the default value anyway.
    
    Props mrinal013, huzaifaalmesbah, niravsherasiya7707, joemcgill.
    Fixes #59302.
    See #58634.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56526 602fd350-edb4-49c9-b593-d223f7449a82
    felixarntz committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    d67d8d6 View commit details
    Browse the repository at this point in the history
  9. Editor: Fix loading of assets in blocks in child themes where the dir…

    …ectory name starts with the parent theme's directory name. Example: `twentyseventeen` and `twentyseventeen-child`.
    
    Props: lgladdy, masteradhoc, audrasjb, rajinsharwar, azaozz.
    Fixes: #59018.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56527 602fd350-edb4-49c9-b593-d223f7449a82
    azaozz committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    476db82 View commit details
    Browse the repository at this point in the history
  10. Editor: Prevent possibility of a fatal error when previewing block th…

    …emes.
    
    Ensures that preview callbacks attached to the `stylesheet` and `template` filters do not run before `pluggable.php` has been included. These callbacks need functionality from `pluggable.php`.
    
    Props: scruffian, johnbillion, SergeyBiryukov, okat, okat.
    Fixes: #59000.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56529 602fd350-edb4-49c9-b593-d223f7449a82
    azaozz committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e14213e View commit details
    Browse the repository at this point in the history
  11. General: Introduce wp_trigger_error().

    Introduces `wp_trigger_error()` as a wrapper around PHP's native `trigger_error()`. As a wrapper, it's lean and not opinionated about the message. It accepts an E_USER family error level, meaning it is not limited to only notices.
    
    Where `_doing_it_wrong()` intends to loudly alert developers "Hey you're doing it wrong - fix it", `wp_trigger_error()` is not opinionated and does not add wording. Rather, it passes the given message to `trigger_error()`.
    
    `wp_trigger_error()` is meant for every `trigger_error()` instance. It can be used:
    * in `_doing_it_wrong()` and each `_deprecated_*()` function.
    * for PHP 8.x deprecations.
    * for PHP error parity.
    * for less severe "doing it wrong" instance that do not require bailing out.
    * when a component or extension is not available on the server
    * for instances where it's not clear if a plugin's or theme's code is the root cause.
    * and more.
    
    Technical details:
    
    * Does not trigger the error if `WP_DEBUG` is not `true`.
    
    * Includes `wp_trigger_error_run` action to allow hooking in for backtracing and deeper debug.
    
    * Accepts an E_USER error level, but defaults to `E_USER_NOTICE`.
    
    * Requires a function name, though can be an empty string. As the output message generated by `trigger_error()` references the file and line number where it was invoked, passing the function's name provides more information where the error/warning/notice/deprecation happened. It's intended to help with debug.
    
    * A WordPress version number is not included.
    
    * As messages can appear in the browser, the message is escaped using `esc_html()`. As noted in [https://www.php.net/manual/en/function.trigger-error.php the PHP manual]: "HTML entities in message are not escaped. Use htmlentities() on the message if the error is to be displayed in a browser."
    
    References:
    * [https://www.php.net/manual/en/function.trigger-error.php PHP manual for `trigger_error()`].
    * [https://www.php.net/manual/en/errorfunc.constants.php E_USER constants (error level) in the PHP manual].
    
    Props azaozz, hellofromTonya, flixos90, costdev, peterwilsoncc, oglekler, mukesh27.
    See #57686.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56530 602fd350-edb4-49c9-b593-d223f7449a82
    hellofromtonya committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    6ea6972 View commit details
    Browse the repository at this point in the history
  12. Bundled Themes: Use Node.js 16.x in themes with a build process.

    This results in a new `package-lock.json` file being generated that uses `lockfileVersion` 2.x.
    
    There are no changes to built files as a result of this update.
    
    Follow up to [56378], [56387], [56442].
    
    Props mikestraw, whyisjake, jivygraphics.
    Fixes #59187. See #56658.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56531 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    f66fe0e View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Bundled Themes: Set legacy-peer-deps to true.

    While `npm install` was working without issue after [56531], `npm ci` was not. The latter expects dependencies in the `package-lock.json` to match those in `package.json` exactly.
    
    Follow up to [56378], [56387], [56442], [56531[.
    
    Fixes #59187. See #56658.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56532 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    d480448 View commit details
    Browse the repository at this point in the history
  2. Bundled Themes: Update npm dependencies for Twenty Nineteen and Twent…

    …y Twenty.
    
    This updates the npm dependencies for Twenty Nineteen and Twenty Twenty to their latest versions. This also includes the results of running `npm audit fix`.
    
    There are no changes in any built files as a result.
    
    See #58863.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56533 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    503addd View commit details
    Browse the repository at this point in the history
  3. Editor: allow disabling layout controls.

    Adds the ability to disable layout controls on a per-block level from theme.json.
    
    Props mukesh27.
    Fixes #59294.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56534 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    9f5dd61 View commit details
    Browse the repository at this point in the history
  4. Editor: add configurable viewport sizes for fluid typography.

    Adds options to configure min and max viewport sizes for fluid typography in theme.json settings.
    
    Props ramonopoly.
    Fixes #59048.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56535 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    3626241 View commit details
    Browse the repository at this point in the history
  5. Coding Standards: Remove superfluous blank lines at the end of variou…

    …s files.
    
    Note: This is enforced by WPCS 3.0.0.
    
    Props jrf.
    See #59161, #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56536 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    46f6492 View commit details
    Browse the repository at this point in the history
  6. Build/Test Tools: Update 3rd-party GitHub Actions.

    This updates all 3rd-party GitHub actions to their latest versions. The following actions were updated:
    - `actions/cache`
    - `actions/checkout`
    - `actions/setup-node`
    - `codecov/codecov-action`
    - `shivammathur/setup-php`
    - `slackapi/slack-github-action`
    
    In the latest version of `actions/checkout` (`4.0.0`), a new input was introduced to control the output of command progress. This change uses this new `show-progress` input to turn off displaying progress by default. Progress will be shown when a workflow is run with debug mode enabled, just in case it contains helpful information.
    
    Props johnbillion, desrosj.
    See #58867.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56537 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    3452000 View commit details
    Browse the repository at this point in the history
  7. Build/Test Tools: Update a few more 3rd-party GitHub Action occurrences.

    Follow up to [56537].
    
    See #58867.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56538 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    1cfefb9 View commit details
    Browse the repository at this point in the history
  8. Fonts: Removes static instance in wp_print_font_faces().

    The static instance of `WP_Font_Face` is not needed. It was an unnecessary carryover from the experimental Fonts API (which was not introduced into Core).
    
    Whereas the Fonts API needed to persist its data (i.e. to maintain the registered and enqueued fonts throughout the web request), Font Face does not have data to persist.
    
    Font Face processes the fonts it receives when `WP_Font_Face::generate_and_print( $fonts )` is invoked. Thus, a singleton is not needed.
    
    Removing the static reduces the amount of the code in the function and eliminates running its tests in separate processes to ensure a different instance is always used.
    
    References:
    * [WordPress/gutenberg#54228 Gutenberg PR 54228].
    
    Follow-up to [56500].
    
    Props hellofromTonya, costdev.
    Fixes #59165.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56540 602fd350-edb4-49c9-b593-d223f7449a82
    hellofromtonya committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    9b6d04a View commit details
    Browse the repository at this point in the history
  9. Plugins: Respect prefers-reduced-motion on plugin thumbnails.

    Pause animated plugin thumbnails when a user has reduced motion preferences configured in their device or operating system.
    
    Props Travel_girl, audrasjb, bordoni, stevejonesdev, joedolson.
    Fixes #55723.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56541 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    ef54f4e View commit details
    Browse the repository at this point in the history
  10. Code Modernization: Use wp_trigger_error() in WP_List_Table magic met…

    …hods.
    
    Replaces `trigger_error()` with `wp_trigger_error()` in each of the `WP_List_Table` magic methods.
    
    [56349] added the dynamic properties deprecation messages to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods. Since that commit, `wp_trigger_error()` was introduced (see [56530]) as a wrapper for `trigger_error()`.
    
    Follow-up to [56349], [56356], [56530].
    
    See #58896, #57686.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56542 602fd350-edb4-49c9-b593-d223f7449a82
    hellofromtonya committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    dc76011 View commit details
    Browse the repository at this point in the history
  11. Code Modernization: Use wp_trigger_error() in WP_User_Query magic met…

    …hods.
    
    Replaces `trigger_error()` with `wp_trigger_error()` in each of the `WP_User_Query` magic methods.
    
    [56353] added the dynamic properties deprecation messages to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods. Since that commit, `wp_trigger_error()` was introduced (see [56530]) as a wrapper for `trigger_error()`.
    
    Follow-up to [56353], [56530].
    
    See #58897, #57686.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56543 602fd350-edb4-49c9-b593-d223f7449a82
    hellofromtonya committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a5eddea View commit details
    Browse the repository at this point in the history
  12. Code Modernization: Use wp_trigger_error() in WP_Text_Diff_Renderer_T…

    …able magic methods.
    
    Replaces `trigger_error()` with `wp_trigger_error()` in each of the `WP_Text_Diff_Renderer_Table` magic methods.
    
    [56354] added the dynamic properties deprecation messages to the `__get()`, `__set()`, `__isset()`, `__unset()` magic methods. Since that commit, `wp_trigger_error()` was introduced (see [56530]) as a wrapper for `trigger_error()`.
    
    Follow-up to [56354], [56530].
    
    See #58898, #57686.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56544 602fd350-edb4-49c9-b593-d223f7449a82
    hellofromtonya committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    9de4142 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Editor: performance enhancements to class-wp-theme-json.

    Removes unnecessary sanitisation of hardcoded strings and avoids looping over style presets without classes or variables.
    
    Props flixos90.
    Fixes #59304.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56545 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    b693aeb View commit details
    Browse the repository at this point in the history
  2. Editor: tweak root padding styles.

    Removes root padding from children of flex and grid layout blocks when root padding aware alignments are set.
    
    Props andrewserong, ramonopoly.
    Fixes #59295.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56546 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    3f9bc4e View commit details
    Browse the repository at this point in the history
  3. Coding Standards: Remove superfluous blank lines at the end of variou…

    …s classes.
    
    Note: This is enforced by WPCS 3.0.0.
    
    Follow-up to [56536].
    
    Props jrf.
    See #59161, #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56547 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d790be1 View commit details
    Browse the repository at this point in the history
  4. Coding Standards: Remove superfluous blank lines at the end of variou…

    …s functions.
    
    Note: This is enforced by WPCS 3.0.0.
    
    Follow-up to [56536], [56547].
    
    Props jrf.
    See #59161, #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56548 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    1118e37 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Coding Standards: Use pre-increment/decrement for stand-alone stateme…

    …nts.
    
    Note: This is enforced by WPCS 3.0.0:
    
    1. There should be no space between an increment/decrement operator and the variable it applies to.
    2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.
    
    References:
    * [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators WordPress PHP Coding Standards: Increment/decrement operators]
    * [WordPress/WordPress-Coding-Standards#2130 WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators]
    
    Props jrf.
    See #59161, #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56549 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov authored and SergeyBiryukov committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    54e1b4b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Upgrade/Install: Fix broken sprintf() call when deleting a backup.

    In `WP_Upgrader::delete_temp_backup()`, a malformed `sprintf()` call did not pass the value, triggering a Warning in PHP 7 and a Fatal Error in PHP 8.
    
    This fixes the malformed `sprintf()` call by correctly passing the value.
    
    Follow-up to [55720].
    
    Props akihiroharai, afragen.
    Fixes #59320.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56550 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    2a13d93 View commit details
    Browse the repository at this point in the history
  2. Coding Standards: Correct spacing for spread operators.

    No space allowed between the operator and the variable it applies to.
    
    Note: This is enforced by WPCS 3.0.0.
    
    Follow-up to [46133].
    
    Props jrf.
    See #59161, #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56551 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    858bd4b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Code Modernization: Use dirname() with the $levels parameter.

    PHP 7.0 introduced the `$levels` parameter to the `dirname()` function, which means nested calls to `dirname()` are no longer needed.
    
    Note: This is enforced by WPCS 3.0.0.
    
    Reference: [https://www.php.net/manual/en/function.dirname.php PHP Manual: dirname()].
    
    Follow-up to [56141].
    
    Props jrf.
    See #59161, #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56552 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    aeba9d1 View commit details
    Browse the repository at this point in the history
  2. Cron: Cast doing_cron transient to a float.

    Cast the `doing_cron` transient value to a float to prevent type errors if the transient is not set (in which case it returns `false`) or another unexpected type.
    
    Props fzhantw, ankitmaru.
    Fixes #58471.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56553 602fd350-edb4-49c9-b593-d223f7449a82
    peterwilsoncc committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2453a6b View commit details
    Browse the repository at this point in the history
  3. External Libraries: Update the Requests library to version 2.0.8.

    This is a maintenance release with minor changes:
    - Only force close cURL connection when needed (cURL < 7.22).
    
    References:
    - [https://github.com/WordPress/Requests/releases/tag/v2.0.8 Requests 2.0.8 release notes]
    - [WordPress/Requests@v2.0.6...v2.0.8 Full list of changes in Requests 2.0.8]
    
    Follow-up to [54997], [55007], [55046], [55225], [55296], [55629].
    
    Props jrf, mukesh27, spacedmonkey, costdev.
    Fixes #59322.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56554 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    46c1f6f View commit details
    Browse the repository at this point in the history
  4. Taxonomy: Cache term objects in WP_Term_Query if query is filtered.

    When utilizing the `terms_clauses` or `get_terms_fields` filters within `WP_Term_Query` and the selected fields are modified, the entire term object is now cached. This adjustment is necessary because filters can broaden the selected fields beyond just the term ID. Fields linked to the term object, such as the count or parent, may undergo modifications when queried. Caching the complete object ensures the accurate storage of these modified fields within the cache.
    
    Props spacedmonkey, tnolte, peterwilsoncc.
    Fixes #58116.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56555 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    827a560 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Bundled Themes: Use defer loading strategy for theme scripts.

    * Add `defer` loading strategy for all frontend end-user theme scripts (excluding Customizer preview).
    * Move scripts to the `head` which relate to the initial page viewport to ensure they start loading earlier and execute sooner while still not blocking rendering.
    * Update Twenty Twenty's script loader (`TwentyTwenty_Script_Loader`) to support core's built-in script loading strategies (#12009), while also retaining backwards-compatibility for child themes that may set `async` and `defer` script data.
    * Update the main script loading strategy in Twenty Twenty from `async` to `defer` for better performance on repeat page views, since when an `async` script is cached it will block rendering.
    
    Props westonruter, flixos90, sabernhardt.
    Fixes #59316.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56556 602fd350-edb4-49c9-b593-d223f7449a82
    westonruter committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    cc775b9 View commit details
    Browse the repository at this point in the history
  2. General: Add optional callback argument to serialize_block(s).

    Allow passing a function callback to serialize_block(s) that is invoked on each node in the tree of parsed blocks as it is traversed for serialization.
    
    A function argument was chosen for passing the callback function as it reflects a pattern familiar from other algorithms that apply a given callback function while traversing a data structure -- most notably PHP's own `array_map()`.
    
    Introducing a filter was considered as an alternative but ultimately dismissed. For a fairly low-level and general-purpose function such as `serialize_block()`, using a filter to pass the callback seemed risky, as it also requires ''removing'' that filter after usage in order to prevent the callback from being accidentally applied when `serialize_block()` is called in an entirely different context.
    
    Introducing a separate function for applying a given operation during tree traversal (i.e. independently of serialization) was also considered but dismissed, as it would unnecessarily duplicate tree traversal.
    
    Props dlh, gziolo.
    Fixes #59327. See #59313.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56557 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    44e71c8 View commit details
    Browse the repository at this point in the history
  3. HTML API: Store current token reference in HTML Processor state.

    The `$current_token` reference has been stored in the HTML Processor itself, but I suggested to move it into the externalized state so that it can be stored and replaced.
    
    In this patch the reference is moved to that state variable and it should become more possible to save and load state, to resume execution after pausing.
    
    Props dmsnell.
    Fixes #59268.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56558 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9c9329c View commit details
    Browse the repository at this point in the history
  4. Coding Standards: Include one space after function keyword for clos…

    …ures.
    
    Note: This is enforced by WPCS 3.0.0.
    
    Reference: [WordPress/WordPress-Coding-Standards#2328 WPCS: PR #2328 Core: properly check formatting of function declaration statements].
    
    Props jrf.
    See #59161, #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56559 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    fd6c560 View commit details
    Browse the repository at this point in the history
  5. Posts, Post Types: Avoid unnecessarily parsing blocks twice in `wp_tr…

    …im_excerpt()`.
    
    All blocks relevant for the excerpt are already being parsed in `excerpt_remove_blocks()`. Therefore running `do_blocks()` on the post content only to create the excerpt is unnecessary and wasteful from a performance perspective.
    
    Props thekt12, spacedmonkey, mukesh27, joemcgill.
    Fixes #58682.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56560 602fd350-edb4-49c9-b593-d223f7449a82
    felixarntz committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    15f5a95 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Docs: Fix typo in a comment in wp_trim_excerpt().

    Includes removing redundant `@covers` tags. There is already an existing annotation for the whole test class, following the [https://docs.phpunit.de/en/9.6/annotations.html#covers PHPUnit recommendation]:
    > This annotation can be added to the docblock of the test class or the individual test methods. The recommended way is to add the annotation to the docblock of the test class, not to the docblock of the test methods.
    
    Follow-up to [56560].
    
    See #58682.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56561 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    36f8240 View commit details
    Browse the repository at this point in the history
  2. Themes: Add test for theme atttibute in file-based block template.

    While we already have unit test coverage for `_inject_theme_attribute_in_block_template_content`, those tests only verify that ''that'' function does what is supposed to do; there's however no guarantee that `_build_block_template_result_from_file` uses that function (or whatever other technique) to actually inject the theme attribute.
    
    This patch adds test coverage to verify that the theme attribute is correctly injected by `_build_block_template_result_from_file`.
    
    Props costdev, gziolo, mukesh27, spacedmonkey.
    Fixes #59325. See #59313.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56562 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    8e4ff2a View commit details
    Browse the repository at this point in the history
  3. HTML API: Skip over contents of RAWTEXT elements such as STYLE.

    When encountering elements that imply switching into the RAWTEXT parsing state,
    the Tag Processor should skip processing until exiting the RAWTEXT state.
    
    In this patch the Tag Processor does just that, except for the case of the
    deprecated XMP element which implies further and more complicated rules.
    
    There's an implicit assumption that the SCRIPT ENABLED flag in HTML parsing
    is enabled so that the contents of NOSCRIPT can be skipped. Otherwise, it would
    be required to parse the contents of that tag.
    
    Props dmsnell.
    Fixes #59292.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56563 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7dbf409 View commit details
    Browse the repository at this point in the history
  4. HTML API: Update documentation and rename internal variable on HTML P…

    …rocessor
    
    This patch updates documentation and an internal variable name within the
    HTML Processor class so that they are more helpful and complete to a reader.
    
    There should be no functional or visual changes in this patch.
    
    Props dmsnell, mukesh27.
    Fixes #59267.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56565 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    11e91d5 View commit details
    Browse the repository at this point in the history
  5. REST API: Avoid unnecessarily preparing item links REST API index.

    Building upon the changes introduced in [53760], this commit refines the behavior of the REST API index. Specifically, it addresses performance concerns related to the unnecessary preparation of item links, such as site icon and logo links.
    
    Prior to this update, the index controller was invoking the prepare_links method regardless of whether the _links or _embedded fields were requested in the response. This led to unnecessary database lookups and decreased overall performance.
    
    In this commit, we implement a more efficient approach. Now, the prepare_links method will only be called when the _links or _embedded fields are explicitly requested in the response. This optimization ensures that we prepare links only when they are intended for inclusion in the API response, reducing unnecessary overhead.
    
    By implementing this improvement, we enhance the overall efficiency and performance of the WordPress core REST API index controller.
    
    Props spacedmonkey, niravsherasiya7707, dlh, mukesh27, costdev, swissspidy.
    Fixes #57902.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56566 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    640a533 View commit details
    Browse the repository at this point in the history
  6. Twenty-Twenty One: Fixes quotation mark being outside with background.

    The quotation marks were outside when the background color was applied.
    
    Props nidhidhandhukiya, sabernhardt, shailu25, harshgajipara, poena, huzaifaalmesbah.
    Fixes #57377. 
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56567 602fd350-edb4-49c9-b593-d223f7449a82
    karmatosed committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6f74f61 View commit details
    Browse the repository at this point in the history
  7. General: Update wp_register_script() calls in core to use new funct…

    …ion signature.
    
    Since most core scripts are registered using `WP_Scripts::add()`, which is not affected by the signature change, only calls to `wp_register_script()` using the old signature need to be updated. There is only a single instance left, which is updated in this changeset.
    
    Props incursadesigns.
    Fixes #58634.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56568 602fd350-edb4-49c9-b593-d223f7449a82
    felixarntz committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    1c2653d View commit details
    Browse the repository at this point in the history
  8. Bundled Themes: Ensure Twenty Twenty's main script loads in head fo…

    …r WP<6.3.
    
    Amends [56556].
    Props westonruter, flixos90, peterwilsoncc.
    Fixes #59316.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56569 602fd350-edb4-49c9-b593-d223f7449a82
    westonruter committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    96a7954 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Administration: Use wp_admin_notice() in /wp-admin/.

    Add usages of `wp_admin_notice()` and `wp_get_admin_notice()` on `.notice-[type]` in the root level of `/wp-admin/`. Ongoing task to implement new function across core.
    
    Props costdev, joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56570 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    3cefc7c View commit details
    Browse the repository at this point in the history
  2. Administration: Use wp_admin_notice() in /wp-admin/includes.

    Add usages of `wp_admin_notice()` and `wp_get_admin_notice()` on `.notice-[type]` in the root level of `/wp-admin/includes`. Ongoing task to implement new function across core.
    
    Props costdev, joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56571 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    fa21528 View commit details
    Browse the repository at this point in the history
  3. Administration: Use wp_admin_notice() in /wp-includes/.

    Add usages of `wp_admin_notice()` and `wp_get_admin_notice()` on `.notice-[type]` in the root level of `/wp-includes/`. Ongoing task to implement new function across core.
    
    Props costdev, joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56572 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    795534f View commit details
    Browse the repository at this point in the history
  4. Administration: Use wp_admin_notice() for .updated.

    Add usages of `wp_admin_notice()` and `wp_get_admin_notice()` on `.updated` in the root level of `/wp-admin/`. Ongoing task to implement new function across core.
    
    Props costdev, joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56573 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    f43aaaf View commit details
    Browse the repository at this point in the history
  5. Editor: disable default style engine optimisation.

    Stops style engine from combining CSS selectors by default so that rule order is preserved.
    
    Props ramonopoly, rajinsharwar, timdix, costdev, audrasjb, SergeyBiryukov, JeffPaul, mukesh27.
    Fixes #58811.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56574 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1a168a1 View commit details
    Browse the repository at this point in the history
  6. REST API: quality tweaks to WP_REST_Global_Styles_Controller.

    Removes redundant local variable and changes validate_custom_css() access modifier from private to protected.
    
    Props ramonopoly, spacedmonkey.
    Fixes #59296.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56575 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ec47a8f View commit details
    Browse the repository at this point in the history
  7. Administration: Fix erroneous call to wp_admin().

    In [56573], a typo caused `wp_admin()` to be called rather than `wp_admin_notice()`.
    
    This fixes the typo to correctly call `wp_admin_notice()`.
    
    Follow-up to [56573].
    
    Props takayukister.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56576 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    4bdca50 View commit details
    Browse the repository at this point in the history
  8. Post Types: allow trashing draft patterns.

    Adds `delete_posts` to capabilities for the `wp_block` post type.
    
    Props ramonopoly, johnbillion, dhruvishah2203, audrasjb.
    Fixes #59041.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56577 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    11c53d5 View commit details
    Browse the repository at this point in the history
  9. Themes: Inject theme attribute during serialization.

    Rather than using `_inject_theme_attribute_in_block_template_content` to inject the `theme` attribute into all Template Part blocks found in a given file-based Block Template, introduce a new function called `_inject_theme_attribute_in_template_part_block`, and use that as second argument to `serialize_blocks()` (introduced in [56557]) in order to inject said attribute during tree traversal for serialization.
    
    This allows for a more modular approach that will eventually be extended to implement automatic insertion of hooked blocks.
    
    Note that we're guarding `_build_block_template_result_from_file()` (i.e. the callsite of `_inject_theme_attribute_in_template_part_block` and previously of `_inject_theme_attribute_in_block_template_content`) against regressions through additional unit test coverage added in [56562].
    
    Props @gziolo.
    Fixes #59338. See #59313.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56578 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    bbb85de View commit details
    Browse the repository at this point in the history
  10. Themes: Fix @Covers PHPDoc line for test.

    Follow-up to [56578].
    Props @mukesh27.
    See #59338.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56579 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    18fbb97 View commit details
    Browse the repository at this point in the history
  11. Twenty Nineteen: Fixes button line height.

    Line height was broken for button block and adding spacing.
    
    Props nidhidhandhukiya, shailu25.
    Fixes #58443.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56580 602fd350-edb4-49c9-b593-d223f7449a82
    karmatosed committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7305399 View commit details
    Browse the repository at this point in the history
  12. Twenty Ninteen: Revert changes to 'style-rtl.css'.

    This revert changes to Twenty Nineteen 'style-rtl.css' file made in [56580] as it auto-generated during the build process.
    
    Unprops karmatosed.
    Props costdev.
    See #58443.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56581 602fd350-edb4-49c9-b593-d223f7449a82
    karmatosed committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    943e2b9 View commit details
    Browse the repository at this point in the history
  13. Bundled Theme: Implement the_header_image_tag function for enhanced c…

    …ompatibility for older core themes.
    
    The `the_header_image_tag` function was introduced in WordPress 4.4 as part of [35594]. It is used in all themes created post WordPress 4.4 that supported header images. The function `get_header_image_tag` continues to get updated with new image features, like lazy loading, async decoding and fetch priority. To ensure our core themes maintain compatibility and benefit from these enhancements, a backward compatibility shim has been applied, integrating the `the_header_image_tag` function into the following core themes:
    
    - Twenty Ten
    - Twenty Eleven
    - Twenty Twelve
    - Twenty Fourteen
    - Twenty Sixteen
    
    This change ensures future compatibility and modern image features are applied for header images to these older themes. 
    
    Props spacedmonkey, flixos90, mukesh27.
    Fixes #58675.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56583 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    a5bcf19 View commit details
    Browse the repository at this point in the history
  14. Tests: Split tests for _inject_theme_attribute_in_template_part_block

    Follow-up to [56578].
    See #59338.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56584 602fd350-edb4-49c9-b593-d223f7449a82
    gziolo committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    950e762 View commit details
    Browse the repository at this point in the history
  15. Taxonomy: Introduce 'cache_results' parameter to WP_Term_Query for by…

    …passing query caching.
    
    Incorporating a new 'cache_results' parameter into the WP_Term_Query class, this commit empowers developers with the ability to bypass query caches, explicitly triggering database queries when needed.  This brings the `WP_Term_Query` class inline with `WP_Query` and `WP_User_Query` that already have a 'cache_results' parameter.
    
    Update the `term_exists` function to use this new parameter, so the term query caches are not used while importing. 
    
    Props dlh, spacedmonkey, peterwilsoncc.
    Fixes #52710.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56585 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    4ba29eb View commit details
    Browse the repository at this point in the history
  16. Coding Standards: Restore more descriptive variable names in a few cl…

    …ass methods.
    
    When various methods parameters in child classes were renamed to `$item` to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.
    
    To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' `::column_default()` methods.
    
    Follow-up to [51728], [51737], [51786].
    
    See #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56586 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e005108 View commit details
    Browse the repository at this point in the history
  17. General: Add block_hooks field to block type registration, REST API.

    In order to implement Block Hooks, we need to add a new `block_hooks` field to the `WP_Block_Type` class, as well as to block registration related functions, the block types REST API controller, etc.
    
    Props gziolo.
    Fixes #59346. See #59313.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56587 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7b90f22 View commit details
    Browse the repository at this point in the history
  18. Tests: Improve the assertions for REST API endpoint for block types

    Follow-up to [56587], [55673]. While working on #59346, it was noted that selectors fiels is not always included in the assertions. While looking at it is was difficult to spot the issue because the random order of how REST API fields where listed.
    
    Reorderd the REST API fields in the test cases to follow the list from the documentation: https://github.com/WordPress/gutenberg/blob/trunk/docs/reference-guides/block-api/block-metadata.md. This way it's going to be easier to maintain the list moving forward.
    
    Props ockham.
    See #59346, #59313, #57585.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56588 602fd350-edb4-49c9-b593-d223f7449a82
    gziolo committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    da28362 View commit details
    Browse the repository at this point in the history
  19. Administration: Fix undeclared variable.

    Moved `$updated_notice_args` to be defined before the conditional in which it's used.
    
    Props TobiasBg.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56589 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    bd8ff4a View commit details
    Browse the repository at this point in the history
  20. Administration: additional_classes is not a function.

    Correct usage of `additional_classes` array parameter as if it were a function. Clearly, I'm getting tired and missing things. So many little changes. Follow up to [56573].
    
    Props joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56590 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    73d8392 View commit details
    Browse the repository at this point in the history
  21. Media: Fix focus loss when closing Image Rotation menu.

    Only shift focus into menu when opening the menu. Check `aria-expanded` value of toggle before moving focus.
    
    Props joedolson.
    Fixes #59353.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56591 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    227fdb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Blocks: Remove the gutenberg textdomain accidently added to transla…

    …tion
    
    Props soean.
    See #59346.
    Follow-up [56587].
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56592 602fd350-edb4-49c9-b593-d223f7449a82
    gziolo committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    fd894bf View commit details
    Browse the repository at this point in the history
  2. Coding Standards: Improve organization of the WPCS-based PHPCS ruleset.

    This commit:
    * Adds section headers to the ruleset file.
    * Organizes all directives in their respective sections.
    
    No functional changes.
    
    Props jrf.
    See #59161.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56593 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    ffc7b50 View commit details
    Browse the repository at this point in the history
  3. Coding Standards: Remove the custom property for the FileName sniff.

    Test files should comply with the naming conventions accepted by PHPUnit, not with the WP naming conventions.
    
    While the `WordPress.File.FileName` sniff makes a best effort to prevent throwing errors for files containing test classes, the recommended manner to deal with test files is to exclude the complete test directory from being subject to this sniff.
    
    This updates the ruleset to follow the recommendation.
    
    Follow-up to [42346], [45607].
    
    Props jrf.
    See #59161.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56594 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    60d2d8a View commit details
    Browse the repository at this point in the history
  4. Options, Meta APIs: Optimize get_option by relocating notoptions cach…

    …e lookup.
    
                        
    In the get_option function, a cache lookup for the notoptions key is performed, which stores an array of keys for options known not to exist. This optimization prevents repeated database queries when certain options are requested. However, the cache lookup for notoptions was conducted before checking if the requested option exists in the cache. Given that it's more likely that the option does exist, this commit reorders the checks to first verify the option's existence in the cache before confirming its absence. This adjustment reduces redundant queries and also eliminates an unnecessary cache lookup, improving overall performance.
    
    Props spacedmonkey, costdev, flixos90, azaozz.
    Fixes #58277.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56595 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0c7ddbd View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. Coding Standards: Remove extra parentheses in a few str_contains()

    …conditionals.
    
    Follow-up to [55988].
    
    Props Cybr.
    See #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56596 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    8161a8c View commit details
    Browse the repository at this point in the history
  2. Administration: Increase wp_admin_notice() usage in /wp-includes/.

    Adds further usages of `wp_admin_notice()` in the root level of `/wp-includes/` on `.error` and `.notice-info`.
    
    Ongoing task to implement new function across core.
    
    Follow-up to [56408], [56409], [56410], [56518], [56570], [56571], [56572], [56573], [56576], [56589], [56590].
    
    Props joedolson, costdev.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56597 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    5cfb817 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Coding Standards: Fix a few newly introduced WPCS issues.

    Follow-up to [56515], [56557], [56560].
    
    Props jrf.
    See #59161, #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56598 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    fe097d1 View commit details
    Browse the repository at this point in the history
  2. Administration: Use wp_admin_notice() more in /wp-admin/includes/.

    Adds further usages of `wp_admin_notice()` in `/wp-admin/includes/` on `.notice-error`, `.notice-warning`, `.error`, and `.updated`.
    
    Ongoing task to implement new function across core.
    
    Follow-up to [56408], [56409], [56410], [56518], [56570], [56571], [56572], [56573], [56576], [56589], [56590], [56597].
    
    Props joedolson, mukesh27, costdev.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56599 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    ce32693 View commit details
    Browse the repository at this point in the history
  3. Administration: Use wp_admin_notice() more in wp-admin/.

    Add additional usage of `wp_admin_notice()` in `wp-admin/` on `.error` and miscellaneous usages previously overlooked. 
    
    Follow up to [56408], [56409], [56410], [56518], [56570], [56571], [56572], [56573], [56576], [56589], [56590], [56597], [56599].
    
    Props costdev, joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56600 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    f058bd1 View commit details
    Browse the repository at this point in the history
  4. Administration: Use wp_admin_notice() in wp-admin/network/.

    Add additional usage of `wp_admin_notice()` in `wp-admin/network/` where previously overlooked. 
    
    Follow up to [56408], [56409], [56410], [56518], [56570], [56571], [56572], [56573], [56576], [56589], [56590], [56597], [56599], [56600].
    
    Props costdev, joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56601 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    1e11c3f View commit details
    Browse the repository at this point in the history
  5. Administration: Move tabindex="-1" from notice to JS.

    In a handful of admin notices, a `tabindex` attribute is set so that JS can move focus to the notice `div`. Rather than adding `tabindex` to globally accepted attributes for `wp_kses_post()`, move the assignment of `tabindex` into the JS handlers that display those notices. The attribute is only relevant if JS is running, so there is no reason to add it in the original HTML notice.
    
    Follow up to [56408], [56409], [56410], [56518], [56570], [56571], [56572], [56573], [56576], [56589], [56590], [56597], [56599], [56600], [56601].
    
    Props costdev, joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56602 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    4e0e460 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Administration: Add support for attributes in wp_admin_notice().

    Allow admin notices to be created with additional attributes. Test attributes include `hidden`, `data-*`, and `role="*"` values, which are all in use in various admin notices across core. 
    
    This commit adds `aria-live` and `hidden` to the KSES global attributes array to support core usages.
    
    Follow up to [56408], [56409], [56410], [56518], [56570], [56571], [56572], [56573], [56576], [56589], [56590], [56597], [56599], [56600], [56601], [56602].
    
    Props costdev, joedolson.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56603 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    4bcf32a View commit details
    Browse the repository at this point in the history
  2. Editor: add block instance element color support for buttons and head…

    …ings.
    
    Adds support for buttons and headings to the colors and elements block supports, allowing button and heading element colors to be changed on individual blocks.
    
    Props aaronrobertshaw.
    Fixes #59309.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56604 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    ac8db41 View commit details
    Browse the repository at this point in the history
  3. Editor: add text orientation for blocks with typography support.

    Adds a new text orientation option to the typography block support, implemented with CSS writing-mode.
    
    Props poena.
    Fixes #59306.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56605 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    da48a9e View commit details
    Browse the repository at this point in the history
  4. Posts: update admin notices to refer to patterns.

    Updates `wp_block` action notices to refer to patterns instead of blocks.
    
    Props aaronrobertshaw, mukesh27, oglekler.
    Fixes #59305.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56606 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    3239a8e View commit details
    Browse the repository at this point in the history
  5. Tests: Add additional tests covering Block Hooks registration

    Props ockham.
    See #59346.
    Follow-up [56587].
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56607 602fd350-edb4-49c9-b593-d223f7449a82
    gziolo committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d47515c View commit details
    Browse the repository at this point in the history
  6. Docs: Document aria-live and hidden in safecss_filter_attr().

    In [56603], support was added for `aria-live` and `hidden` attributes in `safecss_filter_attr()`.
    
    This adds a `@since` annotation to document this change.
    
    Follow-up to [56603].
    
    Props mukesh27.
    See #57791.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56608 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    a7c9394 View commit details
    Browse the repository at this point in the history
  7. Plugins: Store result of call to array_keys, to save repeated calls i…

    …n WP_Hook class.
    
                        
    In the `WP_Hook` class the function `array_keys` was called every time an array of hook priorities was needed. For sites with lots of filters or actions, this would result in thousands of calls to the `array_keys` function, which uses server resources. Instead of recomputing this array every time it is needed, only compute it when filters are added and removed, then store the result as a class property. Improve unit tests to ensure this behaviour is tested. 
    
    Props spacedmonkey, bor0, flixos90, hellofromTonya, mukesh27.
    Fixes #58458.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56609 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    4ee5947 View commit details
    Browse the repository at this point in the history
  8. Blocks: Introduce helper function to retrieve hooked blocks

    In order to implement Block Hooks (see #59313), we added block_hooks field to the WP_Block_Type class, as well as to block registration related functions. In this follow-up, new helper function gets introduced that is going to compute the list of hooked blocks by other registered blocks for a given block type.
    
    Extracted from #5158 and covered with unit tests.
    
    Props ockham.
    Fixes #59383.
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56610 602fd350-edb4-49c9-b593-d223f7449a82
    gziolo committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    6340624 View commit details
    Browse the repository at this point in the history
  9. Quick Edit: Allow Quick Edit to be disabled for custom post types or …

    …taxonomies.
    
    Some custom post types or taxonomies may not need the Quick Edit functionality, in which case adding hidden fields and rendering the form with the data to edit would be redundant.
    
    This commit introduces two filters for more granular control:
    
    * `quick_edit_enabled_for_post_type`
    * `quick_edit_enabled_for_taxonomy`
    
    Follow-up to [8857], [9083], [9098].
    
    Props garyc40, sabernhardt, mukesh27, costdev, oglekler, wyrfel, peterwilsoncc, faguni22, robinwpdeveloper, webcommsat, johnbillion, azaozz, hellofromTonya, GunGeekATX, Jick, mikeschinkel, jane, nacin, helen, wonderboymusic, DrewAPicture, SergeyBiryukov.
    Fixes #16502, #19343, #57596.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56611 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    6a264d2 View commit details
    Browse the repository at this point in the history
  10. Media: Enhance wp_get_loading_optimization_attributes() to support …

    …arbitrary context values.
    
    The `wp_get_loading_optimization_attributes()` function, which was introduced in 6.3, based on the now deprecated `wp_get_loading_attr_default()` function introduced in 5.5, relies on a `$context` parameter based on which it may alter its behavior and the attributes returned. So far, it has only supported context values used within WordPress core.
    
    This changeset decouples the behaviors of the function from specific contexts, allowing for more flexibility. Theme and plugin developers will be able to rely on their own context values when rendering images in non-standard ways, rather than being forced to use a core context, to get the loading optimization benefits the function provides.
    
    As part of this change, a `wp_loading_optimization_force_header_contexts` filter is introduced, which allows filtering the map of context values and whether they should be considered header contexts, i.e. i.e. any image having one of these contexts will be assumed to appear above the fold.
    
    Props mukesh27, costdev, flixos90.
    Fixes #58894.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56612 602fd350-edb4-49c9-b593-d223f7449a82
    felixarntz committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    414a123 View commit details
    Browse the repository at this point in the history
  11. Bundled Theme: Add missing dimension attributes to images in Twenty T…

    …wenty-Two patterns.
    
    The dimension attributes `width` and `height` should be present on every image in order to avoid layout shifts and be able to leverage WordPress core's image loading optimization functionality.
    
    This changeset adds dimension attributes to the `core/image` blocks used in block patterns in Twenty Twenty-Two, where this is particularly critical as WordPress core cannot backfill the attributes for those images, as their sources are not part of the Media Library.
    
    Props spacedmonkey, thekt12, mukesh27, flixos90.
    Fixes #59256.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56613 602fd350-edb4-49c9-b593-d223f7449a82
    felixarntz committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d4cf682 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Editor: add background image support.

    Adds a new background block support with the ability to set a background image on blocks that opt into it.
    
    Props andrewserong, mukesh27.
    Fixes #59357.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56614 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1327f17 View commit details
    Browse the repository at this point in the history
  2. Editor: fix pattern alignment in editor view.

    Adjusts root padding for synced patterns in the editor to avoid discrepancies with the front end view.
    
    Props aaronrobertshaw, mukesh27.
    Fixes  #59359.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56615 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1cd9877 View commit details
    Browse the repository at this point in the history
  3. Coding Standards: Replace PHP alias join() with implode().

    In [52190], some new instances of the `join()` alias were introduced in the test suite.
    
    Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning.
    
    This replaces the new `join()` uses with the canonical `implode()` function name.
    
    Follow-up to [46182], [49193], [49805], [52190].
    
    Props david.binda, mukesh27.
    Fixes #59389.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56616 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8ce85f9 View commit details
    Browse the repository at this point in the history
  4. KSES: Add writing-mode to the list of safe CSS properties.

    Original PR from Gutenberg repository:
    * [WordPress/gutenberg#54581 #54581 Gutenberg Plugin: Add hook to allow `writing-mode` as a safe CSS property]
    
    Reference: [https://developer.mozilla.org/en-US/docs/Web/CSS/writing-mode MDN Web Docs: writing-mode].
    
    Follow-up to [56605].
    
    Props wildworks, mukesh27, poena, andrewserong.
    Fixes #59387.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56617 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    cf2f441 View commit details
    Browse the repository at this point in the history
  5. Blocks: Implement block insertion functions.

    For #59313, we need to implement functions to insert a given parsed block into another parsed block's inner blocks, and to prepend and append to that array, respectively.
    
    We will use those functions in combination with `traverse_and_serialize_blocks` (see #59327) to implement automatic insertion of hooked blocks into block templates and patterns.
    
    Props gziolo.
    Fixes #59385.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56618 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8e8de91 View commit details
    Browse the repository at this point in the history
  6. Editor: Fix parameter reference in block editor settings tests.

    In [50776], the `filter_set_block_editor_settings_post()` callback was introduced for use in block editor settings tests.
    
    This contained a reference to an `$allowed_block_types` parameter, which doesn't exist.
    
    This changes the reference to `$editor_settings`.
    
    Follow-up to [50776].
    
    Props david.binda, mukesh27, SergeyBiryukov.
    Fixes #59391.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56619 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3916624 View commit details
    Browse the repository at this point in the history
  7. Blocks: Introduce a variation of serialize blocks helper with traversing

    Introduces two new functions `traverse_and_serialize_blocks` and `traverse_and_serialize_block` with the additional `$callback` argument. It is possible to pass parent block, block index, chunk index to the callback argument.
    
    Reverts changes applied to `serialize_blocks` and `serialize_block` in #59327 with [56557].
    
    Props ockham, mukesh27.
    See #59313.
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56620 602fd350-edb4-49c9-b593-d223f7449a82
    gziolo committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    48b9b6c View commit details
    Browse the repository at this point in the history
  8. Themes: Improve performance of get_block_theme_folders function

                        
    This commit enhances the performance of the get_block_theme_folders function by introducing a new method called get_block_template_folders within the WP_Theme class. Previously, this function suffered from poor performance due to repeated file lookups using file_exists. The new method implements basic caching, storing the result in the theme's cache, similar to how block themes are cached in the block_theme property (see [55236]).
    
    Additionally, this change improves error handling by checking if a theme exists before attempting to look up the file. It also enhances test coverage. 
    
    Props spacedmonkey, thekt12, swissspidy, flixos90, costdev, mukesh27.
    Fixes #58319.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56621 602fd350-edb4-49c9-b593-d223f7449a82
    spacedmonkey committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9a734f3 View commit details
    Browse the repository at this point in the history
  9. Build/Test Tools: Add sys_get_temp_dir() to open_basedir tests.

    In PHPUnit 10.3.5, 9.6.13 and 8.5.34, the child processes used for process isolation now use temporary files to communicate their result to the parent process.
    
    This caused a failure in some tests that set the `open_basedir` PHP directive to a value that did not include `sys_get_temp_dir()`.
    
    This adds `sys_get_temp_dir()` to the `open_basedir` value set by the tests to ensure that permission is still granted for the temporary directory.
    
    PHPUnit uses `sys_get_temp_dir()`. To ensure the result is the same, Core's `get_temp_dir()` function is not used.
    
    References:
    - sebastianbergmann/phpunit#5356
    
    Props desrosj, mukesh27, SergeyBiryukov, costdev.
    Fixes #59394.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56622 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7d96189 View commit details
    Browse the repository at this point in the history
  10. Media: Edit new hook name in get_available_post_mime_types().

    This is a follow-up to [56452] in which a new filter hook was added to `get_available_post_mime_types()` to override a potentially slow query. This renames the previous hook from `get_available_post_mime_types` to `pre_get_available_post_mime_types` for clarity.
    
    Props rcorrales, emrikol, johnbillion, joemcgill, mukesh27.
    Fixes #52759.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56623 602fd350-edb4-49c9-b593-d223f7449a82
    joemcgill committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3bacfc9 View commit details
    Browse the repository at this point in the history
  11. External Libraries: Update the regenerator-runtime library.

    This updates the `regenerator-runtime` library to version `0.14.0`.
    
    Props rajinsharwar, oglekler.
    Fixes #59078.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56626 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e266e93 View commit details
    Browse the repository at this point in the history
  12. External Libraries: Update the regenerator-runtime version.

    Adds the required change to the `script-loader.php` file for [56626] that was missed.
    
    See #59078.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56627 602fd350-edb4-49c9-b593-d223f7449a82
    desrosj committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3f76edd View commit details
    Browse the repository at this point in the history
  13. Login and Registration: Introduce classes wp-login.php footer links.

    This introduces classes for the "Log in", "Register" and "Lost your password?" links in the footer of `wp-login.php` forms so that they may be easily targeted for individual styling.
    
    The new classes are:
    - `.wp-login-log-in`
    - `.wp-login-register`
    - `.wp-login-lost-password`
    
    Props wparslan, thomasplevy, rajinsharwar, audrasjb, joedolson, costdev.
    Fixes #57590.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56628 602fd350-edb4-49c9-b593-d223f7449a82
    costdev committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a0cce39 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Editor: Fix post editor layout when Post Content has no attributes.

    Changes output of `wp_get_post_content_block_attributes` to return null if Post Content block doesn’t exist or empty array if it has no attributes.
    
    Props flixos90, mukesh27.
    Fixes #59358.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56629 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bee2dc4 View commit details
    Browse the repository at this point in the history
  2. Editor: update docs for css_var.

    Updates inline doc for the `css_var` key value pair in WP_Style_Engine.
    
    Props ramonopoly.
    Fixes #59401.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56630 602fd350-edb4-49c9-b593-d223f7449a82
    tellthemachines committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    669d11f View commit details
    Browse the repository at this point in the history
  3. Taxonomy: Restrict term edit link generation in `WP_Terms_List_Table:…

    …:handle_row_actions()`.
    
    This changeset restricts edit term link generation if the user lacks the `edit_term` cap in order to prevent PHP 8.1+ deprecations shown when a user lacks this 
    capability and `get_edit_term_link()` returns null.
    
    Props thelovekesh, jrf.
    Fixes #59336.
    
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56631 602fd350-edb4-49c9-b593-d223f7449a82
    audrasjb committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1113b2d View commit details
    Browse the repository at this point in the history
  4. Coding Standards: Add missing escaping functions in `wp-admin/export.…

    …php`
    
    Props viralsampat.
    See #58831.
    
    
    
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56632 602fd350-edb4-49c9-b593-d223f7449a82
    audrasjb committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8fea8aa View commit details
    Browse the repository at this point in the history
  5. Coding Standards: Escape the whole attribute in wp-admin/export.php.

    It is best to always escape the complete value of an attribute, not a partial value, as otherwise the escaping could be (partially) undone when the values are joined together.
    
    While the hardcoded hyphen in this case don't necessarily create that risk, it may change to a value which could be problematic, so making it a habit to escape the value in one go is best practice.
    
    Escaping the complete value also means that a single `esc_attr()` call can be used instead of two.
    
    Follow-up to [14444], [16652], [55616], [56632].
    
    See #58831.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56633 602fd350-edb4-49c9-b593-d223f7449a82
    SergeyBiryukov committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    58bb4b7 View commit details
    Browse the repository at this point in the history
  6. Blocks: Revert implementation of block insertion functions.

    In [56618], three functions (`insert_inner_block`, `prepend_inner_block`, and `append_inner_block`) were introduced. They were meant to be used for insertion of hooked blocks; however, it was discovered that the original idea wouldn't work for sibling insertion. Instead, a different approach will be taken (see #59412), and these functions are no longer needed and can thus be removed.
    
    Reverts [56618].
    See #59412, #59385, #59313.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56634 602fd350-edb4-49c9-b593-d223f7449a82
    ockham committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8c0e0b3 View commit details
    Browse the repository at this point in the history
  7. Themes: Deprecate usage of TEMPLATEPATH and STYLESHEETPATH consta…

    …nts.
    
    While generally the functions `get_template_directory()` and `get_stylesheet_directory()` were long recommended to use to get the parent or child theme directory, the `TEMPLATEPATH` and `STYLESHEETPATH` constants were still used in a few places in core, most importantly in template related logic.
    
    The remaining usage was problematic as it prevented testability of certain key components of WordPress core.
    
    This changeset replaces all remaining usage with the corresponding functions and effectively marks these constants as deprecated. It also adds test coverage accordingly and even unlocks some existing, previously commented out test coverage to work as expected.
    
    Performance of the new approach has been benchmarked and shows no notable differences. Yet, given that the current theme directories are not expected to change within a regular WordPress page load, the `get_template_directory()` and `get_stylesheet_directory()` functions were amended with in-memory caching of the result, unless one of the defining values is being filtered.
    
    Props thekt12, spacedmonkey, mukesh27, aaroncampbell, scribu, lloydbudd, cais, chipbennett, toscho, omarabid, CrazyJaco, DrewAPicture, obenland, wonderboymusic, nacin, helen, dd32, chriscct7, SergeyBiryukov, swissspidy, joemcgill, flixos90.
    Fixes #18298.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56635 602fd350-edb4-49c9-b593-d223f7449a82
    felixarntz committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ec21b60 View commit details
    Browse the repository at this point in the history
  8. Users: Improve vertical spacing consistency in labels.

    Adjust display of user profile labels on small screens so they are consistent with the layout used elsewhere.
    
    Props nandhuraj, costdev, sabernhardt, sarathar, vivekawsm.
    Fixes #58493.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56636 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    107c730 View commit details
    Browse the repository at this point in the history
  9. XML-RPC: Add alt attribute value to media item API.

    Add alt text to the `wp.getMediaItem` method in the XML-RPC API. Allows users to fetch alt text as a first-class member of a media object.
    
    Props thomashorta, joedolson, jivygraphics, stephenerdelyi, mukesh27, whyisjake.
    Fixes #58582.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56637 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    5b79a4c View commit details
    Browse the repository at this point in the history
  10. General: Account for Sec-CH-UA-Mobile client hint request header in…

    … `wp_is_mobile()`.
    
    Add missing test coverage for `wp_is_mobile()`.
    
    Fixes #59370.
    Props westonruter, flixos90.
    
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56638 602fd350-edb4-49c9-b593-d223f7449a82
    westonruter committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e40a118 View commit details
    Browse the repository at this point in the history
  11. Administration: Improve control proximity in theme details modal.

    Make the theme details modals in the Customizer and at Appearance > Themes consistent. Change the order of controls so both modals are in the same sequence, center all controls in both desktop and mobile views, and change delete link color to meet color contrast requirements.
    
    Props trishasalas, afercia, melchoyce, karmatosed, cathibosco1, michaelarestad, joedolson, petitphp, mikinc860.
    Fixes #59372. See #59371, #40822.
    
    git-svn-id: https://develop.svn.wordpress.org/trunk@56639 602fd350-edb4-49c9-b593-d223f7449a82
    joedolson committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    89b97ba View commit details
    Browse the repository at this point in the history