Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Application of Additional Field for Enchantment Entity Effect #530

Closed
catter1 opened this issue May 31, 2024 · 0 comments
Closed
Labels
bug Something isn't working ✨ schemas

Comments

@catter1
Copy link
Contributor

catter1 commented May 31, 2024

With custom enchantments, there is the entity effect spawn_particles. One of the fields, horizontal_position (or vertical_) has the types of entity_position or in_bounding_box.

According to the wiki, if in_bounding_box is used, there is an optional field of scale, to scale the bounding box.
image

However, in the enchantment generator, scale appears when entity_position is selected, rather than in_bounding_box. This should be reversed (if the wiki is correct).
image
image

edit: In fact, the datapack actually fails to validate if the scale field is used alongside entity_position. I am testing in 1.21 pre-1. I glanced over the past couple of snapshot articles, but I didn't see any changes to this (in case if this was a case on the generator simply not being updated to the latest snapshot).

@misode misode added bug Something isn't working ✨ schemas labels May 31, 2024
@misode misode closed this as completed in 86b3bed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ✨ schemas
Projects
None yet
Development

No branches or pull requests

2 participants