Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wiring_and_connectors.rst #242

Merged
merged 2 commits into from Jul 15, 2019
Merged

Update wiring_and_connectors.rst #242

merged 2 commits into from Jul 15, 2019

Conversation

ironspider
Copy link
Contributor

First crack at adding a .093" Molex wire-to-wire connectors section with part numbers.

@jabdoa2
Copy link
Collaborator

jabdoa2 commented Jul 14, 2019

Thanks for writing that up. Linter is unhappy but it is only a warning:


Warning, treated as error:
/home/travis/build/missionpinball/mpf-docs/hardware/voltages_and_power/wiring_and_connectors.rst:77:Title underline too short.
Wire-to-Wire Connections
-----------------------
/home/travis/build/missionpinball/mpf-docs/hardware/voltages_and_power/wiring_and_connectors.rst:77:Title underline too short.

@ironspider
Fixed underline
f7de853 
This is the first time I've ever had to edit a pull request so I don't know if I'm doing it correctly but looks like there was an underline length error so I've added another dash to extend the underline to the end of the title section's name. Hope that was done correctly.
ironspider
ironspider commented Jul 14, 2019
View reviewed changes
Copy link
Contributor Author

@ironspider ironspider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extended the underline to address linter warning

@jabdoa2 jabdoa2 merged commit 1e2c3a0 into missionpinball:dev Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ironspider @jabdoa2