Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget image unload crash #384

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Widget image unload crash #384

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10b2f7b
Ignore errors removing already-unloaded images
avanwinkle Jun 22, 2019
2a61435
Merge branch 'dev' into widget-image-unload-crash
avanwinkle Jul 29, 2019
fffaecc
Merge branch 'dev' into widget-image-unload-crash
avanwinkle Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mpfmc/widgets/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ def prepare_for_removal(self) -> None:
"""Prepare the widget to be removed."""
super().prepare_for_removal()
# stop any animations
self._image.image.anim_reset(False)
try:
self._image.image.anim_reset(False)
# If the image was already unloaded from memory
except AttributeError:
pass

def _draw_widget(self, *args):
"""Draws the image (draws a rectangle using the image texture)"""
Expand Down