Exception wrapping #408
Merged
Exception wrapping #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanwinkle
commented
Oct 26, 2020
| @@ -31,6 +31,7 @@ def __init__(self, mc: "MpfMc", config: dict, key: Optional[str] = None, **kwarg | |||
| # draws a rectangle using the texture from the loaded image asset to | |||
| # display the image. Scaling and rotation is handled by the Scatter | |||
| # widget. | |||
| image = None | |||
There was a problem hiding this comment.
Adding this line so the exception handler down below won't throw a different exception on image being undefined.
|
Nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to improve the exception handling of MPF/MC as I work—whenever I get a crash that requires me to scroll through the callstack or look in the logs, I update the Exception chain to try and get the meaningful error into the final callstack message.
I think we should do a 50.4 release soon, so making a PR for the changes I've got so far.