Support arbitrary starting states for StateMachine #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: (32 commits) 0.53.0-dev.76 implement oc detection procedure fix CS 0.53.0-dev.75 behave a bit more like spike 0.53.0-dev.74 expose oc_time as config option 0.53.0-dev.73 fix LED wait times fix timings 0.53.0-dev.72 use known working command 0.53.0-dev.71 update spike 0.53.0-dev.70 behave more like the spike game 0.53.0-dev.69 add another missing parameter 0.53.0-dev.68 Spike Firmware 0.49.0 compatibility ...
|
Very well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
StateMachinedevices can support arbitrary state names for their progression, they currently must usestartas their initial state.This PR allows State Machines to define any of their states to use as the initial state, with
startas the default value. As a result, there should be no breaking change for existing machines that do not specifystarting_state:.Tests included!