Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 2023.11.1 #12330

Merged
merged 60 commits into from
Nov 17, 2023
Merged

Release: 2023.11.1 #12330

merged 60 commits into from
Nov 17, 2023

Conversation

syuilo
Copy link
Member

@syuilo syuilo commented Nov 14, 2023

General

  • Feat: 管理者がコントロールパネルからメールアドレスの照会を行えるようになりました
  • Enhance: ローカリゼーションの更新
  • Enhance: 依存関係の更新

Client

Server

  • Enhance: FTTのデータベースへのフォールバック処理を行うかどうかを設定可能に
  • Fix: トークンのないプラグインをアンインストールするときにエラーが出ないように
  • Fix: 投稿通知がオンでもダイレクト投稿はユーザーに通知されないようにされました
  • Fix: ユーザタイムラインの「ノート」選択時にリノートが混ざり込んでしまうことがある問題の修正 プロフィールページのノートタブで誤ってリノートが含まれることがある #12306
  • Fix: LTLに特定条件下にてチャンネルへの投稿が混ざり込む現象を修正
  • Fix: ActivityPub: 追加情報のカスタム絵文字がユーザー情報のtagに含まれない問題を修正
  • Fix: ActivityPubに関するセキュリティの向上
  • Fix: 非公開の投稿に対して返信できないように

syuilo and others added 24 commits November 6, 2023 11:21
ポップアップの表示後、MkNoteとMkNoteDetailedでそれぞれが持つfocusメソッドを呼び出していたのをやめた

Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com>
Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com>
* Update CHANGELOG.md

* fix: show real instance url

---------

Co-authored-by: tamaina <tamaina@hotmail.co.jp>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Co-authored-by: atsuchan <83960488+atsu1125@users.noreply.github.com>
Co-authored-by: Masaya Suzuki <15100604+massongit@users.noreply.github.com>
Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
Co-authored-by: taiy <53635909+taiyme@users.noreply.github.com>
Co-authored-by: xianon <xianon@hotmail.co.jp>
Co-authored-by: kabo2468 <28654659+kabo2468@users.noreply.github.com>
Co-authored-by: YS <47836716+yszkst@users.noreply.github.com>
Co-authored-by: Khsmty <me@khsmty.com>
Co-authored-by: Soni L <EnderMoneyMod@gmail.com>
Co-authored-by: mei23 <m@m544.net>
Co-authored-by: daima3629 <52790780+daima3629@users.noreply.github.com>
Co-authored-by: Windymelt <1113940+windymelt@users.noreply.github.com>
Co-authored-by: Ebise Lutica <7106976+EbiseLutica@users.noreply.github.com>
Co-authored-by: nenohi <kimutipartylove@gmail.com>
Co-authored-by: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
Co-authored-by: rinsuki <428rinsuki+git@gmail.com>
Co-authored-by: FineArchs <133759614+FineArchs@users.noreply.github.com>
* fix: 投稿通知がオンでもダイレクト投稿はユーザーに通知されないように

* Update CHANGELOG.md
* デッキのカラムからリロードできる機能を追加

* tweak

---------

Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com>
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
* fix(frontend): アイコンデコレーションがナビゲーションバーでクリップされないように

* Revert "fix(frontend): アイコンデコレーションがナビゲーションバーでクリップされないように"

This reverts commit db246b1.

* fix: tweak padding of account in navbar

* fix: set minimum height of note preview

* fix: リアクション一覧でアイコンデコレーションが見切れないように

* Update CHANGELOG.md

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
…#12308)

* fix(frontend): 「フォロー中の人全員の返信を含める/含めないようにする」のボタンを押下した際の確認が機能していない問題を修正

* Update CHANGELOG.md
* ユーザのノートのみ表示時にDBへフォールバックするとリノートを含んでしまうのを修正

* fix CHANGELOG.md

---------

Co-authored-by: osamu <46447427+sam-osamu@users.noreply.github.com>
* fix

* fix: websocket stream origin
This commit implements HTTP header and body validation to fix
[SIF-2023-002](https://advisory.silicon.moe/advisory/sif-2023-002/)

Signed-off-by: perillamint <perillamint@silicon.moe>
Co-authored-by: perillamint <perillamint@silicon.moe>
Co-authored-by: yunochi <yuno@yunochi.com>
@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/sw and PWA ServiceWorker and PWA related issue/PR packages/misskey-js labels Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 224 lines in your changes are missing coverage. Please review.

Comparison is base (f72228f) 78.85% compared to head (76ccae8) 78.77%.
Report is 35 commits behind head on master.

❗ Current head 76ccae8 differs from pull request most recent head f007890. Consider uploading reports for the commit f007890 to get more accurate results

Files Patch % Lines
...ges/backend/src/server/ActivityPubServerService.ts 11.53% 69 Missing ⚠️
...c/server/api/endpoints/notes/user-list-timeline.ts 63.20% 46 Missing ⚠️
...src/components/global/MkMisskeyFlavoredMarkdown.ts 9.67% 28 Missing ⚠️
...rver/api/endpoints/admin/accounts/find-by-email.ts 75.40% 15 Missing ⚠️
packages/backend/src/core/MfmService.ts 0.00% 12 Missing ⚠️
.../src/server/api/endpoints/notes/hybrid-timeline.ts 85.88% 12 Missing ⚠️
...d/src/server/api/endpoints/notes/local-timeline.ts 83.33% 12 Missing ⚠️
...backend/src/server/api/endpoints/notes/timeline.ts 82.60% 12 Missing ⚠️
packages/frontend/src/components/global/MkTime.vue 11.11% 8 Missing ⚠️
packages/backend/src/core/NoteCreateService.ts 28.57% 5 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12330      +/-   ##
==========================================
- Coverage   78.85%   78.77%   -0.08%     
==========================================
  Files         945      945              
  Lines      101990   102164     +174     
  Branches     8236     8262      +26     
==========================================
+ Hits        80423    80481      +58     
- Misses      21567    21683     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member Author

syuilo commented Nov 17, 2023

マージする

@fruitriin
Copy link
Contributor

fruitriin commented Nov 17, 2023

スクリーンショット 2023-11-17 18 13 52

safari及びiOSでルビがセンター寄せにならないのでこういう感じのをいれてほしい

/* ルビをセンター寄せ */
rt {
    text-align: center;
}

@syuilo
Copy link
Member Author

syuilo commented Nov 17, 2023

done 🙏🏻

@syuilo
Copy link
Member Author

syuilo commented Nov 17, 2023

あーでもそうすると非safariで表示が微妙になるわね

@syuilo
Copy link
Member Author

syuilo commented Nov 17, 2023

text-align: center; 未指定時
image

text-align: center; 指定時
image

@fruitriin
Copy link
Contributor

centerより justify ?

@syuilo
Copy link
Member Author

syuilo commented Nov 17, 2023

それかと思ったけどこうなった
image

@fruitriin
Copy link
Contributor

😢

@fruitriin
Copy link
Contributor

@syuilo
Copy link
Member Author

syuilo commented Nov 17, 2023

FireFoxしか対応してなさそう

@fruitriin
Copy link
Contributor

ブラウザが全然対応してなさそう

@syuilo
Copy link
Member Author

syuilo commented Nov 17, 2023

とりあえずブラウザ標準のスタイルに任せるか

@syuilo
Copy link
Member Author

syuilo commented Nov 17, 2023

Safariだけに適用されるメディアクエリとか書きたい

@syuilo syuilo merged commit 9784d10 into master Nov 17, 2023
34 checks passed
@syuilo
Copy link
Member Author

syuilo commented Nov 17, 2023

🙏🏻 🙏🏻 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js packages/sw and PWA ServiceWorker and PWA related issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.