separate disk backend ops from block_if logic #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 14, 2016 03:03
|
@dborca, looking at how things are faring it probably makes sense to rebase this against hyperkit and do a PR on their repo as it appears to be the de facto upstream these days... other than this great features to have! |
|
Yeah, you're probably right. However, those were some patches I had lying around for a while now and decided to publish before forgetting about them completely. Unfortunately, I don't have time right now to rebase them against hyperkit. Maybe sometime in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates actual disk backends from the block_if logic. It should allow, at least in theory, different backends with minimal (ideally none) interference in block_if. The purpose is to permit compressed/sparse/encrypted/cow backends to be written and tested easily. /cc @dunkelstern #82