-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wp is exec #362
Draft
andres-erbsen
wants to merge
8
commits into
mit-plv:master
Choose a base branch
from
andres-erbsen:wp-is-exec
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Wp is exec #362
Commits on Aug 1, 2023
-
define a WP.cmd' in terms of exec, might soon replace WP.cmd
and rules for cmd' whose premises are copied from WP.cmd. This one is "fs everywhere" (ie list of functions everywhere). The wp_call rule requires a NoDup, which would be cumbersome to carry around.
Configuration menu - View commit details
-
Copy full SHA for 7a43f3a - Browse repository at this point
Copy the full SHA 7a43f3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b3e917 - Browse repository at this point
Copy the full SHA 4b3e917View commit details -
Configuration menu - View commit details
-
Copy full SHA for b98be1f - Browse repository at this point
Copy the full SHA b98be1fView commit details -
instead of unfold1_cmd_goal, eapply lemma_corresponding_to_command
In an "env everywhere" setting, where program_logic_goal_for! adds a (map.get fs fname = Some fimpl) hypothesis. Surprise mit-plv#1: There's no case in straightline that handles if-then-else Surprise mit-plv#2: unfold1_... tactics are not the only place that depend on conversion: There also exists a letexists in SPI that turns a (WP (cmd.cond e _ _) ...) into an (exists v, eval e v /\ ...), and probably more elsewhere.
Configuration menu - View commit details
-
Copy full SHA for 867c49b - Browse repository at this point
Copy the full SHA 867c49bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36882d9 - Browse repository at this point
Copy the full SHA 36882d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36780ed - Browse repository at this point
Copy the full SHA 36780edView commit details -
trying to pretend the new
cmd
is unfoldable bysneaking an `apply_rules_until_propositional` call into `letexists`, `eexists`, `esplit`, and inserting `unfold1_cmd_goal` where still needed. Gave up on memmove because it seems too hard to simulate a `cbn` that happens under exists and ands by applying wp rules under these exists and ands.
Configuration menu - View commit details
-
Copy full SHA for 978d785 - Browse repository at this point
Copy the full SHA 978d785View commit details -
Configuration menu - View commit details
-
Copy full SHA for b46e864 - Browse repository at this point
Copy the full SHA b46e864View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.