Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix salt bootstrap issue after 1.7.3 upgrade with verbose option set #5936

Merged
merged 2 commits into from
Jul 13, 2015
Merged

Fix salt bootstrap issue after 1.7.3 upgrade with verbose option set #5936

merged 2 commits into from
Jul 13, 2015

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Jul 11, 2015

After upgrading to 1.7.3 we found that our VMs would not execute salt. I narrowed that down to the use of the verbose option. So removing that is a workaround for now. However we don't get any salt output which makes debugging changes to our config difficult.

I found that #5435 added a new install_command option but that seemed to always set the options value to a DummyConfig type instead of the expected string. It seems that the option wasn't initialized in config.rb so I've added that which fixes the problem on my machine.

Our current VMs already have salt installed but I think this might actually break normal salt install so it might be very urgent to fix for a good amount of people.

Fixes #5939

@cedricpim
Copy link

Not sure if it is related, but even after removing the verbose option, provision is still failing.

Failed to upload a file to the guest VM via SCP due to a permissions
error. This is normally because the SSH user doesn't have permission
to write to the destination location. Alternately, the user running
Vagrant on the host machine may not have permission to read the file.

Source: #{my_dir}/saltstack/etc/minion
Dest: /etc/salt/minion

@wkral
Copy link
Contributor Author

wkral commented Jul 12, 2015

@cedricpim I just cooked up a simple example to start a brand new box without salt on it yet and got the same result as you.

I think the verbose option just exposed the problem as being that config value because it tries to print those install options to the console even if it's already installed. In any case the options aren't a string as they should be so installation fails.

@mitchellh
Copy link
Contributor

LGTM. Thanks!

mitchellh added a commit that referenced this pull request Jul 13, 2015
Fix salt bootstrap issue after 1.7.3 upgrade with verbose option set
@mitchellh mitchellh merged commit 39baec7 into hashicorp:master Jul 13, 2015
@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.7.3 cannot provision from salt
4 participants