Modify configure_networks to support udev's predicatable network interface names on Ubuntu/Debian #7253

hnakamur · 2016-04-23T19:10:09Z

This pull request is another try to fix to #7241 and #6871.
This is based on Add networking cap for Ubuntu guest by gMagicScott · Pull Request #6724 · mitchellh/vagrant and modified so that:

Use ip route | awk '$1=="default"{print $NF;exit}' to get the main_interface.
Use ls /sys/class/net | grep -v -E '^(lo$|docker|lxc)' to get available_interfaces then remove the main_interface from them.
Use if [/bin/cat /sys/class/net/#{interface}/operstate= up ]; then /sbin/ifdown #{interface} 2> /dev/null; fi to bring down a network interface.
Modify network interface templates to support both naming style like eth0 and enp0s8.
Use hostnamectl --static status to get the current hostname on distributions with systemd.

Tested with following Vagrantfiles.

Ubuntu Xenial with predicatable network interface names

Vagrant.configure(2) do |config|
  config.vm.box = "ubuntu/xenial64"
  config.vm.network "private_network", ip: "192.168.33.13"
end

Ubuntu Trusty with old network interface names

Vagrant.configure(2) do |config|
  config.vm.box = "ubuntu/trusty64"
  config.vm.network "private_network", ip: "192.168.33.9"
end

Debian Wheezy with old network interface names

Vagrant.configure(2) do |config|
  config.vm.box = "debian/wheezy64"
  config.vm.network "private_network", ip: "192.168.33.16"
end

Debian Jessie with old network interface names

Vagrant.configure(2) do |config|
  config.vm.box = "debian/jessie64"
  config.vm.network "private_network", ip: "192.168.33.17"
end

Tested with

Vagrant 1.8.1
VirtualBox 5.0.16
box versions
- debian/jessie64 (virtualbox, 8.4.0)
- debian/wheezy64 (virtualbox, 7.10.0)
- ubuntu/trusty64 (virtualbox, 20160406.0.0)
- ubuntu/xenial64 (virtualbox, 20160420.3.0)

Note you need to use VirtualBox 5.0.16, not the latest 5.0.18.
Bug #1573058 “Ubuntu 16.04 current not booting in Vagrant (gurum...” : Bugs : cloud-images

…rface names on Ubuntu/Debian

hnakamur · 2016-04-29T12:33:57Z

Confirmed ubuntu/xenial64 (virtualbox, 20160420.3.0) on Vagrant 1.8.1 with this patch works well with VirtualBox 5.0.20

hnakamur · 2016-05-02T07:52:16Z

I also created a patch for vagrant 1.8.1
https://gist.github.com/hnakamur/f23e35083bf60d5c573392bfdad94466

chrisvire · 2016-05-06T14:14:20Z

plugins/guests/debian/cap/configure_networks.rb

+              available_interfaces = data.chomp.split("\n") if type == :stdout
+            end
+            available_interfaces.delete(main_interface)
+            @logger.debug("debian configure_networks. available_interfaces=#{available_interfaces.inspect}")


Do you still need the debug logging? Should "require log4r" and logger references be removed?

@chrisvire I removed the debug logging. Thanks!

chrisvire · 2016-05-06T15:23:58Z

plugins/guests/ubuntu/cap/change_host_name.rb

@@ -6,6 +6,23 @@ def self.change_host_name(machine, name)
          super
        end

+        def initialize(machine, new_hostname)
+          super
+          @logger = Log4r::Logger.new("vagrant::plugins::guest")


Still some logging

ctrlrsf · 2016-05-09T19:15:14Z

plugins/guests/debian/cap/configure_networks.rb

+              main_interface = data.chomp if type == :stdout
+            end
+            available_interfaces = []
+            comm.execute("ls /sys/class/net | grep -v -E '^(lo$|docker|lxc)'") do |type, data|


Thanks for a good catch!
I add a commit to ignore ^lxd and another commit to ignore ^veth
7802c21

hnakamur · 2016-05-10T16:48:40Z

I also updated my patch for vagrant 1.8.1 to ignore network interfaces whose name matches the regex ^lxd, ^veth as well as ^lo$, ^docker and ^lxc
https://gist.github.com/hnakamur/f23e35083bf60d5c573392bfdad94466

sni · 2016-05-13T14:11:58Z

Using this patch makes my ubuntu12-04 vm hang on "Configuring and enabling network interfaces..."

rmoriz · 2016-05-16T18:56:25Z

plugins/guests/debian/cap/configure_networks.rb

+              main_interface = data.chomp if type == :stdout
+            end
+            available_interfaces = []
+            comm.execute("ls /sys/class/net | grep -v -E '^(lo$|docker|lx[cd]|veth)'") do |type, data|


somewhat related, CoreOS also uses systemd naming, maybe we want to unify it? https://github.com/mitchellh/vagrant/pull/6610/files

I think commas in the regex (e[n,t][h,s,p][[:digit:]]([a-z][[:digit:]])? in https://github.com/mitchellh/vagrant/pull/6610/files should be deleted to say the least.

PredictableNetworkInterfaceNames

systemd/udev-builtin-net_id.c at 25b0e6cb99c2a13c8f1ae9c5057f6941b722e764 · systemd/systemd

After reading the pages above, I think ^(en|eth) or ^e(n|th) would do for the whitelist approach.
However PredictableNetworkInterfaceNames says:

You create your own manual naming scheme, for example by naming your interfaces "internet0", "dmz0" or "lan0"

So I think the blacklist approach may be better.

On the other hand, you can change the network interface name for lxd from the default lxdbr0 to some other value. So the ideal way is detecting the type of network interfaces, not checking the names. But I had not found the way to do that, so I took the blacklist approach this time.

hnakamur · 2016-05-16T20:10:09Z

@sni Could you share your Vagrantfile? Did you use the patch for Vagrant 1.8.1 or for master?

sni · 2016-05-17T07:19:57Z

My Vagrantfile contains nothing special, except i create a bridged interface like:

config.vm.network "public_network", type: "dhcp", :bridge => "eth0"

klardotsh · 2016-06-01T21:55:23Z

Any word on this? There's been at least a few bug reports about this behavior and the PR has been outstanding for now literally months. I find it a little hard to believe this has sat for so long - private IP addresses on Xenial guests (my broken use case) can't be that rare, can they?

If there's anything I can do to test or build this (though I'm more a JS/Python guy than Ruby), please let me know. #7155 is an increasingly problematic bug for me and my team as we look to upgrade our infrastructure from Trusty to Xenial with local testing.

spotlightishere · 2016-06-02T01:23:14Z

Thank you so much for this patch, it took forever to find but finally ended my public network suffering!

domnulnopcea · 2016-06-02T08:46:59Z

is this going to be merged?

lobsterdore · 2016-06-04T20:05:33Z

This is a showstopper for a lot of people I think, the bug addressed by this fix is stopping me from adopting Xenial at all.

chasebolt · 2016-06-04T20:18:15Z

I would like to see this merged as well

endeavour · 2016-06-04T22:55:55Z

Me too

hnakamur added 3 commits April 24, 2016 03:45

Modify configure_networks to support udev's predicatable network inte…

249ed07

…rface names on Ubuntu/Debian

Update unit tests for Debian /etc/network/interfaces templates

f781e5f

Move a hostname test from debian-like system to debian

16b5f3c

sethvargo added this to the 1.8.2 milestone Apr 29, 2016

sethvargo added bug guest/ubuntu labels Apr 29, 2016

This was referenced May 6, 2016

Ubuntu 15.10 error when enabling network interfaces #6871

Closed

Handle new 'predictable' network interface naming style #7241

Closed

chrisvire reviewed May 6, 2016
View reviewed changes

Remove the debug logging

7205a1a

chrisvire reviewed May 6, 2016
View reviewed changes

Remove the debug logging in ChangeHostName

3496213

ctrlrsf reviewed May 9, 2016
View reviewed changes

Ignore lxd* network interfaces too

bf601e9

Also ignore veth network interfaces

7802c21

rmoriz reviewed May 16, 2016
View reviewed changes

spotlightishere mentioned this pull request Jun 2, 2016

Unable to set hostname on Ubuntu 16.04 box #7288

Closed

sethvargo mentioned this pull request Jun 6, 2016

Update guest capabilities #7393

Merged

sethvargo closed this in #7393 Jun 6, 2016

niklasf mentioned this pull request Jun 25, 2016

Require at least Vagrant 1.8.3 lichess-org/lila#2049

Merged

ghost locked and limited conversation to collaborators Apr 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify configure_networks to support udev's predicatable network interface names on Ubuntu/Debian #7253

Modify configure_networks to support udev's predicatable network interface names on Ubuntu/Debian #7253

hnakamur commented Apr 23, 2016 •

edited

Loading

hnakamur commented Apr 29, 2016

hnakamur commented May 2, 2016

chrisvire May 6, 2016

hnakamur May 6, 2016

chrisvire May 6, 2016

ctrlrsf May 9, 2016

hnakamur May 10, 2016 •

edited

Loading

hnakamur commented May 10, 2016 •

edited

Loading

sni commented May 13, 2016

rmoriz May 16, 2016

hnakamur May 16, 2016 •

edited

Loading

hnakamur commented May 16, 2016

sni commented May 17, 2016

klardotsh commented Jun 1, 2016 •

edited

Loading

spotlightishere commented Jun 2, 2016

domnulnopcea commented Jun 2, 2016

lobsterdore commented Jun 4, 2016

chasebolt commented Jun 4, 2016

endeavour commented Jun 4, 2016

Modify configure_networks to support udev's predicatable network interface names on Ubuntu/Debian #7253

Modify configure_networks to support udev's predicatable network interface names on Ubuntu/Debian #7253

Conversation

hnakamur commented Apr 23, 2016 • edited Loading

hnakamur commented Apr 29, 2016

hnakamur commented May 2, 2016

chrisvire May 6, 2016

Choose a reason for hiding this comment

hnakamur May 6, 2016

Choose a reason for hiding this comment

chrisvire May 6, 2016

Choose a reason for hiding this comment

ctrlrsf May 9, 2016

Choose a reason for hiding this comment

hnakamur May 10, 2016 • edited Loading

Choose a reason for hiding this comment

hnakamur commented May 10, 2016 • edited Loading

sni commented May 13, 2016

rmoriz May 16, 2016

Choose a reason for hiding this comment

hnakamur May 16, 2016 • edited Loading

Choose a reason for hiding this comment

hnakamur commented May 16, 2016

sni commented May 17, 2016

klardotsh commented Jun 1, 2016 • edited Loading

spotlightishere commented Jun 2, 2016

domnulnopcea commented Jun 2, 2016

lobsterdore commented Jun 4, 2016

chasebolt commented Jun 4, 2016

endeavour commented Jun 4, 2016

hnakamur commented Apr 23, 2016 •

edited

Loading

hnakamur May 10, 2016 •

edited

Loading

hnakamur commented May 10, 2016 •

edited

Loading

hnakamur May 16, 2016 •

edited

Loading

klardotsh commented Jun 1, 2016 •

edited

Loading