-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds support for Health Icons #74
adds support for Health Icons #74
Conversation
resolves mitchelloharawild#73 by adding support for the Health Icons set
I did a quick check of this, using it in a Shiny app and it seemed to work as expected! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for your contribution!
If you'd like, could you please add yourself to the DESCRIPTOIN as a ctb
author?
Thanks also for figuring out how to extend the package despite no extension documentation being written yet. Well done! 🎉
added myself to DESCRIPTION! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for your PR!
Resolves #73 by adding support for the Health Icons set. This adds the function
download_health_icons()
and the icon sethealth_icons
.Health Icons provide a single download file which is the most recent set of icons. It does not appear as though they have an archive for previous versions, so there is no version argument to
download_health_icons
It appears as though this is most similar to Google material for the way to search for icons, so I have copied that pattern. The following work:
health_icons("blood_bag")
health_icons("blood_bag", theme = "negative")
however, providing a category but no theme fails
health_icons("blood_bag", category = "blood")
Does this feel like it's in keeping with the rest of the package? Happy to make any changes necessary.