Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for Health Icons #74

Merged

Conversation

tomjemmett
Copy link
Contributor

Resolves #73 by adding support for the Health Icons set. This adds the function download_health_icons() and the icon set health_icons.

Health Icons provide a single download file which is the most recent set of icons. It does not appear as though they have an archive for previous versions, so there is no version argument to download_health_icons

It appears as though this is most similar to Google material for the way to search for icons, so I have copied that pattern. The following work:

  • health_icons("blood_bag")
  • health_icons("blood_bag", theme = "negative")
  • health_icons("blood_bag", category = "blood", theme = "negative")

however, providing a category but no theme fails

  • health_icons("blood_bag", category = "blood")

Does this feel like it's in keeping with the rest of the package? Happy to make any changes necessary.

@Moohan
Copy link

Moohan commented Aug 9, 2023

I did a quick check of this, using it in a Shiny app and it seemed to work as expected!

Copy link
Owner

@mitchelloharawild mitchelloharawild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution!
If you'd like, could you please add yourself to the DESCRIPTOIN as a ctb author?

Thanks also for figuring out how to extend the package despite no extension documentation being written yet. Well done! 🎉

R/health_icons.R Show resolved Hide resolved
R/health_icons.R Show resolved Hide resolved
R/health_icons.R Outdated Show resolved Hide resolved
@tomjemmett
Copy link
Contributor Author

added myself to DESCRIPTION! 🙂

Copy link
Owner

@mitchelloharawild mitchelloharawild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your PR!

@mitchelloharawild mitchelloharawild merged commit 61fdcd8 into mitchelloharawild:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for Health Icons
3 participants