Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] For artist's album Release-Type lists, please change "Unknown" to "Album" #31

Closed
troycarpenter opened this issue Aug 4, 2022 · 17 comments

Comments

@troycarpenter
Copy link

For a listing of an artist's albums, if there is no release-type defined, the heading for the section is "UNKNOWN"
image

In Ampache, the assumption is that in absence of the release-type, the type is "ALBUM"
image

Please change the "UNKNOWN" heading to "ALBUM" for those albums that do not include a release-type.

@troycarpenter
Copy link
Author

Also, I'm not sure but I think these are presented alphabetically. If not, I would like to have the "ALBUM" or "UNKNOWN" section listed first, since for most artists that's where the majority of their albums will be.

@mitchray
Copy link
Owner

mitchray commented Aug 5, 2022

The order is taken from Ampache's setting "Album - Group per release type sort" under Preferences >Interface > Library, so having "album,unknown,etc" will have them both be at the top

@mitchray
Copy link
Owner

mitchray commented Aug 5, 2022

I can see why Ampache would default to "album" for missing values, to cater to a wider audience who might not have properly tagged files

I would prefer to keep them separate to indicate the missing value however

@Jieiku
Copy link

Jieiku commented Aug 5, 2022

I also would prefer to keep them separate, that way should I ever notice it I can go back and fix the tags.

@troycarpenter
Copy link
Author

Yikes. Well, I have over 1800 albums, so I'm not planning to tag those. Where does Ampache even pull the release type field from? Is there an mp3 tag for that?

@Jieiku
Copy link

Jieiku commented Aug 5, 2022

I am not sure if it is an mp3 tag or not, but it seems when you add a catalog to Ampache you can use %r in the import pattern.

So I would say it is information that can be retrieved from Ampache's database, but no idea if Ampache can get this from tags as well as the import pattern.

Let me know if you find out if there is a specific mp3 tag for this.

I just noticed that ALL of my library shows Uknown under ample, I honestly had not even noticed it.

2022-08-04_20-15-19

@troycarpenter
Copy link
Author

troycarpenter commented Aug 5, 2022

When I have an album that I need to modify the release type, I edit the album one at a time in Ampache. So all this time I thought the default type was album, but I guess they were empty. I was only hand changing the release type for non-album releases.

@mitchray
Copy link
Owner

mitchray commented Aug 5, 2022

It depends on the file type but it appears MP3 is TXXX:MusicBrainz Album Type

If you use something like MusicBrainz Picard (definitely) or Foobar/MP3Tag (presumably) it will handle the correct type for your file

Or you can disable the grouping in Ampache altogether by disabling "Album - Group per release type"

@troycarpenter
Copy link
Author

I am not sure if it is an mp3 tag or not, but it seems when you add a catalog to Ampache you can use %r in the import pattern.
2022-08-04_20-15-19

That implies the release type is encoded in the track filename and can be used to inport into the database, not that there's an mp3 field for it.

@troycarpenter
Copy link
Author

It depends on the file type but it appears MP3 is TXXX:MusicBrainz Album Type

If you use something like MusicBrainz Picard (definitely) or Foobar/MP3Tag (presumably) it will handle the correct type for your file

Or you can disable the grouping in Ampache altogether by disabling "Album - Group per release type"

Good to know about that tag.

And the grouping is useful to keep compilations and other release types out of the regular album releases list.

@Jieiku
Copy link

Jieiku commented Aug 5, 2022

That implies the release type is encoded in the track filename and can be used to inport into the database, not that there's an mp3 field for it.

OR that the release type is part of the directory structure.

@Jieiku
Copy link

Jieiku commented Aug 5, 2022

Thanks @mitchray I disabled the "Album - Group per release type" and now it no longer shows UNKNOWN, just had to check the box apply to all when I did it.

@troycarpenter
Copy link
Author

It depends on the file type but it appears MP3 is TXXX:MusicBrainz Album Type

If you use something like MusicBrainz Picard (definitely) or Foobar/MP3Tag (presumably) it will handle the correct type for your file

Or you can disable the grouping in Ampache altogether by disabling "Album - Group per release type"

I found a Compilation album that was showing up on an artist page. I added the tag "MUSICBRAINZ_ALBUMTYPE" set to "Compilation" to the songs and updated the tags in Ampache. The album now shows up under the Compilation section of the artist's album listing.

I don't normally embed the Musicbrainz tags, but I'll look into it. 30k songs to retag yet again. Seems like my life is all about retagging music files.

@Jieiku
Copy link

Jieiku commented Aug 5, 2022

Thank you for sharing the tag name, I can probably work that into my bash script that handles my tagging. I see there is also a tag "RELEASETYPE" I wonder if I used that for the tag if it would work on my mp3's, will give it a try when I find the time.

@troycarpenter
Copy link
Author

troycarpenter commented Aug 5, 2022

I'm trying Picard which pulled in lots of extra tags (most I don't really care about). What I didn't like is that it messed with the track numbers and disc numbers. I need to see if there's a way to protect those fields.

I'm not a purist. I like my track numbers padded, and on multi-disc releases I sequentially number all the tracks and eliminate the disk numbers so they all appear in a single list without artificial disc separation. I know, anathema to some.

@Jieiku
Copy link

Jieiku commented Aug 5, 2022

Ah.. I have the disc number in the filenames so that I can put all the tracks in a single album folder with the correct order, then my bash script properly sets the disc number and track number in the actual tags:
2022-08-05_08-20-04

@troycarpenter
Copy link
Author

I've started down the rabbit hole of Musicbrainz tagging. I'm about half done (mostly the mainstream music). I've found my taste in music is a bit off the beaten path and I've had to submit not a few albums to existing artists, as well as create new artists and add their albums. Picard makes that rather painless, though. I also don't agree with how some of the albums / tracks are tagged. I think some people submitted entries in the past before understanding how they should be entered (or maybe it's a preference thing).

What I'm now dealing with are all the cross-artist tags that didn't exist before. It's nice to have links between guest artists and such, but it does change slightly how I interface with my music. Not worse, just different and maybe better in finding other tracks on which an artist appears. It's also interesting to see how Ampache uses the MB tags vs. MP3 tags in database and display choices. It mostly leans on MP3 tags for display purposes, while MB tags create database relationships between artists.

@mitchray mitchray closed this as not planned Won't fix, can't repro, duplicate, stale Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants