add SignupPopover to learning resource drawer bookmark button #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… learning resource drawer user list button
shanbady
approved these changes
Sep 17, 2024
| @@ -124,6 +134,7 @@ const ResourceListCard: React.FC<ResourceListCardProps> = ({ | |||
| condensed, | |||
| ...props | |||
| }) => { | |||
| const loc = useLocation() | |||
There was a problem hiding this comment.
It seems like there is a lot of redundancy between ResourceCard and ResourceListCard that could potentially be abstracted/consolidated.
| @@ -86,6 +87,10 @@ const Certificate = styled.div` | |||
| height: 16px; | |||
| } | |||
| ` | |||
| // The SignupPopover needs to display over the top of the resource drawer | |||
| const StyledSignupPopover = styled(SignupPopover)({ | |||
| zIndex: 9999, | |||
There was a problem hiding this comment.
it would be good to avoid the hardcoded zIndex if at all possible (realizing this might be the only workaround for now)
shanbady
added
Waiting on author
and removed
Needs Review
…me to the default mui value for the drawer, then take that value plus one for popover
|
@shanbady Thanks for the review. I've addressed your two concerns above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5505
Description (What does it do?)
This PR adds some functionality that was missed in #1537. If you are logged out, the bookmark button should still show in the learning resource drawer. When clicking this button, the same "signup popover" that shows when you click the bookmark button on the card show show.
Screenshots (if appropriate):
How can this be tested?
mit-learn