fixing compose mount #818
Merged
fixing compose mount #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
approved these changes
Apr 24, 2024
This was referenced Apr 24, 2024
Closed
Closed
Closed
jonkafton
added a commit
that referenced
this pull request
Apr 24, 2024
This reverts commit 80292a4.
jonkafton
added a commit
that referenced
this pull request
Apr 25, 2024
…d errors (#825) * Revert "Remove package manager config (#823)" This reverts commit f03ed4b. * Revert "Set engines to instruct Heroku to install yarn (#821)" This reverts commit f44a4f2. * Revert "Deployment fixes for static frontend on Heroku (#819)" This reverts commit 07243ec. * Revert "fixing compose mount (#818)" This reverts commit 80292a4. * Revert "Move hash.txt location to frontend build directory (#815)" This reverts commit e0d9e01. * Revert "Build front end to make available on Heroku (#813)" This reverts commit fc06462. * Revert "Self contained front end using Webpack to build HTML and Webpack Dev Server to serve (#678)" This reverts commit dafcf94.
jonkafton
pushed a commit
that referenced
this pull request
Apr 25, 2024
jonkafton
added a commit
that referenced
this pull request
May 1, 2024
* Webpack HTML plugin and dev server config * adding v1 current user view and updated tests * adding updated frontend api client and openapi spec * removing v1 api for profiles * updating api spec * Move frontend package root into ./frontends * Static assets * Webpack configuration and container for build/watch mode and dev server / watch mode * The web service no longer needs to wait for healthy watch service * Working directory for yarn commands * Move TS and Jest config into frontends * Fix eslint paths * GH Actions working directories * actions/setup-node working directory * Add yarn releases to version control * Fix version mismatches * Fetch user session dynamically from new endpoint * Fetch user hook. Update RestrictRoute tests. * Update tests for asynchronous user fetch / react query hook. Mocks responses or sets on query cache * Yarn v4 needs --all to iterate workspaces. Update e2e_test job paths * Run openapi steps in frontends * Run openapi steps in root * Add github-pages to workspaces * Fix syncpack mismatches * Upgrade dependencies for yarn 4 * Static file paths for nginx. Working directory for e2e tests. * Image path for python test and e2e tests working directory * Install step for e2e dependencies * Put back Dockerfile * README notes for frontend development modes * Spelling * Ignore .yarn files outside of releases * Wait for user loaded before rendering route Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Sync eslint versions * Update tests to not depend on first render or inject to query cache * Route /_features to the web service * Readme pointer. Remove dev server to prod API package scripts * Install immutable * Serve Webpack within the watch container for Hot Module Replacement * Add Django REST framework static assets paths to correctly render API docs * Remove the trailing slash on nginx matcher for /admin * Webpack plugin to enable HMR for React. Serve local watch on 8062 * Load env vars from .env file in Webpack config * Webpack versions * Update README notes * README tweak * Nginx config for Heroku - Configures Ngnix for to serve static front end files in /frontends/mit-open/build - Falls back to index.html for SPA routes - Sets 1m expires header for index.html (we want a short cache on this as it will be overwritten during release) - Removes the CORS * header (we shouldn't need this on file responses) - Proxies known API routes to the uwsgi worker * Spelling on filename * Remove root lockfile * Upload front end build artifact and pull during release * Fix paths * Upload step ignores job working directory * Build front end to make available on Heroku * Move hash.txt location to frontend build dir * Disable E2E test job * Known path for hash file * Build dir for version hash file * Webpack to not clear build files in production mode * Package.json at root for Heroku NodeJS buildpack * Remove frontend build from release jobs * Set engines to instruct Heroku to install yarn * Remove package manager config * fixing compose mount (#818) * Root package workspace for Heroku install/build * Exclude frontends (previous root) workspace from typecheck * Temp workflow * Match yarn version * Regenerate lockfile * Fix branch ref * Add yarnrc file * Yarn release file * Move watch container build context for package root * Revert "Move watch container build context for package root" This reverts commit 69d749b. * Upgrade to yarn 4.1.1 * Remove frontend yarn files * Docker compose config for root context * Script entrypoints for CI and run in project root * Working directories * Fix typecheck error on CI. Stray line (cat)? * Comments E2E test report mv step * Test set yarn version * Tests are running in frontends root - remove global: scripts * Frontends working directory. Remove test RC deploy workflow * Test entry for correct path resolution * Lock React and @testing-library dependencies (conflict on React 18.3.0). Increase timeouts on slow running tests * Sync @types/react version * Lint fix extraneous deps * Run tests from root * Move watch mount to root. Add the storybook server back in * Install node modules in container * Copy static assets for Storybook * Script at root to run watch * Installs git and mounts repo for Jest in watch mode. Stylelint config moved to frontends so available inside container --------- Co-authored-by: shankar ambady <ambady@mit.edu> Co-authored-by: Chris Chudzicki <christopher.chudzicki@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shankar Ambady <shanbady@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (What does it do?)
Adds the local src mount for the web container
How can this be tested?
do a
docker-compose downfollowed bydocker-compose up. make a change to some python file. then get into the web container viadocker-compose exec -ti web /bin/bashand see that whatever change that was made persists in the container.