Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup external_marketing_url field from CourseRun model #2636

Closed
arslanashraf7 opened this issue Apr 27, 2023 · 4 comments
Closed

Cleanup external_marketing_url field from CourseRun model #2636

arslanashraf7 opened this issue Apr 27, 2023 · 4 comments
Assignees

Comments

@arslanashraf7
Copy link
Contributor

Description

In #2628 we migrated external_marketing_url from CourseRun model into Courseware model in CMS. We could not remove these fields in the original PR because the data migration depends on it. So this has to be a separate PR that should be merged once the original PR is live in Production.

Expected Behavior

  • external_marketing_url field from CourseRun is removed along with any of its possible usages
@arslanashraf7 arslanashraf7 added the Bug Something isn't working label Apr 27, 2023
@arslanashraf7 arslanashraf7 self-assigned this Apr 27, 2023
@arslanashraf7 arslanashraf7 added product:xpro and removed Bug Something isn't working labels Apr 27, 2023
@cachob
Copy link

cachob commented May 3, 2023

@arslanashraf7 I noticed that the values in this field did not port over to the CMS field. The external url fields in the CMS are all blank:

https://xpro.mit.edu/cms/pages/506/edit/
image

Is there way to backfill these fields?

@arslanashraf7
Copy link
Contributor Author

@arslanashraf7 I noticed that the values in this field did not port over to the CMS field. The external url fields in the CMS are all blank:

When I checked, I could see the values back filled e.g. for https://xpro.mit.edu/cms/pages/408/edit/. Was there a value set for this in the course run?

Is there way to backfill these fields?

We can manually backfill them.

@cachob
Copy link

cachob commented May 3, 2023

My mistake - I was looking at the course page for this course and not the program page: https://xpro.mit.edu/cms/pages/381/edit/

@arslanashraf7
Copy link
Contributor Author

Closing, Deployed on prod via #2639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants