Jk/hubspot sync

[jklingen92]

This PR is waiting on 3 things:

• Merge PR Registration form - Step 2 #236
• Define hubpost contact properties on the mitxpro hubspot application
• Decide whether to run a full contact sync at regular intervals or implement live updating. This could be done by extending the save method on the User object

Pre-Flight checklist

• Screenshots and design review for any changes that affect layout or styling
  • Desktop screenshots
  • Mobile width screenshots
  • Tag @Ferdi or @pdpinch for review
• Migrations
  • Migration is backwards-compatible with current production code
• Testing
  • Code is tested
  • Changes have been manually tested
• Settings
  • New settings are documented and present in app.json
  • New settings have reasonable development defaults, if applicable

What are the relevant tickets?

#275
#236

What's this PR do?

Add celery tasks to sync contacts with hubspot.

How should this be manually tested?

You could run it in ipython, make a change to a user, and then run the task manually as opposed to through celery. Then check that the update was made on Hubspot.

Where should the reviewer start?

users/tasks

Any background context you want to provide?

(Optional)

Screenshots (if appropriate)

(Optional)

What GIF best describes this PR or how it makes you feel?

[codecov-io]

Codecov Report

Merging #291 into master will decrease coverage by 0.06%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   94.42%   94.35%   -0.07%     
==========================================
  Files         159      161       +2     
  Lines        5343     5388      +45     
  Branches      311      319       +8     
==========================================
+ Hits         5045     5084      +39     
- Misses        242      245       +3     
- Partials       56       59       +3

Impacted Files	Coverage Δ
users/models.py	98.73% <ø> (ø)	⬆️
users/exceptions.py	100% <100%> (ø)
mitxpro/settings.py	92.73% <100%> (+0.04%)	⬆️
users/tasks.py	86.04% <86.04%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb796eb...b310730. Read the comment docs.

[Ferdi]

@jklingen92 you should find a way to embed the gif , not just a link - too much work !

[mbertrand]

This line doesn't seem to be covered by unit tests, can you add one? Probably need to create & use a ProfileFactory class and include it as part of UserFactory:
profile = RelatedFactory("users.factories.Profile", "user")

Not sure if it's relevant or not, but it seems like Hubspot contacts can have state/region and country fields, those would need to be obtained from the LegalAddress model if they need to be synced with Hubspot too.

[jklingen92]

@mbertrand This is what I was asking about regarding the Profile Model. Should that be added as a part of this PR?

[mbertrand]

Yes if you need any of the fields stored in Profile to also be saved in Hubspot contacts, which seems likely. Ditto for LegalAddress. @pdpinch or @Ferdi which fields should be synced? Issue #275 doesn't explicitly specify any as far as I can see, but edx syncs the following: first name, last name, company, job title, state, country, gender, degree.

[mbertrand]

Any update on these?:

Define hubpost contact properties on the mitxpro hubspot application
Decide whether to run a full contact sync at regular intervals or implement live updating. This could be done by extending the save method on the User object

[jklingen92]

Any update on these?:
Define hubpost contact properties on the mitxpro hubspot application
Decide whether to run a full contact sync at regular intervals or implement live updating. This could be done by extending the save method on the User object

@Ferdi @pdpinch I'm planning on imitating the Profile model and extending the profile save function.

[mbertrand]

@jklingen92 should this PR be closed?