-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jk/hubspot ecommerce sync #319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 94.22% 94.03% -0.19%
==========================================
Files 168 170 +2
Lines 5695 5771 +76
Branches 330 342 +12
==========================================
+ Hits 5366 5427 +61
- Misses 270 280 +10
- Partials 59 64 +5
Continue to review full report at Codecov.
|
@mbertrand The hubspot link you sent won't open. It seems to be infinitely appending an id into the URL... What hubspot app are you testing with? Have you run the management command to configure the bridge? |
1c40bec
to
ae8e016
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
I don't recall if this will be your first PR merge or not, in case it is please squash all commits into one before merging.
Initial task files Add ecommerce bridge sync Add product mapping, sync in user serializer Add management command to configure settings, add stubs for other models Run black, fix UserSerializer / ProfileSerializer interaction Fix parameter error and simplify tests Fix fake data, add urllib, stub model id params Fix function calls Add unit tests for task functions Remove created_on from sync, fix urls Url bug Fix test parametrization
331c1d7
to
602fb80
Compare
Some change to User in this PR is causing 2 authentication pipeline tests to fail. I need to look into this.
Pre-Flight checklist
app.json
What are the relevant tickets?
#276 #18 #291
What's this PR do?
Add management command
configure_hubspot_bridge
to install and manage hubspot ecommerce bridge, addhubspot_api.py
with utilities for making requests to hubspotHow should this be manually tested?
Use the hubspot API and the management command to configure hubspot settings.
Where should the reviewer start?
(Optional)
Any background context you want to provide?
Screenshots (if appropriate)
(Optional)
What GIF best describes this PR or how it makes you feel?
(Optional)