Jk/hubspot ecommerce sync #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 94.22% 94.03% -0.19%
==========================================
Files 168 170 +2
Lines 5695 5771 +76
Branches 330 342 +12
==========================================
+ Hits 5366 5427 +61
- Misses 270 280 +10
- Partials 59 64 +5
Continue to review full report at Codecov.
|
mbertrand
requested changes
May 21, 2019
mbertrand
requested changes
May 21, 2019
mbertrand
reviewed
May 21, 2019
|
@mbertrand The hubspot link you sent won't open. It seems to be infinitely appending an id into the URL... What hubspot app are you testing with? Have you run the management command to configure the bridge? |
jklingen92
force-pushed
the
jk/hubspot_ecommerce_sync
branch
from
1c40bec
to
ae8e016
Compare
mbertrand
requested changes
May 21, 2019
mbertrand
approved these changes
May 21, 2019
Initial task files Add ecommerce bridge sync Add product mapping, sync in user serializer Add management command to configure settings, add stubs for other models Run black, fix UserSerializer / ProfileSerializer interaction Fix parameter error and simplify tests Fix fake data, add urllib, stub model id params Fix function calls Add unit tests for task functions Remove created_on from sync, fix urls Url bug Fix test parametrization
jklingen92
force-pushed
the
jk/hubspot_ecommerce_sync
branch
from
331c1d7
to
602fb80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some change to User in this PR is causing 2 authentication pipeline tests to fail. I need to look into this.
Pre-Flight checklist
app.jsonWhat are the relevant tickets?
#276 #18 #291
What's this PR do?
Add management command
configure_hubspot_bridgeto install and manage hubspot ecommerce bridge, addhubspot_api.pywith utilities for making requests to hubspotHow should this be manually tested?
Use the hubspot API and the management command to configure hubspot settings.
Where should the reviewer start?
(Optional)
Any background context you want to provide?
Screenshots (if appropriate)
(Optional)
What GIF best describes this PR or how it makes you feel?
(Optional)