Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fin 6/7 Facts are not Replaced in the Commands #19

Closed
omkarbhat1995 opened this issue Jul 8, 2021 · 4 comments
Closed

Fin 6/7 Facts are not Replaced in the Commands #19

omkarbhat1995 opened this issue Jul 8, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@omkarbhat1995
Copy link

Describe the bug
When running the Operation for Adversary for FIN 6/7, the commands that are being executed are wrong. In these commands the facts file is supposed to be used to replace the traits with corresponding values but that's not happening.

To Reproduce
Steps to reproduce the behavior:

  1. Enabled Emu plugin.
  2. Created the operation with FIN 6/7 Adversary and then added FIN6 facts file

Expected behavior
The traits are supposed to be replaced by the corresponding values in the commands.

Screenshots
The facts for FIN6:
image
The command that's being executed:
image
The facts for FIN7
image
The command that's being executed:
image

@omkarbhat1995 omkarbhat1995 added the bug Something isn't working label Jul 8, 2021
@omkarbhat1995 omkarbhat1995 changed the title Fin 6 Facts are not Replaced in the Commands Fin 6/7 Facts are not Replaced in the Commands Jul 8, 2021
@alexanderkent alexanderkent assigned emmanvg and unassigned wbooth Jul 8, 2021
@alexanderkent
Copy link

Thanks for taking the time to report this issue and the screenshots are very helpful too -- we are looking into this and will follow-up.

@emmanvg
Copy link
Contributor

emmanvg commented Jul 20, 2021

Hi @omkarbhat1995, if you are running version 3.1.0 of CALDERA there is a line here that expects facts to be in a.b.c format. The emu plans facts do not follow this pattern, hence why the facts are not being replaced.

Note that this no longer the case since the master branch in CALDERA already has changes to such condition and should behave as expected. Options:

  1. This change will be available in the next release if you need a stable release.
  2. Alternatively if you are developing for CALDERA you could try the master branch (may not be stable) and use the changes.
  3. You could also change all the facts to follow a three phase trait (for example, fin7.host.domain) to fulfill the requirements for version 3.1.0.

Hope this helps, sorry for the late reply!

@emmanvg
Copy link
Contributor

emmanvg commented Jul 23, 2021

@omkarbhat1995 I will close this issue since there is no further action given the current state of caldera. If you feel this issue has not been addressed feel free to reopen. Thanks!

@emmanvg emmanvg closed this as completed Jul 23, 2021
@egg-mayo-sandwich
Copy link

Hi @omkarbhat1995, were you able to resolve this issue in the end? I faced the same issue, and I've tried using the master branch but my sandcat agent on my Windows VM keeps timing out, so I'm not sure if that is because the master branch may be unstable. wanted to check if you resolved the FIN6 facts issue another way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants