New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to supported alternative to pycrypto? #6

Closed
clarkbreyman-yammer opened this Issue Jun 29, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@clarkbreyman-yammer
Copy link

clarkbreyman-yammer commented Jun 29, 2016

Pycrypto has not been updated in 2 years with a fairly long list of open pull requests. There are alternatives:
-- using pycryptodome (less desirable due to conflict with pycrypto install)
-- using pycryptodomex and modifying the imports from Crypto to Cryptodomex
-- using cryptography and modifying more code

@mitya57

This comment has been minimized.

Copy link
Owner

mitya57 commented Jun 30, 2016

Thanks for the suggestions, I will definitely look at them.

@mitya57 mitya57 closed this in e637c3b Jul 4, 2016

@mitya57

This comment has been minimized.

Copy link
Owner

mitya57 commented Jul 4, 2016

I have now migrated to cryptography in Git. If you could test it, it would be much appreciated!

@lmazuel

This comment has been minimized.

Copy link

lmazuel commented Jul 4, 2016

Hi @jaraco, since you directly use secretstorage in keyring, do you think you can check if the new dependency here is working with keyring?
I'm actually an really far indirect user of secretstorage (4 levels of dependencies...), I'm not sure I'm the right person to do that...

@jaraco

This comment has been minimized.

Copy link

jaraco commented Jul 5, 2016

I don't actually use Linux keyring on a regular basis. If I were to test this, I would have to start with a fresh VM and install the Python dependencies by hand and secret storage from Git... And I still wouldn't have any existing passwords to test. So I can't be of much help here.

@mitya57

This comment has been minimized.

Copy link
Owner

mitya57 commented Jul 5, 2016

I have ran the python-keyring tests against the new source and they pass.

@lmazuel

This comment has been minimized.

Copy link

lmazuel commented Aug 17, 2016

Hi @mitya57
I don't think you made a new release here? Do you still need help for the testing?
Thanks!

@mitya57

This comment has been minimized.

Copy link
Owner

mitya57 commented Aug 17, 2016

Hi @lmazuel, a new release uploaded!

@lmazuel

This comment has been minimized.

Copy link

lmazuel commented Aug 17, 2016

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment