Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up continuous deployment #11

Open
rusheb opened this issue Feb 24, 2023 · 4 comments
Open

Set up continuous deployment #11

rusheb opened this issue Feb 24, 2023 · 4 comments
Assignees

Comments

@rusheb
Copy link
Collaborator

rusheb commented Feb 24, 2023

The release process is a bit clunky. We should sort it out.

We can probably just copy what TransformerLens does

Some extra resources:

@rusheb rusheb changed the title Set up Continuous Deployment Set up continuous deployment Feb 24, 2023
@rusheb rusheb self-assigned this Feb 24, 2023
@rusheb
Copy link
Collaborator Author

rusheb commented Feb 24, 2023

Looking into this further, dunder version is not working in TransformerLens:

>>> import transformer_lens
>>> transformer_lens.__version__
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'transformer_lens' has no attribute '__version__'

@mivanit how important is this?

I found this thread containing a number of suggestions I could try

@rusheb
Copy link
Collaborator Author

rusheb commented Feb 24, 2023

@mivanit quick update - this is blocked because I can't upload a pypi token to the repository secrets.

Please can you do this?

https://docs.github.com/en/actions/security-guides/encrypted-secrets

@mivanit
Copy link
Owner

mivanit commented Feb 24, 2023

I think we can set the version with:

  • ship the pyproject.toml and have __version__ in __init__.py set from reading the toml file
  • __version__ = pkg_resources.get_distribution("muutils").version (although I'm not sure you can do this from inside the package you are currently in)

I've uploaded a pypi token as the creatively named PYPI_TOKEN in the repo secrets

@rusheb
Copy link
Collaborator Author

rusheb commented Mar 1, 2023

Documenting the current release process here:

  • update __version__ in __init.py__
  • update version in pyproject.toml
  • create tag
  • push tag (e.g. git push origin 0.2.1)
  • poetry publish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants