Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when lease lost, lease state is not revoked #52

Closed
zyf0330 opened this issue Dec 27, 2017 · 2 comments
Closed

when lease lost, lease state is not revoked #52

zyf0330 opened this issue Dec 27, 2017 · 2 comments
Assignees
@connor4312
Labels
bug

Comments

@zyf0330
Copy link

zyf0330 commented Dec 27, 2017

https://github.com/mixer/etcd3/blob/05b85c3e4085a0bb00a1c4ff7684935b6b2a1b61/src/lease.ts#L247

Hello, I think logic here is not correct. After lost is emitted, this.close() is called and this.state = State.Revoked is set, so when on('lost') lease.revoked() === false.
@connor4312 connor4312 mentioned this issue Dec 29, 2017
Merged
@connor4312 connor4312 self-assigned this Dec 29, 2017
@connor4312 connor4312 added the bug label Dec 29, 2017
@connor4312
Copy link
Member

Fixed in #53

@connor4312
Copy link
Member

Published in 0.2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@connor4312 @zyf0330