Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest.deny filter change no longer matches docs and breaks deny() #40

Open
nevf opened this issue Jun 11, 2018 · 1 comment
Open

suggest.deny filter change no longer matches docs and breaks deny() #40

nevf opened this issue Jun 11, 2018 · 1 comment

Comments

@nevf
Copy link

nevf commented Jun 11, 2018

The commit bcf518b changed the blacklist deny test from < to <= which disagrees with the docs http://mixu.net/minilog/filter.html

This configures the default filter to hide logs where the level is < 'warn'. 

I don't understand why this change was made as you can no longer use:

Minilog.suggest.deny(/mymodule\/.*/, 'debug');

to filter out debug items etc.

@roark
Copy link
Contributor

roark commented Feb 7, 2019

The documentation is out of date but the ability to deny debug logs should still work.

Currently:
filter.deny() will deny the log level specified and below.
filter.allow() will allow the log level specified and above.

The code given should work, I've tested it locally and able to deny debug level logs. Can you post an example of the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants