refactor: avoid temporary qlist allocation on midi sysex receive

#12827 (comment)
mixxxdj · Mar 1, 2024 · 3718cc0 · 3718cc0
1 parent 4203158
commit 3718cc0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/controllers/midi/midicontroller.cpp b/src/controllers/midi/midicontroller.cpp
@@ -1,6 +1,7 @@
 #include "controllers/midi/midicontroller.h"
 
 #include <QJSValue>
+#include <algorithm>
 
 #include "control/controlobject.h"
 #include "controllers/defs_controllers.h"
@@ -518,10 +519,11 @@ void MidiController::receive(const QByteArray& data, mixxx::Duration timestamp)
         }
     }
 
-    const auto inputMappings = m_pMapping->getInputMappings().values(mappingKey.key);
-    for (const auto& inputMapping : inputMappings) {
+    const auto [inputMappingsBegin, inputMappingsEnd] =
+            m_pMapping->getInputMappings().equal_range(mappingKey.key);
+    std::for_each(inputMappingsBegin, inputMappingsEnd, [&](const auto& inputMapping) {
         processInputMapping(inputMapping, data, timestamp);
-    }
+    });
 }
 
 void MidiController::processInputMapping(const MidiInputMapping& mapping,