refactor(controllers): send sysex to all handlers #12827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thank you! |
|
Thank you. |
daschuer
reviewed
Feb 18, 2024
| auto it = m_pMapping->getInputMappings().constFind(mappingKey.key); | ||
| for (; it != m_pMapping->getInputMappings().constEnd() && it.key() == mappingKey.key; ++it) { | ||
| processInputMapping(it.value(), data, timestamp); | ||
| const auto inputMappings = m_pMapping->getInputMappings().values(mappingKey.key); |
There was a problem hiding this comment.
values() returns a fresh allocated QList()
https://github.com/qt/qtbase/blob/adc0920c48d812fb1b3e2b7bfc76217a7126a41e/src/corelib/tools/qhash.h#L1088C38-L1088C63
This happens for every message and should be avoided.
There was a problem hiding this comment.
Damn, I tought the QMultiHash was using them internally and just returned an implicitly-shared copy. I should've checked.
@Swiftb0y can we find a solution that does not allocate memory?
I didn't at first, but I just found it now, It's https://doc.qt.io/qt-6/qmultihash.html#equal_range. PR underway.
|
@Swiftb0y can we find a solution that does not allocate memory? |
Swiftb0y
added a commit
to Swiftb0y/mixxx
that referenced
this pull request
Feb 18, 2024
m0dB
pushed a commit
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I noticed while digging through #12824, probably a bug, but its masked by the unintuitive behavior described in #12824 anyways. Potentially proper fixes for #12824 to come.