Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDJ toggle not working with Denon DJ MC7000 in 2.3.3 #10754

Closed
mixxxbot opened this issue Aug 23, 2022 · 51 comments
Closed

AutoDJ toggle not working with Denon DJ MC7000 in 2.3.3 #10754

mixxxbot opened this issue Aug 23, 2022 · 51 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: thomi
Date: 2022-06-23T15:42:06Z
Status: New
Importance: Undecided
Launchpad Issue: lp1979670
Attachments: [Developer Logs for MC7000 and MK2](https://bugs.launchpad.net/bugs/1979670/+attachment/5599452/+files/Developer Logs for MC7000 and MK2), mixxx_build_error.png


Kubuntu 20.04
Intel i7, 8x4Core
Mixxx 2.3.3
Denon DJ MC7000, mapping integrated by OsZ

Have upgraded to latest 2.3.3, thanks to the Mixxx Team.

If MC7000 is connected and configured, i can't start AutoDJ.
Click on AutoDJ button, nothing happens.
If MC7000 not connected, AutoDJ working like normal.

I also dont find any error if start mixxx from console.

If any more info needed, let me know.

Regards
thomi

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-06-23T22:48:11Z


The AutoDJ toggle in the GUI doesn't work?
Or a controller button?

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-06-24T06:16:19Z
Attachments: [Developer Logs for MC7000 and MK2](https://bugs.launchpad.net/mixxx/+bug/1979670/+attachment/5599452/+files/Developer Logs for MC7000 and MK2)


Hello

Yes, AutoDJ toggle in the GUI not working if Denon DJ MC7000 is connected.
Also if pressing Shift+F12 to toggle AutoDJ it does not start.
All other features do work so far..

I also have a Hercules DJ Console MK2 and with this controller, AutoDJ does work like usual.

Attached are developer logs for both controller.
In the one for the MC7000 (denon_dj_mc7000_20220604.log) and if toggling AutoDJ, no log entries created.
For the Herecules controller (hercules_dj_console_mk2_20220604.log), if toggling AutoDJ, you will see log entries starting on line 790.

Hope this helps to identify the issue.

Thanks & regards
thomi

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-06-24T09:38:32Z


Currently i downgraded to mixxx 2.3.2-1~focal and AutoDJ toggle is back and running with connected Denon DJ MC7000.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-06-27T20:52:35Z


Looking at the MC7000 mapping files, I have no clue how there could be a connection between that and AutoDJ.

Just to double check:
with either of those two controllers you have

  • an output device configured = you can load and play tracks?
  • there's at least one existing track in the AutoDJ queue?

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-06-28T07:42:48Z


Hey ronso0

with either of those two controllers you have

  • an output device configured = you can load and play tracks?

Yes, if working with 2.3.3, then i can do manual DJing, load and play tracks like usual.
With connected MC7000, AutoDJ not working...
With connected Hercules MK2, AutoDJ is working normal...

  • there's at least one existing track in the AutoDJ queue?

Yes, tested with tracks and with the option that AutoDJ adds automatic tracks, if empty..
MC7000 > AutoDJ not working...
Hercules MK2 > AutoDJ working normal

As above wrote, with 2.3.2 AutoDJ works like a charm,e ven with MC7000 and with Hercules MK2.

@mixxxbot
Copy link
Collaborator Author

Commented by: toszlanyi
Date: 2022-06-28T08:33:46Z


Interesting, as I never integrated any AutoDJ functions in the mapping... Cannot see any issue related to the last changes at #4755 as well but maybe worth a try to copy the 2.3.2 mapping to the personal folder and test it while using Mixxx v2.3.3 just to make sure.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-06-28T09:34:14Z


Yeah, worth testing the old mapping.

Though I suspect this is a regression caused by the recent AutoDJ fixes. Maybe related to Vol fader or crossfader position? Idk..

@thomi Can you please try to replicate the working state (with Herc Mk2) with the MC7000?
Like, when you intent to start AutoDJ, ensure that Vol faders, the crossfader and decks' crossfader assign switches are in exact same position as with the Hercules.

@daschuer may know

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-06-28T11:36:53Z


Okey, what i did...

  1. purged ~/.mixxx (backed it first)

  2. upgraded to 2.3.3

  3. connected MC7000

  4. started Mixxx and selected library music source

  5. prefs > controller > MC7000 built in mapping

  6. prefs > sound > set MC7000 as master (channel 1-2) and headphone (channel 5-6), as usual

crossfader state: centered
vol. fader for chan. 1/2 on bottom (0%)

  1. added some sound into AutoDJ

  2. set vol. faders for chan. 1/2 to 100%

AutoDJ will not change the channel faders, but that's normal i think

  1. started AutoDJ

Result > nothing happens

crossfader and chan. vol. faders no change

Downgraded to 2.3.2 and did the same as above

crossfader works automatic, as usual
Result > all works like it should

Tested the same with MK2 in 2.3.2 and 2.3.3
result > all works in any version like it should

regards
thomi

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-07-08T06:25:13Z


Hello

Any news in this?
If more information needed, let me know...

Many thanks
thomi

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-07-10T13:39:36Z


There where significant changes between 2.3.2 and 2.3.3 to the Auto DJ code.

You may try out the PR builds to find out which one introduces the regression:

#4693
https://github.com/mixxxdj/mixxx/actions/runs/1977602517

#4714
https://github.com/mixxxdj/mixxx/actions/runs/2104229820

#4698
https://github.com/mixxxdj/mixxx/actions/runs/2296452415

#4768
https://github.com/mixxxdj/mixxx/actions/runs/2375737188

The builds are on the bottom of the second link. You to be logged in on GitHub to see the links.

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-08-09T05:56:11Z


Good morning

Thanks for reply, sorry for my late reply.. holiday time ;)

I tried to download the DEB builds, but could only download it for:
https://github.com/mixxxdj/mixxx/actions/runs/2375737188

All others are expired.

The build from your links i can download is mixxx-2.4-alpha-1164-g0a9b879186.deb

after 2.3.3 will 2.4 come or is there a plane for eg. 2.3.4?

thomi

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-08-09T07:07:49Z


I think we will release a last 2.3.x version somewhere close to a 2.4.0 version.

Do you have any new test results, with the available builds?

Maybe I find time to create you a test version with more log output to drill down the issue.

Are you able to build Mixxx from source?
https://github.com/mixxxdj/mixxx/wiki/Compiling-On-Linux

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-08-10T09:24:35Z


hey

should be able to build it from source.. try it ;)

using main branch or 2.3 to build and test it?

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-08-10T10:21:36Z


Yes, later I can point you to commits that can be tested.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-08-14T21:00:36Z


Did you manage to build Mixxx from source?

The relevant commits are:
597e23d
4d1f111
889108a
7643517

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-08-18T08:18:34Z
Attachments: mixxx_build_error.png


hey

. checked out main branch
. installed dependency with "tools/debian_buildenv.sh setup"
. run needed build command based on https://github.com/mixxxdj/mixxx/wiki/Compiling-On-Linux

error see attachment..

i'm on zorin os 16.1 which is based on ubuntu...

any hint?

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-08-18T09:12:13Z


got it... needed to checkout the mentioned commit...

let me build for those 4 commits and check on my system...

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2022-08-18T09:45:34Z


The build error happens due to dropping focal support from our main branch.
You may merge
https://github.com/daschuer/mixxx/tree/focal_main
To keep the main building

git pull <email address hidden>:daschuer/mixxx.git focal_main 

I just realize realized that Zorin OS has not jet updated to Ubuntu 22.04 LTS base.
They have just anonced to release it V 17. mid-2023 :-(

@mixxxbot
Copy link
Collaborator Author

Commented by: thomi
Date: 2022-08-19T08:53:53Z


hey hey

sorry, can't build it correctly for my dj'ing system and also don't find time to analyse, debug it deeply... hm...

If i have DEB files, i could test it faster ;)

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2022-08-19T10:06:54Z


I managed to build main on 20.04 with gcc10
For details checkout https://mixxx.zulipchat.com/#narrow/stream/247620-development-help/topic/Deprecating.20ubuntu.2020.20early/near/293636016
so we can stays on topic here

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@thomich
Copy link

thomich commented Sep 2, 2022

okey.. thanks @ronso0, will continue here ;)

let's re-post my last comment, cause it's not posted here...

okay.. found time to build with gcc9 and installed it..

controller and all shortly tested features work..
BUT AutoDJ still same problem.. nothing happens on SHIFT+F12 or even click to the AutoDJ toggle button.

built the deb file on focal based on:
https://github.com/daschuer/mixxx/tree/focal_main

Mixxx 2.4.0-alpha-pre
Git Version: 99b1b94 (focal_main)
Date: Montag, 15. August 2022 08:17:24 CEST
Platform: Linux x86_64

Now i lost my workin 2.3.2 :(.... and have to build it manually.. or is there any download for this file:
mixxx_2.3.2-1_focal_amd64.deb

regards
thomi

@daschuer
Copy link
Member

daschuer commented Sep 2, 2022

Unfortunately all our resources for that version have expired.
It was here: https://launchpad.net/~mixxx/+archive/ubuntu/mixxx/+build/23109813
You may build it on your own or better lets fix your issue.

You click the Auto DJ toggle button and you have Tracks in the queue, right?

Is there a difference if the controller is connected or not?

@thomich
Copy link

thomich commented Sep 2, 2022

You click the Auto DJ toggle button and you have Tracks in the queue, right?

yes sure

Is there a difference if the controller is connected or not?

yes, if controller not connected or i connect my hercules mk2 controller, AutoDj does work!

@ronso0
Copy link
Member

ronso0 commented Sep 5, 2022

@thomich If you managed to built 2.3 and main with cmake you can easily checkout the commits @daschuer pointed to (#10754 (comment)) and test with which commit the behaviour changes.

If that's not feasible for you we can create a branch with debug output in AutoDJProcessor and try to track the issue from there.

@thomich
Copy link

thomich commented Sep 8, 2022

okidoki ;)

have build deb's for the different commits.. and the result ;)

  1. 2.3.2-10-g597e23d580 - OK 597e23d
  2. 2.3.2-15-g4d1f1119d1 - OK 4d1f111
  3. 2.3.2-25-g889108a98b - AutoDJ not working 889108a

So now.. @ronso0 or even @daschuer , it's your turn ;)

regards
thomi

@ronso0
Copy link
Member

ronso0 commented Sep 9, 2022

What about your crossfader assign switches?
For deck 1 & 3 they should be set Left, for decks 2 & 4 Right. This is initial state after start.
Do states of those buttons change when you (started with MC7000 disabled) enable it in the preferences?

@thomich
Copy link

thomich commented Sep 12, 2022

Sorry.. i don't exact know what you mean...

do you mean this switches?

2.3.2
image

2.3.2-25-g889108a98b
image

Else, please explain what information you need.

@ronso0
Copy link
Member

ronso0 commented Sep 12, 2022

Yes, exactly that.
If those are centered the respective deck(s) are in 'throughput' mode, i.e. they will always be audible regardless of the crossfader position.
AutoDJ fades with the crossfader, thus it needs at least one left deck (xfader switch LEFT) and one right deck.
With all xfader switches centered it will refuse to start for obvious reasons.

Please test again with xfader switches at default position (deck 1/3: left, deck 2/4: right).
Did you set the switches manually? Does the position on the controller match the position in the GUI?

@thomich
Copy link

thomich commented Sep 13, 2022

good morning...

think i found the issue, problem...

First, the switches do work in all tested versions if i change them on the MC7000.

With 2.3.2 and 2.3.2-15-g4d1f1119d1 AutoDJ works even if crossfader switches are centered or for 1 left and 2 right.
Also if i manually crossfade over the MC7000, the AutoDJ will automatically take next track to the deck, no matter what position the switches have.

With 2.3.2-25-g889108a98b AutoDJ can only be started if the crossfader switches are NOT centered: 1 left, 2 right or vise versa.

The AutoDJ toggle an all older versions including 2.3.2-15-g4d1f1119d1 do work even if crossfader switches are centered or left/right.

But starting with 2.3.2-25-g889108a98b AutoDJ only works if crossfader switches are left or even right, based on the channel/deck.

Hope this helps to identify and fix the problem as it was in previous versions.

regards
thomi

@daschuer
Copy link
Member

How does AutoDJ work for you with centered crossfader setting?
I can imagine to popup a message Box that tells the users to fix the Deck alignment first.
Will this help you?

@thomich
Copy link

thomich commented Sep 13, 2022

hey @daschuer

In earlier versions, it just worked with centered position...can't that be adapted in new versions?

@daschuer
Copy link
Member

If there is a valid use case for this, sure.
Please explain yours.

@thomich
Copy link

thomich commented Sep 13, 2022

Use case:
. it worked before 2.3.2-25-g889108a98b
. it's easy to start AutoDJ without also changing any switches.

If a DJ by default is working w/o crossfader, there is no need to change the crossfader switch from center to left/right.

In my case i mostly work w/o crossfader and do the mixes direct with the channel faders.

thx

@ronso0
Copy link
Member

ronso0 commented Sep 13, 2022

If a DJ by default is working w/o crossfader

..then s/he is working with Volume faders and/or EQs to blend tracks manually.

For the time being, AutoDJ works with crossfader only. With both decks in through mode (xfader switch centered) there will be no crossfader blending. So I guess you either use it with no transition at all, or you interfere with the EQs / Vol fader?
Do you simply need AutoDJ to load tracks and start them in time? Please describe your use case in more detail.

What are the arguments for considering the "non-auto AutoDJ" use case?
Saying "it worked before" is no argument because it did not work without the fix for quite a few users (AutoDJ stopped unintentionally).

For now, I agree with @daschuer to show a popup explaining that AutoDJ requires the crossfader switches set left & right, and also add that info to the manual. That would at least avoid confusion.

@thomich
Copy link

thomich commented Sep 13, 2022

okey.. no problem for me, so following would be best solution then:

For now, I agree with @daschuer to show a popup explaining that AutoDJ requires the crossfader switches set left & right, and also add that info to the manual. That would at least avoid confusion.

many thanks...

@ronso0
Copy link
Member

ronso0 commented Sep 13, 2022

again: please explain how you use AutoDJ so we can understand your use case.

@thomich
Copy link

thomich commented Sep 13, 2022

okey.. ;)

If i need a break, i add some tracks into autodj queue or even set some crates and start autodj to make my break...
Sometimes on w'end, i start my broadcast, add some crates or even some wishes from my listeners into autodj queue and start the autodj.

With 2.3.2 it was easy, just add some tracks, enable creats and start autodj, nothing else (expect fader volume of deck 1&2 to 100%).

thomi

@ronso0
Copy link
Member

ronso0 commented Sep 13, 2022

how do you configure transitions?

@thomich
Copy link

thomich commented Sep 13, 2022

that the settings for AutoDJ...

Screenshot_20220913_134647

and

Screenshot_20220913_134858

don't know, if it's that what you mean..

if not, please specify what i have to go to get information you need.
i also can provide any debug information, or config file, if i have specific instructions..

i want help, but need points, where to get what..

@ronso0
Copy link
Member

ronso0 commented Sep 13, 2022

Yes, I meant the AutoDJ controls in the library.
So you just overlap the songs by 6s without any fading. That obviously makes sense only with songs that have an own intro/outro fade, otherwise the overlap is a mess and destroys either the outro, intro or both.

@thomich
Copy link

thomich commented Sep 13, 2022

If i understand it correct, it does auto fade automatically.. means left channel volume fades out trough the crossfader and right channel fades in, and the duration is 6 seconds, based on that setting.

@ronso0
Copy link
Member

ronso0 commented Sep 13, 2022

That's what it would do if the crossfader switches where set to left / right. If both are centered, there's no fading.

@thomich
Copy link

thomich commented Sep 13, 2022

but again, sorry for that, but that worked in earlier version's, it fades down/up even if crossfader switches are centered.

so what now? make a message box, if crossfader switches not left/right?

@ronso0
Copy link
Member

ronso0 commented Sep 13, 2022

it fades down/up even if crossfader switches are centered.

can not confirm.
If you can reproduce that it's a bug.
I'd love to see a video of that:

  • no audio, just the mixer section: 4 decks, Vol faders all up, no external sources (no mic, no aux, no vinyl passthrough)
  • play a track on deck1 ( a section/loop that is 'loud', i.e. VU meter is constantly at sth. like 80-90%)
  • select a soft mixing crossfader curve in the preferences
  • main VU goes down as you move the crossfader from the leftmost position to the rightmost position??

@thomich
Copy link

thomich commented Sep 14, 2022

good morning ;)

hope this will explain and show how it works with 2.3.2 and MC7000 controller with built in mapping.

Mixxx 2.3.2 - AutoDJ Constant Power Fading
https://watch.screencastify.com/v/VnH0a0WF77yZiiGm90hO

Mixxx 2.3.2 - AutoDJ Soft Fading
https://watch.screencastify.com/v/TCFmRkfNtRc9HEvYqke9

IMG_20220914_045633
IMG_20220914_045639
IMG_20220914_045645

And a video of the MC7000 while AutoDJ on 2.3.2 is working:
https://www.dropbox.com/s/3kro9ddyx8r4160/Mixxx%202.3.2%20and%20MC7000.mp4?dl=0

If you think that is a bug in 2.3.2 it is solved with cf switches position left/right.. but then we need a message box, if starting AutoDJ and cf switches are centered.

@ronso0
Copy link
Member

ronso0 commented Sep 15, 2022

Mixxx 2.3.2 - AutoDJ Soft Fading
https://watch.screencastify.com/v/TCFmRkfNtRc9HEvYqke9

See how the VU jumps up at ~0:22 when deck2 kicks in?
I'm afraid we have different understanding of fading.

To clarify, please try to simply record this as described, not with AutoDJ (also the left deck's outro is faded out already).

  • play a track on deck1 (a section/loop that is 'loud', i.e. VU meter is constantly at sth. like 80-90%)
  • no track in deck2!
  • select a soft mixing crossfader curve in the preferences
  • move the crossfader manually from the leftmost position to the rightmost position??

Thank you

@thomich
Copy link

thomich commented Sep 15, 2022

hope i understand your correct...

with 2.3.2 i needed to set cf switches to left/right to get cf manually working:

Mixxx 2.3.2 - Soft Fading - cf switch left right
https://watch.screencastify.com/v/wzD4DOpAZz8umPVF0Rf0

@ronso0
Copy link
Member

ronso0 commented Sep 15, 2022

with 2.3.2 i needed to set cf switches to left/right to get cf manually working

this should be the case, and that's the point I'm trying to make:
you need to set xfader switches to either side - with centered switch the xfader has no effect on the channel volume.

so, with centered switches there won't be crossfade effect with AutoDJ either, unless your tracks are fading in / out.
Thus, it's pointless to enable AutoDJ if xfader switches are centered.

@ronso0
Copy link
Member

ronso0 commented Sep 15, 2022

Closing this now. Feel free to reopen if there is a valid use case.

@ronso0 ronso0 closed this as completed Sep 15, 2022
@thomich
Copy link

thomich commented Sep 15, 2022

my friend.. all fine for me

but now, do you add a message box if clicking on AutoDJ toggle and cf switches are centered?

@ronso0
Copy link
Member

ronso0 commented Sep 15, 2022

#10903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants