-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undesired jump-cuts in auto DJ #4693
Conversation
const double introEndSample = pToDeck->introEndPosition(); | ||
if (introEndSample != Cue::kNoPosition) { | ||
const double introEnd = samplePositionToSeconds(introEndSample, pToDeck); | ||
if (introStart < introStart) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups, I have messed up the rebase.
I will rebase again.
@@ -0,0 +1,99 @@ | |||
#include "util/file.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this temporary file and force push
This happened because the track is not able to seek exactly to the intro start point. In this case taking the start point as end point does not lead to a zero length intro.
Done |
Done |
@Swiftb0y: anything else left to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand how the fix works but I suppose this works...
This commit contains the fix: |
Merge? |
I'm concerned about this commit: 49819ef |
This was just a refactoring for readability without effect. |
Ah, makes sense, I missed that. |
Thank you. |
This fixes https://bugs.launchpad.net/mixxx/+bug/1948975
The also improves the logging in auto DJ in the first commits, disabled by the sDebug.
This is IMHO a major bug that rectifies a 2.3.3 release.
Hopefully we can also fix the issue https://bugs.launchpad.net/mixxx/+bug/1893197