fix(controllers): Numark N4 inverted pitch slider #11057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have access to the hardware to test the fix? |
|
Not anymore no, but I'm the author of the original mapping. Also the fix seems to make sense since all of the numark hardware I encountered so far has inverted tempo sliders. I trust the original author of the fix to have properly tested their changes. |
|
@LeonTheOriginal Can you confirm this PR still fixes your issue? |
|
This basically reverts: We have the same in these Numark mappings: https://github.com/mixxxdj/mixxx/blob/main/res/controllers/Numark-Mixtrack-Platinum-scripts.js#L596 https://github.com/mixxxdj/mixxx/blob/main/res/controllers/Numark_DJ2GO2_Touch_scripts.js#L98 https://github.com/mixxxdj/mixxx/blob/main/res/controllers/Numark%20MIXTRACK.midi.xml#L284 So I guess it is correct. |
|
Thank you for picking this up. |
|
Thank you for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10813
rebased #10918 on 2.3 and fixed pre-commit
Thank you @LeonTheOriginal for raising the issue.