Library Layout Redesign Single pane

[daschuer]

Hi this is a continuation of #991 and #1115 with the changes made and to do:

• Single pane visualization
• Fix bug with playlists
• Fix merge conflicts @jmigual
• polish Auto DJ pane
• Auto DJ crate icon is not colored @daschuer
• Deere's preview player is not recognizable as "player" if it is empty
• No filter (Search) in browse feature
• crasher changing from browse to library view (not reproducible for now)
• playlists feature shows the IDs instead of the name when you select that feature
• rename browse feature
• rename library feature Icon update #1119

[daschuer]

conflicts resolved.

[ronso0]

It crashes trying to switch to Tango now

It appears to be related to waveforms: if I exclude everything waveform related it runs fine.
I'll try to figure out what's wrong.

[ronso0]

Last warning I see before it crashes:
Warning [Main]: QPaintDevice: Cannot destroy paint device that is being painted

[ronso0]

Apart from that, pretty much everything is super slow the first few minutes after start:
startup itself, skin change, 1st track load, analysis when loading a track, shutdown

[ronso0]

Apart from that, pretty much everything is super slow the first few minutes after start

Seems to be caused by my large library, with a clean profile everything is as fast as with previous lib-redesign builds.

[ronso0]

Deere crashes when I try to

• toggle stacked waveforms
• show 4 decks
• show samplers

It does NOT crash when I manually set the samplers visible in config, then start Mixxx and toggle them on/off/on/off. However, it DOES crash when I try to change the number of sampler rows.

Good thing: shutdown of Deere with 64 samplers is as quick as the 16-samplers version (with all 64 samplers manually enabled in cfg and ~20 samplers loaded) so we may revert the respective skin hack when the above issues are solved.

[Be-ing]

@ronso0 vector images for the library icons are in res/images/templates/ic_template_library_and_preferences.svg. If you could take care of replacing the PNG images with SVGs that would be nice. The PNG icons look blurry on my screen.

[ronso0]

@Be-ing Yes, I can take care of the icons. Do you the reason some of them are offset to the left?

[Be-ing]

'Load track to deck X' only works in Tracks view, not in Crates, Playlists & History.

I'm not sure what you mean. Loading tracks via the right click context menu works fine in all features for me. However, the LoadSelectedTrack and LoadSelectedTrackAndPlay ControlObjects don't do anything.

Mixxx crashes when I issue [Library],GoToItem

I can reproduce this.

Mixxx crashes when I right-click into empty scroll area in AutoDJ > Track source

Fixed in #1720

These are the only remaining merge blockers, correct? Is there anything I am missing?

[ronso0]

'Load track to deck X' only works in Tracks view, not in Crates, Playlists & History.

I'm not sure what you mean. Loading tracks via the right click context menu works fine in all features for me. However, the LoadSelectedTrack and LoadSelectedTrackAndPlay ControlObjects don't do anything.

Yes, I referred to the COs used by controllers

These are the only remaining merge blockers, correct? Is there anything I am missing?

What about

The UI sluggishness is way more severe than I remember

IMO this renders Mixxx pretty much useless with a large library

[Be-ing]

The GUI sluggishness was fixed by #1714.

It looks like [Library], GoToItem was broken by merging master after #1560 was merged to master. I'm quite confused what the code for LibraryControl::slotGoToItem should be at this point and the code in this branch in general is really confusing. I can't even tell what code classes correspond to what I see on screen.

[Be-ing]

Travis reports that the macOS build is broken.

[uklotzde]

Next try with a clean build based on Qt5 (5.10.1), pulling the latest changes from master.

Unfortunately the same results as reported earlier. I experience an extended startup time and even more severe lags during operation. The UI is very sluggish when browsing the library or selecting tracks and freezes for an extended period of half a minute or even longer when loading tracks. Sorry, but this is totally unusable. It is not sufficient to test with a fresh and almost empty database containing just a few thousand tracks.

I strongly recommend NOT merging these changes until at least the major usability issues have been fixed. We won't be able to fix any serious design flaws when discovered during the beta phase. I suppose there are some.

[Be-ing]

@uklotzde did you test upstream/jmigual-library-redesign or @daschuer's branch? It looks like @daschuer has not merged the recent fixes into his branch yet.

[Be-ing]

I am closing this in favor of #1726 to avoid such confusion going forward.