Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): improve mono-compatibility for Rubberband R3. #11418

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

Swiftb0y
Copy link
Member

Fixes #11361

Huge thanks to @atskler for noticing the issue and reporting it to us and upstream, as well as @cannam for doing the actual hard work of fixing the problem.

@Swiftb0y Swiftb0y added this to the 2.4.0 milestone Mar 30, 2023
@Swiftb0y Swiftb0y force-pushed the feat/rubberband3-mono-compat branch from 2046ea7 to ae537d5 Compare March 30, 2023 14:42
@daschuer
Copy link
Member

daschuer commented Mar 30, 2023

I have issued a PR against upstream VCPK to update to rubberband 3.2.0

microsoft/vcpkg#30551

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@atskler Can you confirm that this change is sufficient?

@atskler
Copy link

atskler commented Mar 30, 2023

Can you confirm that this change is sufficient?

First my distro/repo should update rubberband to v3.2, after that I can check it.

@ronso0
Copy link
Member

ronso0 commented Mar 30, 2023

Can you confirm that this change is sufficient?

First my distro/repo should update rubberband to v3.2, after that I can check it.

My distro will never get R3 so I built it myself:
https://github.com/breakfastquay/rubberband/tree/r3
git checkout v3.2.0
meson build && ninja -C build install
Had to move the two headers to /usr/include/rubberband/ though

@atskler
Copy link

atskler commented Mar 30, 2023

My distro will never get R3

My will get it as it is a rolling release distro.
Anyways will Mixxx require minimum Rubberband v3.2 as a dependency for building it?

@Swiftb0y
Copy link
Member Author

Swiftb0y commented Mar 30, 2023

Anyways will Mixxx require minimum Rubberband v3.2 as a dependency for building it?

No, the resulting sound will just not be mono-compatible with a lower rubberband version.

@daschuer
Copy link
Member

Ok than let's merge it. Thank you for all the testing.

@daschuer daschuer merged commit 9d50fba into mixxxdj:2.4 Mar 30, 2023
@Swiftb0y Swiftb0y deleted the feat/rubberband3-mono-compat branch March 30, 2023 23:32
@atskler
Copy link

atskler commented Apr 2, 2023

Rubberband 3.2 is available for my distro so I built Mixxx and checked it and it solved the problem.

napaalm pushed a commit to napaalm/mixxx that referenced this pull request Jul 10, 2023
…compat

feat(engine): improve mono-compatibility for Rubberband R3.
napaalm pushed a commit to napaalm/mixxx that referenced this pull request Jul 10, 2023
…compat

feat(engine): improve mono-compatibility for Rubberband R3.
napaalm pushed a commit to napaalm/mixxx that referenced this pull request Jul 10, 2023
…compat

feat(engine): improve mono-compatibility for Rubberband R3.
napaalm pushed a commit to napaalm/mixxx that referenced this pull request Jul 10, 2023
…compat

feat(engine): improve mono-compatibility for Rubberband R3.
napaalm pushed a commit to napaalm/mixxx that referenced this pull request Jul 11, 2023
…compat

feat(engine): improve mono-compatibility for Rubberband R3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants