iTunes: Move path mapping logic into XML importer and clean up slightly #11446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daschuer since you already have an itunes testing setup, would you like to test this PR as well or can we be sure enough to work by looking at the code changes? |
|
We should probably add a unit test for an iTunes XML so we can refactor safely without having to worry as much about regressions. But I'd move that to a future PR too. |
|
Moving forward. Regressions can be filed during beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for cleaner separation of concerns, since the path mapping is not needed in the macOS importer (and potentially others in the future). Also, since the mapping is applied by the XML importer itself, having the iTunes feature own it at a higher level doesn't really prove beneficial.