Preferences: use helper for input widget scroll safeguard #11663
Conversation
ronso0
force-pushed
the
pref-scroll-safeguard
branch
2 times, most recently
from
b7c2aa0
to
e1a5dce
Compare
|
This is ready for review. |
Avoid undesired value changes when scrolling a preferences page while the pointer is above an input widget (QSpinBox, QComboBox, QSlider): * set the focus policy to Qt::StrongFocus (focusable by click & tab key) * forward wheel events to the top-level layout
ronso0
force-pushed
the
pref-scroll-safeguard
branch
from
e1a5dce
to
3348692
Compare
| continue; | ||
| } | ||
|
|
||
| QComboBox* combo = qobject_cast<QComboBox*>(ch); |
There was a problem hiding this comment.
We use a p prefix for pointers.
| @@ -47,6 +47,8 @@ DlgPrefBeats::DlgPrefBeats(QWidget* parent, UserSettingsPointer pConfig) | |||
| &QCheckBox::stateChanged, | |||
| this, | |||
| &DlgPrefBeats::slotReanalyzeImportedChanged); | |||
|
|
|||
| setScrollSafeGuard(comboBoxBeatPlugin); | |||
There was a problem hiding this comment.
can we effort to use here setScrollSafeGuardForAllInputWidgets(this); to not forget new elements if we add any?
There was a problem hiding this comment.
I assume setting the scroll guard per widget is faster than using setScrollSafeGuardForAllInputWidgets which iterates over all dialog children, do an object cast etc.
To keep preferences construction (startup) fast I chose the per-widget function if there are only a few affected input widgets.
I didn't measure the impact though, maybe the difference is negligible.
For this page it probably doesn't make a big difference since there are only a few widgets.
There was a problem hiding this comment.
I don't have a strong opinion here. It can stay like this if you like.
|
I'll add the p prefix and remove obsolete Let me know when you intend to start reviewing DlgPrefVinyl, so I can squash that beforehand. |
ronso0
force-pushed
the
pref-scroll-safeguard
branch
from
3348692
to
e804319
Compare
fixed and rebased. |
This moves the existing safeguards (I started with #2941) to helpers in DlgPreferencePage and uses it in the other pages as well.
Btw, am I the only who's annoyed by this hover scroll issue? or is just that we have too many big pref pages that require scrolling even on large screens so the issue is relevant at all?
The helper iterates over all dialog children and install the safeguard for input widgets.
There's also a per-widget helper if a page only has a few widgets.
Unfortunately, this doesn't work for QGroupBoxes.
But before I found a way to deal with this, I already started reworking
DlgPrefVinylto store the input widgets in lists (and simplified the entire page code, and fixed an init bug¹, and added proper tabstops)... so this page is pretty much rewritten with widget lists. There are now quite some lines to review in that page. I didn't want to throw away that work so I finished it. If no one wants to review that I can move that commit to a separate PR (and maybe isolate the init bugfix, too).¹on show, the lead-in time for non existing config values was set to 0 instead of the default time that is picked when selecting a VC type.