(fix) apply macOS style to dynamically added sliders, too

[ronso0]

Closes #12630

@idcmp Please test with the CI build, see https://github.com/mixxxdj/mixxx/wiki/Testing for instructions.

[daschuer]

@idcmp do you think you will find time to test this this weekend? Than it can be part of the 2.4.0 release.

Or can we just merge it without confirm?

[idcmp]

Hi! Sorry, I'm playing all weekend and too chicken to fiddle with things right now. The soonest I would feel safe to tackle this is Monday.

[fwcd]

UI lgtm. Can confirm that the sliders feel "glitchy" though:

Screen.Recording.2024-01-27.at.23.09.29.mov

[JoergAtGithub]

UI lgtm. Can confirm that the sliders feel "glitchy" though:

In your video they look broken

[fwcd]

Yeah, maybe I phrased it wrong, I meant that the sliders look fine, but controlling them still doesn't feel quite right. Is this a macOS-only problem though? This feels like there's something wrong with the way the "view state" is synchronized with the "model" (I have no idea how the internals work here, so forgive me if I use the wrong terms here)

[fwcd]

Ah, maybe I should've looked closer, there are some visual glitches there too..

[daschuer]

How does controlling works main 2.3.6 and 2.3.4 beta? Let's go for a solution that behaves right, even it may looks broken.

[daschuer]

On Ubuntu Focal 2.4, main and this branch look the same.

[ronso0]

Hi! Sorry, I'm playing all weekend and too chicken to fiddle with things right now. The soonest I would feel safe to tackle this is Monday.

@idcmp You can test PR builds without risk, just keep the installer of your current version and backup your settings/database: https://github.com/mixxxdj/mixxx/wiki/Testing

[fwcd]

2.3 feels fine

Screen.Recording.2024-02-01.at.14.30.18.mov

Interestingly, the main branch with Qt 6 feels fine too:

Screen.Recording.2024-02-01.at.14.32.09.mov

Just 2.4 has some odd issues (perhaps because it still uses our hacked together Qt 5 build?):

Screen.Recording.2024-02-01.at.14.33.39.mov

[daschuer]

I think the best solution would be to put the maximum number of expected slider to the ui file and just change the labels and hide the unused sliders.

[daschuer]

@fwcd Can you check if this one is causing the flipping of the sliders:
#11663

[ronso0]

Oh, that one.
If that's the cause we can simply not apply that to the main EQ sliders. They're at the bottom of the page and the scroll-while-hovering aka catch unintended scroll events is much less likely there.

[daschuer]

@fwcd
I have prepared #12711 with a static set of sliders.
Please check if they are also affected from the style and control glitch.
If not I will continue that route for a fix.

[daschuer]

Since this does not we work, can we close it?

[fwcd]

I think so and, if this is indeed a Qt bug as I suspect, we'd probably be better off patching it in the buildenv. See #12711 (comment)

[ronso0]

Yup, you can just backport the fix.
IIUC we can also revert #11647 then.