Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WTrackProperty: double-clicked property field is focused in DlgTrackInfo #11764

Merged
merged 1 commit into from
Jul 26, 2023
Merged

WTrackProperty: double-clicked property field is focused in DlgTrackInfo #11764

merged 1 commit into from
Jul 26, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jul 25, 2023 •
edited
Loading

A little helper for tag editing:

  • double-click [property] label to open Track Info
  • if there is a line edit for [property] it is focused, start typing

@ronso0 ronso0 force-pushed the track-info-focus-double-clicked-field branch from 05ff687 to 95c8d88 Compare July 25, 2023 20:58
daschuer
daschuer requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trick works here, left some comments.

src/library/dlgtrackinfo.cpp Outdated Show resolved Hide resolved
src/library/dlgtrackinfo.h Outdated Show resolved Hide resolved
@ronso0
WTrackProperty: double-clicked property field is focused in DlgTrackInfo
2a8651a 
so the workflow is now:
* double-click [property] label to open Track Info
* [property] line edit is focused, start typing
@ronso0 ronso0 force-pushed the track-info-focus-double-clicked-field branch from 95c8d88 to 2a8651a Compare July 26, 2023 20:49
@ronso0 ronso0 mentioned this pull request Jul 26, 2023
Merged
5 tasks
daschuer
daschuer approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than you.

@daschuer daschuer merged commit b28b0dc into mixxxdj:2.4 Jul 26, 2023
11 checks passed
@ronso0 ronso0 deleted the track-info-focus-double-clicked-field branch July 26, 2023 21:52
@ronso0
Copy link
Member Author

ronso0 commented Jul 26, 2023

TODO
document double-click in the manual

@ronso0 ronso0 mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
gui library ui usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronso0 @daschuer