Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO Renaming (Pt. 4): VU Meter Controls #12021

Merged
merged 10 commits into from Sep 27, 2023
Merged

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Sep 24, 2023

Part of #11931.

@Holzhaus Holzhaus added this to the 2.4.0 milestone Sep 24, 2023
@Holzhaus Holzhaus changed the title CO Renaming (Pt. 4): Mixer Controls CO Renaming (Pt. 4): VU Meter Controls Sep 24, 2023
@Holzhaus Holzhaus marked this pull request as ready for review September 24, 2023 22:02
@Holzhaus Holzhaus marked this pull request as draft September 24, 2023 22:29
@daschuer
Copy link
Member

daschuer commented Sep 26, 2023

We have an issue that our VU-Meter is no VU-Meter

The current Mixxx VU meter is somewhere between a paek meter and a VU meter, offering a reasonable one fits all type, unfortunately not comparable to other devices or any standard scale.
See: #7888

Can we use a better name?

@Holzhaus Holzhaus marked this pull request as ready for review September 26, 2023 17:43
@Holzhaus
Copy link
Member Author

Can we use a better name?

Do you have a suggestion?

Though I think this is not really an issue and we may add support for different modes later on that can be changed in the settings, so its rather future-proof :)

@daschuer
Copy link
Member

https://en.m.wikipedia.org/wiki/VU_meter

For my feeling the "VU Meter" for volume units is kind of deprecated. But the term is widely used.
If we decide to make it a more recent LUFS meter, the term would be wrong, also if we make it a peak indicator of the digital scale.

I have looked around how DJ controller named it and found "audio meter" and "level meter".
Not sure if this is better to understand.

@Holzhaus
Copy link
Member Author

Well, level_indicator or level_meter is okay and pretty generic. On the other hand, it may be confusing because it's not really google-able. The wiki article on "Sound Level Meter" mostly refers to microphones: https://en.wikipedia.org/wiki/Sound_level_meter

@JoergAtGithub
Copy link
Member

Let's stay with standard terms

@daschuer
Copy link
Member

Ok, then let's stick with the old.

@JoergAtGithub
Copy link
Member

LGTM! Thank you!

@JoergAtGithub JoergAtGithub merged commit 53f3b07 into mixxxdj:2.4 Sep 27, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants