Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO Renaming (Pt. 6): Mixer Controls [WIP] #12023

Draft
wants to merge 8 commits into
base: 2.4
Choose a base branch
from

Conversation

Holzhaus
Copy link
Member

Part of #11931.

Based on #12021 and #12022.

@Holzhaus Holzhaus added the control objects Issues and bugs specifically in regard to mixxx `ControlObjects` label Sep 24, 2023
@Holzhaus Holzhaus added this to the 2.4.0 milestone Sep 24, 2023
@Holzhaus Holzhaus changed the title CO Renaming (Pt. 6): Mixer Controls CO Renaming (Pt. 6): Mixer Controls [WIP] Sep 24, 2023
@Holzhaus Holzhaus force-pushed the mixer-controls-pt2 branch 2 times, most recently from 1afecfb to 1ee18ec Compare October 7, 2023 23:38
Copy link

github-actions bot commented Jan 6, 2024

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jan 6, 2024
@daschuer
Copy link
Member

daschuer commented Jan 6, 2024

What is the state of this PR? Is it still a 2.4 candidate?

@github-actions github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Jan 7, 2024
@ywwg
Copy link
Member

ywwg commented Jan 8, 2024

CO renaming has been causing regressions in controller configs so I would prefer to bump this to 2.4.1 or 2.5

@daschuer
Copy link
Member

daschuer commented Jan 8, 2024

Than it is 2.5, because 2.4.1 is a bugfix release.

@ronso0 ronso0 modified the milestones: 2.4.0, 2.5.0 Jan 8, 2024
@ronso0
Copy link
Member

ronso0 commented Feb 18, 2024

I removed the draft state since dependencies have been merged.

@ronso0
Copy link
Member

ronso0 commented Feb 18, 2024

@Holzhaus 4eda619 is merge of main, think I fixed all conflicts correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality control objects Issues and bugs specifically in regard to mixxx `ControlObjects` controller backend library skins ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants