Skins: path tweaks and log cleanup #12482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
requested changes
Dec 30, 2023
src/skin/skinloader.cpp
Outdated
|
|
||
| // Fallback to default skin as last resort | ||
| const QString defaultSkinName = getDefaultSkinName(); | ||
| DEBUG_ASSERT(!defaultSkinName.isEmpty()); | ||
| pSkin = getSkin(defaultSkinName); | ||
| VERIFY_OR_DEBUG_ASSERT(pSkin && pSkin->isValid()) { | ||
| qWarning() << "Failed to load default skin" << defaultSkinName; | ||
| qWarning() << "Can find default skin" << defaultSkinName; |
There was a problem hiding this comment.
Suggested change
| qWarning() << "Can find default skin" << defaultSkinName; | |
| qWarning() << "Can't find default skin" << defaultSkinName; |
ronso0
force-pushed
the
skins-path-tweaks
branch
from
c2f5830
to
603fddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some polishing / follow-up for #12463