Add analyser support for stem #13106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
skins
library
engine
ui
build
code quality
waveform
soundsource
analyzer
qml
labels
acolombier
force-pushed
the
feat/add-analyser-support-for-stem
branch
from
b0c7be0
to
8b03210
Compare
acolombier
force-pushed
the
feat/add-analyser-support-for-stem
branch
from
8b03210
to
eee4565
Compare
acolombier
force-pushed
the
feat/add-analyser-support-for-stem
branch
3 times, most recently
from
da6f983
to
97cb238
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
I think there's no need to support the Serato format, because it's only used for Seratos internal caching. We don't know if they store additional metadata in their library. |
acolombier
force-pushed
the
feat/add-analyser-support-for-stem
branch
from
97cb238
to
87b5659
Compare
acolombier
force-pushed
the
feat/add-analyser-support-for-stem
branch
from
87b5659
to
036015c
Compare
This will allow mix to read the multiple audio stereo channel (stem) of the file and mix them together as part of the deck audio processing
This will allow analyser to make the most of the multiple channels to analyze specific features of the track. It will also generate a multi channel waveform
acolombier
force-pushed
the
feat/add-analyser-support-for-stem
branch
from
036015c
to
8923656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make analysers compatible with multi channel and use the best channel for specific features.
As per the NI spec, the first stem is always the drum or rhythmic channel.
This means that:
All other analyser perform a stereo mix, except if multichannel is supported internally.
Finally, the waveform analyser will gather EQ samples for the mixed track and per-stem samples.
Depends on #13070