Add quick effect support on stem #13123
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
skins
effects
library
engine
ui
build
code quality
waveform
soundsource
analyzer
qml
labels
acolombier
changed the title
acolombier
force-pushed
the
feat/add-quick-fx-on-stem
branch
2 times, most recently
from
463cea7
to
fc42319
Compare
acolombier
force-pushed
the
feat/add-quick-fx-on-stem
branch
2 times, most recently
from
a19d91e
to
0aab61d
Compare
acolombier
force-pushed
the
feat/add-quick-fx-on-stem
branch
2 times, most recently
from
db6b8ea
to
abc909c
Compare
|
Two minor remarks regarding the floating widgets:
|
|
Yeah, that widget definitely would need some refactoring, but I think the deal was to remove it before we merge that feature, and is only here to facilitate testing, thus I didn't want to spend too much time with it. |
|
I suggested to move the floating widgets in an own PR, to not block merging this PR and the PRs before. |
|
Ah I had misunderstood the plan for that. Sounds good then, I try and see if I can use the effect state indicator used in the effect bar instead of the mixer one. |
This will allow mix to read the multiple audio stereo channel (stem) of the file and mix them together as part of the deck audio processing
This will allow analyser to make the most of the multiple channels to analyze specific features of the track. It will also generate a multi channel waveform
Allow volume control of stem channels as well as basic UI feedback and control
acolombier
force-pushed
the
feat/add-quick-fx-on-stem
branch
from
e05f296
to
36312a8
Compare
This allows the effect manager to apply quick effect on each stem. Effects are applied post stem fader, but pre deck fader
acolombier
force-pushed
the
feat/add-quick-fx-on-stem
branch
from
36312a8
to
b2c3d25
Compare
acolombier
force-pushed
the
feat/add-quick-fx-on-stem
branch
from
b2c3d25
to
b49e163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kooha-2024-04-17-19-45-50.mp4
Depends on #13106