(fix) WCoverArt: popup on click release #13182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW I discovered this by chance when trying to view a cover in a live session. |
ronso0
changed the title
daschuer
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13181
Forgot to backport #13035
Though, I'm confused why this can break so easily.
FWIW, this is what various button tests return for trackpad click release with Qt 5.12.8:
FALSE pEvent->buttons() & Qt::LeftButton
FALSE pEvent->buttons() == Qt::LeftButton
FALSE pEvent->buttons().testFlag(Qt::LeftButton)
TRUE pEvent->button() == Qt::LeftButton (fix)
pEvent->buttons() == Qt::LeftButtonpEvent->button()